[{"id":856,"web_url":"https://patchwork.libcamera.org/comment/856/","msgid":"<20190222105112.GF3522@pendragon.ideasonboard.com>","date":"2019-02-22T10:51:12","subject":"Re: [libcamera-devel] [PATCH 3/4] libcamera: pipeline: vimc:\n\tenforce stream configuration","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Thu, Feb 21, 2019 at 12:59:38AM +0100, Niklas Söderlund wrote:\n> The format requested by configureStreams() should exactly match what\n> programmed on the video device it self. If they do not match the call\n> should fail as the application in that case will not know what\n> configuration actually was programmed.\n\nSame comments as for 2/4, but in any case,\n\nReviewed-by: Laurent Pinchart \n\nfor 2/4 and 3/4 (I forgot to add it to my reply to 2/4)\n\n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/pipeline/vimc.cpp | 12 +++++++++++-\n> 1 file changed, 11 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\n> index a93a7589643834c6..812777cffbb3e618 100644\n> --- a/src/libcamera/pipeline/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc.cpp\n> @@ -83,6 +83,7 @@ int PipelineHandlerVimc::configureStreams(Camera *camera,\n> \t\t\t\t std::map &config)\n> {\n> \tStreamConfiguration *cfg = &config[&stream_];\n> +\tint ret;\n> \n> \tLOG(VIMC, Debug) << \"Configure the camera for resolution \"\n> \t\t\t << cfg->width << \"x\" << cfg->height;\n> @@ -92,7 +93,16 @@ int PipelineHandlerVimc::configureStreams(Camera *camera,\n> \tformat.height = cfg->height;\n> \tformat.fourcc = cfg->pixelFormat;\n> \n> -\treturn video_->setFormat(&format);\n> +\tret = video_->setFormat(&format);\n> +\tif (ret)\n> +\t\treturn ret;\n> +\n> +\tif (format.width != cfg->width ||\n> +\t format.height != cfg->height ||\n> +\t format.fourcc != cfg->pixelFormat)\n> +\t\treturn -EINVAL;\n> +\n> +\treturn 0;\n> }\n> \n> int PipelineHandlerVimc::allocateBuffers(Camera *camera, Stream *stream)","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CD809600FD\n\tfor ;\n\tFri, 22 Feb 2019 11:51:17 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1E414255;\n\tFri, 22 Feb 2019 11:51:16 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1550832677;\n\tbh=4dDWiOPvEZZyWg7aiE4XmjK2xKX629SjIvZL73aIRl4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fIJ1dESp3+wrspj4E/oa0zJFB1rvH68N6yFg1SxS/Y8QC75Yxa7OjEkKAlwmjo1kp\n\tQubNm0mY1ir8jmxjosujZ+g2gql0eaYUAQJT144vo13dz/twfUdk/dkhqmwP1TOiox\n\t5snqq3uRfhQaDt37flcp7SUIapIMd7yErf9NrRKk=","Date":"Fri, 22 Feb 2019 12:51:12 +0200","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190222105112.GF3522@pendragon.ideasonboard.com>","References":"<20190220235939.25147-1-niklas.soderlund@ragnatech.se>\n\t<20190220235939.25147-4-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190220235939.25147-4-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 3/4] libcamera: pipeline: vimc:\n\tenforce stream configuration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 22 Feb 2019 10:51:18 -0000"}}]