[{"id":845,"web_url":"https://patchwork.libcamera.org/comment/845/","msgid":"<20190222003346.GO3485@pendragon.ideasonboard.com>","date":"2019-02-22T00:33:46","subject":"Re: [libcamera-devel] [PATCH 3/4] cam: fix printing of camera name","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Wed, Feb 20, 2019 at 03:37:35PM +0100, Niklas Söderlund wrote:\n> Since commit c8c546fe99a343c1 (\"cam: options: Add option type handling\n> to options parser\") introduced type handling for options the context the\n> option is read became important. When reading the camera option for\n> printing there is no explicit context to print it as a string and\n> instead the int context was chosen resulting in:\n> \n> $ cam --camera foo\n> Camera 0 not found\n> \n> While the expected output is:\n> \n> $ cam --camera foo\n> Camera foo not found\n> \n> Fix this by providing the correct context for the camera option when\n> printing it.\n> \n> Signed-off-by: Niklas Söderlund \n\nWith a Fixes: lines,\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/cam/main.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> index 30267970a2c8485f..522d2f0d3373dc25 100644\n> --- a/src/cam/main.cpp\n> +++ b/src/cam/main.cpp\n> @@ -233,7 +233,8 @@ int main(int argc, char **argv)\n> \tif (options.isSet(OptCamera)) {\n> \t\tcamera = cm->get(options[OptCamera]);\n> \t\tif (!camera) {\n> -\t\t\tstd::cout << \"Camera \" << options[OptCamera]\n> +\t\t\tstd::cout << \"Camera \"\n> +\t\t\t\t << std::string(options[OptCamera])\n> \t\t\t\t << \" not found\" << std::endl;\n> \t\t\tgoto out;\n> \t\t}","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 91952600FB\n\tfor ;\n\tFri, 22 Feb 2019 01:33:51 +0100 (CET)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F1BCF255;\n\tFri, 22 Feb 2019 01:33:50 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1550795631;\n\tbh=CzTn/XC3CUSSBRsNgt3bPpaC63F9GHcelRHQdYdpjso=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Wm0ZwqISrWlhLQL/uo1snfEFUR7KEcWiaeGxwiVHJkokg77Rkh1f0RphGmUYNpOzR\n\tHcRkIgQwm7WYG+ciYoO1BT4K6pi9PcJ9QncXh765s7XaRzmPBjMzFbYZXWfFaEr9cK\n\tCgdpmS958XLYNR/RkQssYM7GYIp6I/h7vL8vOAtU=","Date":"Fri, 22 Feb 2019 02:33:46 +0200","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190222003346.GO3485@pendragon.ideasonboard.com>","References":"<20190220143736.529-1-niklas.soderlund@ragnatech.se>\n\t<20190220143736.529-4-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190220143736.529-4-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 3/4] cam: fix printing of camera name","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 22 Feb 2019 00:33:51 -0000"}}]