[{"id":847,"web_url":"https://patchwork.libcamera.org/comment/847/","msgid":"<20190222003445.GQ3485@pendragon.ideasonboard.com>","date":"2019-02-22T00:34:45","subject":"Re: [libcamera-devel] [PATCH 2/4] cam: improve error checking when\n\tcapturing","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Wed, Feb 20, 2019 at 03:37:34PM +0100, Niklas Söderlund wrote:\n> The return value when start() and stop() the camera should be checked\n> and handled.\n> \n> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  src/cam/main.cpp | 11 +++++++++--\n>  1 file changed, 9 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> index b034eb25429abeb3..30267970a2c8485f 100644\n> --- a/src/cam/main.cpp\n> +++ b/src/cam/main.cpp\n> @@ -183,11 +183,18 @@ static int capture()\n>  \t}\n>  \n>  \tstd::cout << \"Capture until user interrupts by SIGINT\" << std::endl;\n> -\tcamera->start();\n> +\n> +\tret = camera->start();\n> +\tif (ret) {\n> +\t\tstd::cout << \"Failed to start capture\" << std::endl;\n> +\t\tgoto out;\n> +\t}\n>  \n>  \tret = loop->exec();\n>  \n> -\tcamera->stop();\n> +\tret = camera->stop();\n> +\tif (ret)\n> +\t\tstd::cout << \"Failed to stop capture\" << std::endl;\n>  out:\n>  \tcamera->freeBuffers();\n>","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 77BF7600FB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 22 Feb 2019 01:34:50 +0100 (CET)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0E816255;\n\tFri, 22 Feb 2019 01:34:50 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1550795690;\n\tbh=vZAklC6a28htztFzVJdjOMQYzr3f69G/t9QgIO9K/ds=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Cie8Sei01TcMEgCGO7XDm0t4W40a+5urVbpNKLhPPz8AKf7tmF0eFZVrGToy6bWd3\n\tjOsoCK9BuUzCBP3MI+LK3LJ9Lh66ZaeVCkUgXOdscllpxyxOAatFbThLYSCWRr8OgV\n\tVCaS0rA2omd44TlGugvn8iUcvdckS97zU6JSnA7s=","Date":"Fri, 22 Feb 2019 02:34:45 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Niklas =?utf-8?q?S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190222003445.GQ3485@pendragon.ideasonboard.com>","References":"<20190220143736.529-1-niklas.soderlund@ragnatech.se>\n\t<20190220143736.529-3-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190220143736.529-3-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 2/4] cam: improve error checking when\n\tcapturing","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 22 Feb 2019 00:34:50 -0000"}}]