{"id":590,"url":"https://patchwork.libcamera.org/api/patches/590/?format=json","web_url":"https://patchwork.libcamera.org/patch/590/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190220131757.14004-3-jacopo@jmondi.org>","date":"2019-02-20T13:17:54","name":"[libcamera-devel,2/5] libcamera: ipu3: Return video output default configuration","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"63bc2668cadc2f4477fd78a0452e97ac72116261","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/590/mbox/","series":[{"id":186,"url":"https://patchwork.libcamera.org/api/series/186/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=186","date":"2019-02-20T13:17:52","name":"libcamera: IPU3: create CIO2 and IMGU devices","version":1,"mbox":"https://patchwork.libcamera.org/series/186/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/590/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/590/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1C1CC601E4\n\tfor ;\n\tWed, 20 Feb 2019 14:17:41 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id A976540014;\n\tWed, 20 Feb 2019 13:17:40 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 20 Feb 2019 14:17:54 +0100","Message-Id":"<20190220131757.14004-3-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20190220131757.14004-1-jacopo@jmondi.org>","References":"<20190220131757.14004-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/5] libcamera: ipu3: Return video output\n\tdefault configuration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 20 Feb 2019 13:17:41 -0000"},"content":"Return default configuration for the output stream produced by the imgu\n'output' video node.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 16 +++-------------\n 1 file changed, 3 insertions(+), 13 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 9694d0ce51ab..9065073913a2 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -99,21 +99,11 @@ PipelineHandlerIPU3::streamConfiguration(Camera *camera,\n {\n \tIPU3CameraData *data = cameraData(camera);\n \tstd::map configs;\n-\tV4L2SubdeviceFormat format = {};\n-\n-\t/*\n-\t * FIXME: As of now, return the image format reported by the sensor.\n-\t * In future good defaults should be provided for each stream.\n-\t */\n-\tif (data->sensor_->getFormat(0, &format)) {\n-\t\tLOG(IPU3, Error) << \"Failed to create stream configurations\";\n-\t\treturn configs;\n-\t}\n \n \tStreamConfiguration config = {};\n-\tconfig.width = format.width;\n-\tconfig.height = format.height;\n-\tconfig.pixelFormat = V4L2_PIX_FMT_IPU3_SGRBG10;\n+\tconfig.width = 2560;\n+\tconfig.height = 1920;\n+\tconfig.pixelFormat = V4L2_PIX_FMT_NV12;\n \tconfig.bufferCount = 4;\n \n \tconfigs[&data->stream_] = config;\n","prefixes":["libcamera-devel","2/5"]}