[{"id":830,"web_url":"https://patchwork.libcamera.org/comment/830/","msgid":"<20190221153255.GE11484@bigcity.dyn.berto.se>","date":"2019-02-21T15:32:55","subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: v4l2_subdevice: Add\n\tsubdevice name","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your patch.\n\nOn 2019-02-19 17:56:19 +0100, Jacopo Mondi wrote:\n> Add a deviceName_ field that contains the human readable name of the\n> subdevice, which is created using the name of the associated media\n> entity.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/include/v4l2_subdevice.h | 2 ++\n> src/libcamera/v4l2_subdevice.cpp | 9 ++++++++-\n> 2 files changed, 10 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/include/v4l2_subdevice.h b/src/libcamera/include/v4l2_subdevice.h\n> index c7045776555c..40becd0ca99b 100644\n> --- a/src/libcamera/include/v4l2_subdevice.h\n> +++ b/src/libcamera/include/v4l2_subdevice.h\n> @@ -42,6 +42,7 @@ public:\n> \tvoid close();\n> \n> \tstd::string deviceNode() const { return deviceNode_; }\n> +\tstd::string deviceName() const { return deviceName_; }\n> \n> \tint setCrop(unsigned int pad, Rectangle *rect);\n> \tint setCompose(unsigned int pad, Rectangle *rect);\n> @@ -55,6 +56,7 @@ private:\n> \t\t\t Rectangle *rect);\n> \n> \tstd::string deviceNode_;\n> +\tstd::string deviceName_;\n> \tint fd_;\n> };\n> \n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index 5665154a2762..4411ffa51460 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -134,7 +134,7 @@ LOG_DEFINE_CATEGORY(V4L2Subdev)\n> * path\n> */\n> V4L2Subdevice::V4L2Subdevice(const MediaEntity *entity)\n> -\t: deviceNode_(entity->deviceNode()), fd_(-1)\n> +\t: deviceNode_(entity->deviceNode()), deviceName_(entity->name()), fd_(-1)\n> {\n> }\n> \n> @@ -193,6 +193,13 @@ void V4L2Subdevice::close()\n> * \\return The subdevice's device node system path\n> */\n> \n> +/**\n> + * \\fn V4L2Subdevice::deviceName()\n> + * \\brief Retrieve the name of the media entity associated with the subdevice\n> + *\n> + * \\return The name of the media entity the subdevice is associated to\n> + */\n> +\n> /**\n> * \\brief Set a crop rectangle on one of the V4L2 subdevice pads\n> * \\param[in] pad The 0-indexed pad number the rectangle is to be applied to\n> -- \n> 2.20.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x144.google.com (mail-lf1-x144.google.com\n\t[IPv6:2a00:1450:4864:20::144])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A7195600FB\n\tfor ;\n\tThu, 21 Feb 2019 16:32:57 +0100 (CET)","by mail-lf1-x144.google.com with SMTP id h10so20457840lfc.12\n\tfor ;\n\tThu, 21 Feb 2019 07:32:57 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tl20sm3882022ljb.24.2019.02.21.07.32.56\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 21 Feb 2019 07:32:56 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=z5hPngVQnUtGxW7mvd3ICYi9VUG7CnWf4kwVTQ/bLtE=;\n\tb=CSychII2ARjz6XJsB39aoV589ckjWrdUPZk8KpRkE1NIf3nGhaK+Ew+gEheDim7LI6\n\t14pDaTMXAzeCMCJI+/H9n7EIRM4NFt6KzIEsD/OTJCQKiSMKCZ4dcZqwU1peHX3B9W2l\n\taGKcxJI4psc+XysBD9PfOX5txVuAsooIuHwoG512XaKgukDmu+xTiPTuGCMZZ3coJJur\n\t0Zb3ONJx74XT6lf4WQabpeNcq5+H9A4JEzXfmQRQG1CfsQxD11UDLcFqCPDYB7aRFRwL\n\tKaO67D6875aBBRMTn87TZLk5Ed+s6Vou11ATa05KXwJS5E7+iFmwm2DY2sebsCgpBoBl\n\tSk3g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=z5hPngVQnUtGxW7mvd3ICYi9VUG7CnWf4kwVTQ/bLtE=;\n\tb=EWglUKn6VMJoYFNKy0lEEWs0uRLiYDkmtVf6wBGpfw1awX2a5RDf9oskaiPFzEuzTx\n\tVHYI1/1B9lgFHQlpZrXx2ptEXsqWXiJ5gTeb874usF6ayT/MFKS0Qv/O9jQuBIkjbpY3\n\tP8PGYSOOMcDdM7vl0f6/80Lx5QmEH2z5MCOCQh2+WdLoOBub7TRvUehz9sNck1fqEDnT\n\tNOMJvElT5VpqCkDg/7MSwA9qyDdoQw0DPmIbFqkELAoYqbGfeBpVeGwZhRObEr/dQs9K\n\t0K8kaDVudxeAOQbzSHo3pmXXz13IZ2b0KR+4BPvt/6yLP6ntyYLy2mOKyMoErKPxrEWC\n\tJIyw==","X-Gm-Message-State":"AHQUAua6jexm/I6ZA4Kkjcp70atgHYLn84IPLZjD912ITk0M4gn/cRFl\n\tPeBw+mvBYPOZmFVQMVX3AFDKcd7/NQg=","X-Google-Smtp-Source":"AHgI3IZldFgRhh9zzZPn6oKNf2QrSX8dTVJ9WJ2j3ANEPBxcTRAZwudl3GXhuoJYXwBG429Lf7jtBA==","X-Received":"by 2002:a19:a404:: with SMTP id\n\tq4mr22024351lfc.113.1550763176842; \n\tThu, 21 Feb 2019 07:32:56 -0800 (PST)","Date":"Thu, 21 Feb 2019 16:32:55 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190221153255.GE11484@bigcity.dyn.berto.se>","References":"<20190219165620.2385-1-jacopo@jmondi.org>\n\t<20190219165620.2385-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190219165620.2385-3-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: v4l2_subdevice: Add\n\tsubdevice name","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 21 Feb 2019 15:32:57 -0000"}},{"id":836,"web_url":"https://patchwork.libcamera.org/comment/836/","msgid":"<20190221231949.GF3485@pendragon.ideasonboard.com>","date":"2019-02-21T23:19:49","subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: v4l2_subdevice: Add\n\tsubdevice name","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Feb 19, 2019 at 05:56:19PM +0100, Jacopo Mondi wrote:\n> Add a deviceName_ field that contains the human readable name of the\n> subdevice, which is created using the name of the associated media\n> entity.\n\nHow about naming this name() instead of deviceName() ?\n\nI also wonder if it would make sense to store a pointer to the media\nentity, in order to allow easy access to other fields, instead of\nduplicating the information. We wouldn't need to store deviceNode_ in\nthat case, just return entity_->deviceNode().\n\n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/include/v4l2_subdevice.h | 2 ++\n> src/libcamera/v4l2_subdevice.cpp | 9 ++++++++-\n> 2 files changed, 10 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/include/v4l2_subdevice.h b/src/libcamera/include/v4l2_subdevice.h\n> index c7045776555c..40becd0ca99b 100644\n> --- a/src/libcamera/include/v4l2_subdevice.h\n> +++ b/src/libcamera/include/v4l2_subdevice.h\n> @@ -42,6 +42,7 @@ public:\n> \tvoid close();\n> \n> \tstd::string deviceNode() const { return deviceNode_; }\n> +\tstd::string deviceName() const { return deviceName_; }\n> \n> \tint setCrop(unsigned int pad, Rectangle *rect);\n> \tint setCompose(unsigned int pad, Rectangle *rect);\n> @@ -55,6 +56,7 @@ private:\n> \t\t\t Rectangle *rect);\n> \n> \tstd::string deviceNode_;\n> +\tstd::string deviceName_;\n> \tint fd_;\n> };\n> \n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index 5665154a2762..4411ffa51460 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -134,7 +134,7 @@ LOG_DEFINE_CATEGORY(V4L2Subdev)\n> * path\n> */\n> V4L2Subdevice::V4L2Subdevice(const MediaEntity *entity)\n> -\t: deviceNode_(entity->deviceNode()), fd_(-1)\n> +\t: deviceNode_(entity->deviceNode()), deviceName_(entity->name()), fd_(-1)\n> {\n> }\n> \n> @@ -193,6 +193,13 @@ void V4L2Subdevice::close()\n> * \\return The subdevice's device node system path\n> */\n> \n> +/**\n> + * \\fn V4L2Subdevice::deviceName()\n> + * \\brief Retrieve the name of the media entity associated with the subdevice\n> + *\n> + * \\return The name of the media entity the subdevice is associated to\n> + */\n> +\n> /**\n> * \\brief Set a crop rectangle on one of the V4L2 subdevice pads\n> * \\param[in] pad The 0-indexed pad number the rectangle is to be applied to","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 85B49600FB\n\tfor ;\n\tFri, 22 Feb 2019 00:19:54 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C5E16255;\n\tFri, 22 Feb 2019 00:19:53 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1550791194;\n\tbh=Miw1V3/fXorf5hqW2OM/aFZWlIL2wqy/PN+vEST8CY4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Xv12rjY4g6vNFHH0FUpDvdFarPl5fLI29pHGQhhbKmNI7clJNB5U3RcNobxCsZASD\n\t25ULBaz0WzZjWnk17E9fZ5+F27M2RAMYEGxmyl//vucBG68m+bLZBpcQASEKUpBFDC\n\tgPE8CGGvIpE6b1iWlAm6/CfLuBO9F+LDsxD82ZFE=","Date":"Fri, 22 Feb 2019 01:19:49 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190221231949.GF3485@pendragon.ideasonboard.com>","References":"<20190219165620.2385-1-jacopo@jmondi.org>\n\t<20190219165620.2385-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190219165620.2385-3-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: v4l2_subdevice: Add\n\tsubdevice name","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 21 Feb 2019 23:19:54 -0000"}},{"id":844,"web_url":"https://patchwork.libcamera.org/comment/844/","msgid":"<20190222003339.GJ11484@bigcity.dyn.berto.se>","date":"2019-02-22T00:33:39","subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: v4l2_subdevice: Add\n\tsubdevice name","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo, Laurent,\n\nOn 2019-02-22 01:19:49 +0200, Laurent Pinchart wrote:\n> Hi Jacopo,\n> \n> Thank you for the patch.\n> \n> On Tue, Feb 19, 2019 at 05:56:19PM +0100, Jacopo Mondi wrote:\n> > Add a deviceName_ field that contains the human readable name of the\n> > subdevice, which is created using the name of the associated media\n> > entity.\n> \n> How about naming this name() instead of deviceName() ?\n> \n> I also wonder if it would make sense to store a pointer to the media\n> entity, in order to allow easy access to other fields, instead of\n> duplicating the information. We wouldn't need to store deviceNode_ in\n> that case, just return entity_->deviceNode().\n\nI like the idea.\n\n> \n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > src/libcamera/include/v4l2_subdevice.h | 2 ++\n> > src/libcamera/v4l2_subdevice.cpp | 9 ++++++++-\n> > 2 files changed, 10 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/include/v4l2_subdevice.h b/src/libcamera/include/v4l2_subdevice.h\n> > index c7045776555c..40becd0ca99b 100644\n> > --- a/src/libcamera/include/v4l2_subdevice.h\n> > +++ b/src/libcamera/include/v4l2_subdevice.h\n> > @@ -42,6 +42,7 @@ public:\n> > \tvoid close();\n> > \n> > \tstd::string deviceNode() const { return deviceNode_; }\n> > +\tstd::string deviceName() const { return deviceName_; }\n> > \n> > \tint setCrop(unsigned int pad, Rectangle *rect);\n> > \tint setCompose(unsigned int pad, Rectangle *rect);\n> > @@ -55,6 +56,7 @@ private:\n> > \t\t\t Rectangle *rect);\n> > \n> > \tstd::string deviceNode_;\n> > +\tstd::string deviceName_;\n> > \tint fd_;\n> > };\n> > \n> > diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> > index 5665154a2762..4411ffa51460 100644\n> > --- a/src/libcamera/v4l2_subdevice.cpp\n> > +++ b/src/libcamera/v4l2_subdevice.cpp\n> > @@ -134,7 +134,7 @@ LOG_DEFINE_CATEGORY(V4L2Subdev)\n> > * path\n> > */\n> > V4L2Subdevice::V4L2Subdevice(const MediaEntity *entity)\n> > -\t: deviceNode_(entity->deviceNode()), fd_(-1)\n> > +\t: deviceNode_(entity->deviceNode()), deviceName_(entity->name()), fd_(-1)\n> > {\n> > }\n> > \n> > @@ -193,6 +193,13 @@ void V4L2Subdevice::close()\n> > * \\return The subdevice's device node system path\n> > */\n> > \n> > +/**\n> > + * \\fn V4L2Subdevice::deviceName()\n> > + * \\brief Retrieve the name of the media entity associated with the subdevice\n> > + *\n> > + * \\return The name of the media entity the subdevice is associated to\n> > + */\n> > +\n> > /**\n> > * \\brief Set a crop rectangle on one of the V4L2 subdevice pads\n> > * \\param[in] pad The 0-indexed pad number the rectangle is to be applied to\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BDC1C600FB\n\tfor ;\n\tFri, 22 Feb 2019 01:33:41 +0100 (CET)","by mail-lf1-x141.google.com with SMTP id z15so454288lff.4\n\tfor ;\n\tThu, 21 Feb 2019 16:33:41 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tb191sm93036lfd.56.2019.02.21.16.33.40\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 21 Feb 2019 16:33:40 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=ohHjV2wJr+doblr2DQYijrLHw7mmlg6qKloD9j9p1NQ=;\n\tb=16qDVRSjx7qtygC/Lg9IZxOkdtboLHaeP9Tg6SplTILKN6op8MgMWEeZGHMK/wLvm7\n\t8MDtJp1IPQU6mbi60wblXkztPEqJmwhV4hKXHOQ0Wzze/jAop6v9tpTC4GpfKc0z0wyj\n\tuHAbskgL0FDAh6AGG/O9+NfNs7arQv3MGH1QqzY7fnEsiqzdEvVpX/jIPUYuTiVmAAjj\n\tu0dNB18KAi2vmoL2aV/4vKK63unD7FrgAMtaph90ccWygqBNLpQbWtIyHrKOsTxKAonX\n\tQnQsduMP+NA0wvQo4pThFqRbyYQf8QZIpDGNXBlUtSz1t0WYs3igylK9d5slj17Ymynj\n\tpQ9A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=ohHjV2wJr+doblr2DQYijrLHw7mmlg6qKloD9j9p1NQ=;\n\tb=uDnfSKCOj+Xslqx+h152Zydjdf8sh4XH+5o5NaQU3rsNdytPpwDSho4XyuQ0EW7N7u\n\tB7H5gGVEL9AYIlPCReRCIe47WV3wkzMHUhBzV+j2kknl2B/wzCGR5jy+10dS/Wv56lxI\n\tvXIu7ioVlROQgKZMObzOz8bOm0zStgKrT6aWzvPc+YMnu3RPoDXGZyXtQLddR2pOu/xq\n\tWQwcBZBDPf0O/B8KcxJmCmTp6Q8SdCxOPDGEsF09mbmoYipC/GWfC+BikdMuaCaz4vvM\n\tFSp8Nm/j0/neezJFVWLOb7mzl7kY1z0c85wVr0zRyBux8nXuNBCH3lA5GC3PfeUXrALx\n\t6y+w==","X-Gm-Message-State":"AHQUAua+reZsWC6N1Z3PLJzbVHfYpCzoyRWE6ixEUDfxrZ+xxbCxXWKB\n\t0Lh+SANYr4Urb4S5aps8ufUOVpfH4tg=","X-Google-Smtp-Source":"AHgI3IbQDi5XImrz8YD1TkD39LoG5tyl9RHwENTwDUHRo7ctg0yoo29w+yZYThhn5pnteo0mmtVq1w==","X-Received":"by 2002:a19:e305:: with SMTP id a5mr641114lfh.69.1550795620909; \n\tThu, 21 Feb 2019 16:33:40 -0800 (PST)","Date":"Fri, 22 Feb 2019 01:33:39 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","Message-ID":"<20190222003339.GJ11484@bigcity.dyn.berto.se>","References":"<20190219165620.2385-1-jacopo@jmondi.org>\n\t<20190219165620.2385-3-jacopo@jmondi.org>\n\t<20190221231949.GF3485@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190221231949.GF3485@pendragon.ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: v4l2_subdevice: Add\n\tsubdevice name","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 22 Feb 2019 00:33:42 -0000"}}]