{"id":582,"url":"https://patchwork.libcamera.org/api/patches/582/?format=json","web_url":"https://patchwork.libcamera.org/patch/582/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190218173038.13822-1-jacopo@jmondi.org>","date":"2019-02-18T17:30:38","name":"[libcamera-devel] libcamera: v4l2_subdevice: Fix S_SELECTION ioctl argument","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"b032fc3174e6226dcc9359cb4d7cc9b585350ea2","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/582/mbox/","series":[{"id":183,"url":"https://patchwork.libcamera.org/api/series/183/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=183","date":"2019-02-18T17:30:38","name":"[libcamera-devel] libcamera: v4l2_subdevice: Fix S_SELECTION ioctl argument","version":1,"mbox":"https://patchwork.libcamera.org/series/183/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/582/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/582/checks/","tags":{},"headers":{"Return-Path":"<jacopo@jmondi.org>","Received":["from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B794D600FE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 18 Feb 2019 18:30:22 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 28321FF80E;\n\tMon, 18 Feb 2019 17:30:21 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 18 Feb 2019 18:30:38 +0100","Message-Id":"<20190218173038.13822-1-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.20.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: v4l2_subdevice: Fix\n\tS_SELECTION ioctl argument","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 18 Feb 2019 17:30:22 -0000"},"content":"The SUBDEV_S_SELECTION argument needs to be a pointer. Fix it.\n\nFixes: 468176fa07d9 (\"libcamera: Add V4L2Subdevice\")\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/v4l2_subdevice.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n--\n2.20.1","diff":"diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\nindex 17f715fe707a..b436f73cc75f 100644\n--- a/src/libcamera/v4l2_subdevice.cpp\n+++ b/src/libcamera/v4l2_subdevice.cpp\n@@ -250,7 +250,7 @@ int V4L2Subdevice::setSelection(unsigned int pad, unsigned int target,\n \tsel.r.width = rect->w;\n \tsel.r.height = rect->h;\n\n-\tint ret = ioctl(fd_, VIDIOC_SUBDEV_S_SELECTION, sel);\n+\tint ret = ioctl(fd_, VIDIOC_SUBDEV_S_SELECTION, &sel);\n \tif (ret < 0) {\n \t\tret = -errno;\n \t\tLOG(V4L2Subdev, Error)\n","prefixes":["libcamera-devel"]}