[{"id":825,"web_url":"https://patchwork.libcamera.org/comment/825/","msgid":"<20190213172303.GR5332@pendragon.ideasonboard.com>","date":"2019-02-13T17:23:03","subject":"Re: [libcamera-devel] [PATCH v3 2/3] test: v4l2_device: release\n\tcapture device resources","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Wed, Feb 13, 2019 at 05:14:52PM +0000, Kieran Bingham wrote:\n> Ensure that the cleanup operation releases the device and resources.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  test/v4l2_device/v4l2_device_test.cpp | 4 ++++\n>  1 file changed, 4 insertions(+)\n> \n> diff --git a/test/v4l2_device/v4l2_device_test.cpp b/test/v4l2_device/v4l2_device_test.cpp\n> index 2bdf8cfe983a..4225291bbb6e 100644\n> --- a/test/v4l2_device/v4l2_device_test.cpp\n> +++ b/test/v4l2_device/v4l2_device_test.cpp\n> @@ -63,5 +63,9 @@ void V4L2DeviceTest::cleanup()\n>  {\n>  \tmedia_->release();\n>  \n> +\tcapture_->streamOff();\n> +\tcapture_->releaseBuffers();\n> +\tcapture_->close();\n> +\n>  \tdelete capture_;\n>  };","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C7CA160DBB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 13 Feb 2019 18:23:06 +0100 (CET)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 619CD304;\n\tWed, 13 Feb 2019 18:23:06 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1550078586;\n\tbh=0J5ppUEYG2r+13Y4rDP7c1Zlw/dE6HRDz+COQZVN0mU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=qBCnnDTRNayeNUKKtFht71HwzFAo/wxJbaWyzK5gQprjZjspqjI+zQPqQbzMZpVA8\n\t2uhDm0d4LpMbKwugUMIZAyHsVWn0bLVgszrN0hdRqLmAS2XQEAjRfGfA10wxz6EJvS\n\t6eVFbm6zqUWrGWYZ8dU7Qud6oewbY8LUFh3VFFdI=","Date":"Wed, 13 Feb 2019 19:23:03 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Message-ID":"<20190213172303.GR5332@pendragon.ideasonboard.com>","References":"<20190213171453.13852-1-kieran.bingham@ideasonboard.com>\n\t<20190213171453.13852-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190213171453.13852-3-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v3 2/3] test: v4l2_device: release\n\tcapture device resources","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Wed, 13 Feb 2019 17:23:07 -0000"}}]