{"id":572,"url":"https://patchwork.libcamera.org/api/patches/572/?format=json","web_url":"https://patchwork.libcamera.org/patch/572/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190213151027.6376-4-kieran.bingham@ideasonboard.com>","date":"2019-02-13T15:10:22","name":"[libcamera-devel,v2,3/8] libcamera: v4l2_device: streamOff() when releasing buffers","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"eb038516c58b5a3e0f0fdb32d4da44739bff4346","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/572/mbox/","series":[{"id":181,"url":"https://patchwork.libcamera.org/api/series/181/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=181","date":"2019-02-13T15:10:19","name":"libcamera: v4l2_device buffer sharing","version":2,"mbox":"https://patchwork.libcamera.org/series/181/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/572/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/572/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 40050610B3\n\tfor ;\n\tWed, 13 Feb 2019 16:10:33 +0100 (CET)","from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D5B2C9A5;\n\tWed, 13 Feb 2019 16:10:32 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1550070633;\n\tbh=82pPgT7VeMS1QMd0DnOjk6Y3MuE2k9tcwpUCTpCPNxo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=YOIg8bDoVBxtczGmqWqMqaOSKOSno2Sw9TireaxzVk9lfd8hwCOaKBsLAsYxhQOvB\n\tZ4asZ4qYekkaQ5QAaxaVF2x0YBYT1OJwcUW7uDB4u9koncd1DsXCTQId+YmKeR/eFB\n\tlOYuG5QgVrGlB+/M9OjohMm+NA7Tw+cJkZf2ZPNQ=","From":"Kieran Bingham ","To":"LibCamera Devel ","Date":"Wed, 13 Feb 2019 15:10:22 +0000","Message-Id":"<20190213151027.6376-4-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.19.1","In-Reply-To":"<20190213151027.6376-1-kieran.bingham@ideasonboard.com>","References":"<20190213151027.6376-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 3/8] libcamera: v4l2_device:\n\tstreamOff() when releasing buffers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 13 Feb 2019 15:10:33 -0000"},"content":"We must ensure that the stream is disabled before releasing buffers. It will\nnot hurt to call streamOff() even if it is already off before releasing any\nbuffers back to the device.\n\nSigned-off-by: Kieran Bingham \n---\n src/libcamera/v4l2_device.cpp | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex 23c0da295905..83073c28b817 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -642,6 +642,8 @@ int V4L2Device::releaseBuffers()\n {\n \tLOG(V4L2, Debug) << \"Releasing bufferPool\";\n \n+\tstreamOff();\n+\n \trequestBuffers(0);\n \tbufferPool_ = nullptr;\n \n","prefixes":["libcamera-devel","v2","3/8"]}