[{"id":810,"web_url":"https://patchwork.libcamera.org/comment/810/","msgid":"<20190213154040.GE5332@pendragon.ideasonboard.com>","date":"2019-02-13T15:40:40","subject":"Re: [libcamera-devel] [PATCH v2 2/8] test: v4l2_device:\n\tcapture_async: End test at 30 frames","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Wed, Feb 13, 2019 at 03:10:21PM +0000, Kieran Bingham wrote:\n> The capture_async test was written to run for a fixed 5 second duration.\n> Modify the test such that it runs until it has captured 30 frames, or a 10\n> second time out occurs.\n> \n> Running the capture_async test on an ARM64 platform using VIVID captures 30\n> frames in 6.15 seconds.\n> \n> There may be scope to optimise this speed by changing the format on the capture\n> device.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> test/v4l2_device/capture_async.cpp | 7 +++++--\n> 1 file changed, 5 insertions(+), 2 deletions(-)\n> \n> diff --git a/test/v4l2_device/capture_async.cpp b/test/v4l2_device/capture_async.cpp\n> index 7a0735f65535..ba37c9731831 100644\n> --- a/test/v4l2_device/capture_async.cpp\n> +++ b/test/v4l2_device/capture_async.cpp\n> @@ -56,9 +56,12 @@ protected:\n> \t\tif (ret)\n> \t\t\treturn TestFail;\n> \n> -\t\ttimeout.start(5000);\n> -\t\twhile (timeout.isRunning())\n> +\t\ttimeout.start(10000);\n> +\t\twhile (timeout.isRunning()) {\n> \t\t\tdispatcher->processEvents();\n> +\t\t\tif (frames > 30)\n> +\t\t\t\tbreak;\n> +\t\t}\n> \n> \t\tif (frames < 1) {\n> \t\t\tstd::cout << \"Failed to capture any frames within timeout.\" << std::endl;","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4F180610AE\n\tfor ;\n\tWed, 13 Feb 2019 16:40:44 +0100 (CET)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DC42D85;\n\tWed, 13 Feb 2019 16:40:43 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1550072444;\n\tbh=L3lHmnr9LA06X0cme19NXplUdEDiFFHRnE0waEsUMB0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=UtzTkTL6N0vJYCweTN9lb386PVaGinBsxBvaEk80YAdHw0mL/vxHhL+Fl/TbkA+ex\n\tF3b7kr3iQ4TYM61hPdDK+tpVeDA2ee5dHo3a+nZMegxBzAbEkZ0bbz/EaIxn8e0RqP\n\t7iWnPzBy+rFmoIvfugdEOTCteNLGymb9BnNY3yDY=","Date":"Wed, 13 Feb 2019 17:40:40 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20190213154040.GE5332@pendragon.ideasonboard.com>","References":"<20190213151027.6376-1-kieran.bingham@ideasonboard.com>\n\t<20190213151027.6376-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190213151027.6376-3-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 2/8] test: v4l2_device:\n\tcapture_async: End test at 30 frames","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 13 Feb 2019 15:40:44 -0000"}}]