[{"id":809,"web_url":"https://patchwork.libcamera.org/comment/809/","msgid":"<20190213153934.GD5332@pendragon.ideasonboard.com>","date":"2019-02-13T15:39:34","subject":"Re: [libcamera-devel] [PATCH v2 1/8] test: v4l2_device: Use VIVID\n\tcapture stream","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Wed, Feb 13, 2019 at 03:10:20PM +0000, Kieran Bingham wrote:\n> Utilise the VIVID capture device for testing the V4L2Device objects.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> test/v4l2_device/v4l2_device_test.cpp | 18 +++++++++---------\n> 1 file changed, 9 insertions(+), 9 deletions(-)\n> \n> diff --git a/test/v4l2_device/v4l2_device_test.cpp b/test/v4l2_device/v4l2_device_test.cpp\n> index 18d014caf4c8..a2a7ba82612d 100644\n> --- a/test/v4l2_device/v4l2_device_test.cpp\n> +++ b/test/v4l2_device/v4l2_device_test.cpp\n> @@ -39,22 +39,22 @@ int V4L2DeviceTest::init()\n> \t\treturn TestFail;\n> \t}\n> \n> -\tDeviceMatch dm(\"uvcvideo\");\n> -\tmedia_ = std::move(enumerator_->search(dm));\n> +\tDeviceMatch dm(\"vivid\");\n> +\tdm.add(\"vivid-000-vid-cap\");\n> +\n> +\tmedia_ = enumerator_->search(dm);\n> \tif (!media_)\n> \t\treturn TestSkip;\n> \n> \tmedia_->acquire();\n> \n> -\tfor (MediaEntity *entity : media_->entities()) {\n> -\t\tif (entity->flags() & MEDIA_ENT_FL_DEFAULT) {\n> -\t\t\tdev_ = new V4L2Device(entity);\n> -\t\t\tbreak;\n> -\t\t}\n> -\t}\n> +\tMediaEntity *entity = media_->getEntityByName(\"vivid-000-vid-cap\");\n> +\tif (!entity)\n> +\t\treturn TestSkip;\n> \n> +\tdev_ = new V4L2Device(entity);\n> \tif (!dev_)\n> -\t\treturn TestSkip;\n> +\t\treturn TestFail;\n> \n> \treturn dev_->open();\n> }","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E07E0610AE\n\tfor ;\n\tWed, 13 Feb 2019 16:39:37 +0100 (CET)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5FFC885;\n\tWed, 13 Feb 2019 16:39:37 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1550072377;\n\tbh=L8yj8HDeywihZdkig8gOFspQreBrFRaoFQBy8V8x0ww=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=n45tlaa+m+tlwEbSmnv0JTA4Om6on1QFqZIBFg1jetYZC9HJy7pVvnlXTEgBdk+SF\n\tHHl9NypH3JCRbO4cjQDepJD4e3UJ701x9jBp1TJxKZaQ1KbpjeYLEbHWMpcO4S2XA2\n\ttP8f9Xveni2wiSgQ/OwVz0O8eiGDcMoKAFLaK+ww=","Date":"Wed, 13 Feb 2019 17:39:34 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20190213153934.GD5332@pendragon.ideasonboard.com>","References":"<20190213151027.6376-1-kieran.bingham@ideasonboard.com>\n\t<20190213151027.6376-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190213151027.6376-2-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 1/8] test: v4l2_device: Use VIVID\n\tcapture stream","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 13 Feb 2019 15:39:38 -0000"}}]