{"id":567,"url":"https://patchwork.libcamera.org/api/patches/567/?format=json","web_url":"https://patchwork.libcamera.org/patch/567/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190213122035.25309-4-kieran.bingham@ideasonboard.com>","date":"2019-02-13T12:20:35","name":"[libcamera-devel,3/3] libcamera: device_enumerator: Fix LOG usage","commit_ref":"613fc4000fa844174c86152d7131087e5a8feb06","pull_url":null,"state":"accepted","archived":false,"hash":"942aa6af75ea299d78ad4c6303a5f010b685b051","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/567/mbox/","series":[{"id":179,"url":"https://patchwork.libcamera.org/api/series/179/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=179","date":"2019-02-13T12:20:32","name":"Fix LOG usage","version":1,"mbox":"https://patchwork.libcamera.org/series/179/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/567/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/567/checks/","tags":{},"headers":{"Return-Path":"<kieran.bingham@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 50871610B6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 13 Feb 2019 13:20:40 +0100 (CET)","from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E421C85;\n\tWed, 13 Feb 2019 13:20:39 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1550060440;\n\tbh=sP/zv+8pL+F/Jf63LE2fIW+ZfWK6zytDX2mpESGJOTM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=n+FkPc+djDIKux5DH6OVtZXZx+hEMmdYI4iWmhotmdkv3Y4ONXfqEtTiqKSzXBUA6\n\tHm9X8TaCKJAVjaYaTauVTeNMp3i6BnVI6s+xLSyPAsmwlQfjKGKr/SuCuIrGElhbP+\n\trQdcaevywV2AFDtUJQKDjEzaluIKhEfu1HgBEvGI=","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Date":"Wed, 13 Feb 2019 12:20:35 +0000","Message-Id":"<20190213122035.25309-4-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.19.1","In-Reply-To":"<20190213122035.25309-1-kieran.bingham@ideasonboard.com>","References":"<20190213122035.25309-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 3/3] libcamera: device_enumerator: Fix LOG\n\tusage","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Wed, 13 Feb 2019 12:20:40 -0000"},"content":"Add the DeviceEnumerator category to the last LOG() call requiring it.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/device_enumerator.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\nindex 703b03dd418a..5a9d33534e56 100644\n--- a/src/libcamera/device_enumerator.cpp\n+++ b/src/libcamera/device_enumerator.cpp\n@@ -459,7 +459,8 @@ void DeviceEnumeratorUdev::udevNotify(EventNotifier *notifier)\n \tstd::string action(udev_device_get_action(dev));\n \tstd::string deviceNode(udev_device_get_devnode(dev));\n \n-\tLOG(Debug) << action << \" device \" << udev_device_get_devnode(dev);\n+\tLOG(DeviceEnumerator, Debug)\n+\t\t<< action << \" device \" << udev_device_get_devnode(dev);\n \n \tif (action == \"add\") {\n \t\taddDevice(deviceNode);\n","prefixes":["libcamera-devel","3/3"]}