[{"id":799,"web_url":"https://patchwork.libcamera.org/comment/799/","msgid":"<20190213104621.GO31044@bigcity.dyn.berto.se>","date":"2019-02-13T10:46:21","subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: signal: Fix coding\n\tstyle issues","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2019-02-13 00:37:01 +0200, Laurent Pinchart wrote:\n> Fix issues reported by checkstyle.py in preparation for further changes.\n> \n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\n> ---\n> Changes since v1:\n> \n> - Don't add a space after the template keyword\n> ---\n>  include/libcamera/signal.h | 16 ++++++++--------\n>  1 file changed, 8 insertions(+), 8 deletions(-)\n> \n> diff --git a/include/libcamera/signal.h b/include/libcamera/signal.h\n> index c375b0a878af..85dc481d6957 100644\n> --- a/include/libcamera/signal.h\n> +++ b/include/libcamera/signal.h\n> @@ -34,28 +34,28 @@ template<typename T, typename... Args>\n>  class SlotMember : public SlotBase<Args...>\n>  {\n>  public:\n> -\tSlotMember(T *obj, void(T::*func)(Args...))\n> +\tSlotMember(T *obj, void (T::*func)(Args...))\n>  \t\t: SlotBase<Args...>(obj), func_(func) { }\n>  \n>  \tvoid invoke(Args... args) { (static_cast<T *>(this->obj_)->*func_)(args...); }\n>  \n>  private:\n>  \tfriend class Signal<Args...>;\n> -\tvoid(T::*func_)(Args...);\n> +\tvoid (T::*func_)(Args...);\n>  };\n>  \n>  template<typename... Args>\n>  class SlotStatic : public SlotBase<Args...>\n>  {\n>  public:\n> -\tSlotStatic(void(*func)(Args...))\n> +\tSlotStatic(void (*func)(Args...))\n>  \t\t: SlotBase<Args...>(nullptr), func_(func) { }\n>  \n>  \tvoid invoke(Args... args) { (*func_)(args...); }\n>  \n>  private:\n>  \tfriend class Signal<Args...>;\n> -\tvoid(*func_)(Args...);\n> +\tvoid (*func_)(Args...);\n>  };\n>  \n>  template<typename... Args>\n> @@ -70,12 +70,12 @@ public:\n>  \t}\n>  \n>  \ttemplate<typename T>\n> -\tvoid connect(T *object, void(T::*func)(Args...))\n> +\tvoid connect(T *object, void (T::*func)(Args...))\n>  \t{\n>  \t\tslots_.push_back(new SlotMember<T, Args...>(object, func));\n>  \t}\n>  \n> -\tvoid connect(void(*func)(Args...))\n> +\tvoid connect(void (*func)(Args...))\n>  \t{\n>  \t\tslots_.push_back(new SlotStatic<Args...>(func));\n>  \t}\n> @@ -102,7 +102,7 @@ public:\n>  \t}\n>  \n>  \ttemplate<typename T>\n> -\tvoid disconnect(T *object, void(T::*func)(Args...))\n> +\tvoid disconnect(T *object, void (T::*func)(Args...))\n>  \t{\n>  \t\tfor (auto iter = slots_.begin(); iter != slots_.end(); ) {\n>  \t\t\tSlotBase<Args...> *slot = *iter;\n> @@ -120,7 +120,7 @@ public:\n>  \t\t}\n>  \t}\n>  \n> -\tvoid disconnect(void(*func)(Args...))\n> +\tvoid disconnect(void (*func)(Args...))\n>  \t{\n>  \t\tfor (auto iter = slots_.begin(); iter != slots_.end(); ) {\n>  \t\t\tSlotBase<Args...> *slot = *iter;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8C41D610B1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 13 Feb 2019 11:46:23 +0100 (CET)","by mail-lj1-x242.google.com with SMTP id z20so560435ljj.10\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 13 Feb 2019 02:46:23 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tk131sm1423935lfk.12.2019.02.13.02.46.22\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 13 Feb 2019 02:46:22 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=AaTRO2LcDskfgLFgla9XVNfbhGkX40RDh3JMp5bQSrs=;\n\tb=TuAE2V7zcTgHcXgmcJU/N1k7zA7BU6N+vPED2SZ/JYkcZw3ECJo6oh+AWHR6n7dQ+5\n\tT72euxcu5pvudFchCAxCcIrShqBtQI7wr06I40pp6RMpUvsdkaJu/ImeYjIwzlmLO7aZ\n\tPtakPnu5s886VO0Cz3ynzRG5lN6ynNQITNaiWujMqwUZ09a2nxy9nd1NTlCm6eAenrqT\n\tZrv3tww30C2cZljWBzwVfKoS60Zr8EOj4jWBM47V0JmegjpEcm68d7e6B/lUQ6EsYN+y\n\tLrF0kMTEcU3aOA09jVrrx8KuHPQAsTwDlcKfQRRtXEqJY++9RXH5kEfRo0/Qb9LxcZaO\n\trGlA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=AaTRO2LcDskfgLFgla9XVNfbhGkX40RDh3JMp5bQSrs=;\n\tb=l6PT5arT7cDdFQpkM0J9MASeOTruNotvW9X5j04boe08qpU1mOS5uX9prDXdPl3rXG\n\tM+HOuTiGrpFtTxi0sooo7jQHprii0eMyjqwAcH8UYQVh9HlQ4cFjSRVSa4MR0QL6UGo8\n\t75zPRAcmy1kjbWVqFbSELafSrdwg1eU5ttI6ekSFIglvh04F+l0PeVe0niR+A8LSxSu5\n\txNJeajnmKhQjcYXftRllPbsCTagCBSojeMwLP6fPLJM+lrczJo/MBqh+uNl2W36QiIW8\n\tv3r004J8T+IPHPq5BD6d5fZqT6mQMF7gLB6JonmAJiw6hQi7Gj1FjcMXB6PfNfJ2xgWB\n\ta2KQ==","X-Gm-Message-State":"AHQUAuZmAvrV3XniVAE9m03o2OemFeLASNHSfNIMZkO/aZgkJiyRYB3z\n\td/d06HUWw2/IM41yxnAmhF2q3xuRpNU=","X-Google-Smtp-Source":"AHgI3IbgXAlc7vtRnY5ql4u4slRm/MVJMg776yN/aRlsjcG+WnZCKhWUAdZGVfviTC7GZUaWKSW9/Q==","X-Received":"by 2002:a2e:7403:: with SMTP id\n\tp3-v6mr1700812ljc.88.1550054782820; \n\tWed, 13 Feb 2019 02:46:22 -0800 (PST)","Date":"Wed, 13 Feb 2019 11:46:21 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190213104621.GO31044@bigcity.dyn.berto.se>","References":"<20190212223702.9582-1-laurent.pinchart@ideasonboard.com>\n\t<20190212223702.9582-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190212223702.9582-2-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: signal: Fix coding\n\tstyle issues","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Wed, 13 Feb 2019 10:46:23 -0000"}}]