{"id":562,"url":"https://patchwork.libcamera.org/api/patches/562/?format=json","web_url":"https://patchwork.libcamera.org/patch/562/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190212223702.9582-2-laurent.pinchart@ideasonboard.com>","date":"2019-02-12T22:37:01","name":"[libcamera-devel,2/3] libcamera: signal: Fix coding style issues","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"26cb88f5cceaa3579410c564bd0cd4b0aaa57838","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/562/mbox/","series":[{"id":178,"url":"https://patchwork.libcamera.org/api/series/178/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=178","date":"2019-02-12T22:37:00","name":"[libcamera-devel,1/3] libcamera: pipeline_handler: Disconnect MediaDevice::disconnected signal","version":1,"mbox":"https://patchwork.libcamera.org/series/178/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/562/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/562/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AC5FD60B21\n\tfor ;\n\tTue, 12 Feb 2019 23:37:09 +0100 (CET)","from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3B85D2CF\n\tfor ;\n\tTue, 12 Feb 2019 23:37:09 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1550011029;\n\tbh=y20Of7z8P4SNb2vd8O1slHz15AWNFkxOLw4j0PDHJUQ=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=ErbFiisg9k8Vjlst9GnYU+O/MyAZEACsqYVhBJammsCS3rSvyLxDrCnW7VlCAWyF/\n\tJ1OCMyWxuJkK+ixqQvcRU8aWUNzwK9tL76a/zntKWQOPbyMiTM6SDuHS7jT6mwPs3M\n\tmuCIJX6FHKGODCkOXEjqZ3cqh8hIxZDJAT41h43s=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 13 Feb 2019 00:37:01 +0200","Message-Id":"<20190212223702.9582-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.19.2","In-Reply-To":"<20190212223702.9582-1-laurent.pinchart@ideasonboard.com>","References":"<20190212223702.9582-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/3] libcamera: signal: Fix coding style\n\tissues","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 12 Feb 2019 22:37:09 -0000"},"content":"Fix issues reported by checkstyle.py in preparation for further changes.\n\nSigned-off-by: Laurent Pinchart \n---\nChanges since v1:\n\n- Don't add a space after the template keyword\n---\n include/libcamera/signal.h | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)","diff":"diff --git a/include/libcamera/signal.h b/include/libcamera/signal.h\nindex c375b0a878af..85dc481d6957 100644\n--- a/include/libcamera/signal.h\n+++ b/include/libcamera/signal.h\n@@ -34,28 +34,28 @@ template\n class SlotMember : public SlotBase\n {\n public:\n-\tSlotMember(T *obj, void(T::*func)(Args...))\n+\tSlotMember(T *obj, void (T::*func)(Args...))\n \t\t: SlotBase(obj), func_(func) { }\n \n \tvoid invoke(Args... args) { (static_cast(this->obj_)->*func_)(args...); }\n \n private:\n \tfriend class Signal;\n-\tvoid(T::*func_)(Args...);\n+\tvoid (T::*func_)(Args...);\n };\n \n template\n class SlotStatic : public SlotBase\n {\n public:\n-\tSlotStatic(void(*func)(Args...))\n+\tSlotStatic(void (*func)(Args...))\n \t\t: SlotBase(nullptr), func_(func) { }\n \n \tvoid invoke(Args... args) { (*func_)(args...); }\n \n private:\n \tfriend class Signal;\n-\tvoid(*func_)(Args...);\n+\tvoid (*func_)(Args...);\n };\n \n template\n@@ -70,12 +70,12 @@ public:\n \t}\n \n \ttemplate\n-\tvoid connect(T *object, void(T::*func)(Args...))\n+\tvoid connect(T *object, void (T::*func)(Args...))\n \t{\n \t\tslots_.push_back(new SlotMember(object, func));\n \t}\n \n-\tvoid connect(void(*func)(Args...))\n+\tvoid connect(void (*func)(Args...))\n \t{\n \t\tslots_.push_back(new SlotStatic(func));\n \t}\n@@ -102,7 +102,7 @@ public:\n \t}\n \n \ttemplate\n-\tvoid disconnect(T *object, void(T::*func)(Args...))\n+\tvoid disconnect(T *object, void (T::*func)(Args...))\n \t{\n \t\tfor (auto iter = slots_.begin(); iter != slots_.end(); ) {\n \t\t\tSlotBase *slot = *iter;\n@@ -120,7 +120,7 @@ public:\n \t\t}\n \t}\n \n-\tvoid disconnect(void(*func)(Args...))\n+\tvoid disconnect(void (*func)(Args...))\n \t{\n \t\tfor (auto iter = slots_.begin(); iter != slots_.end(); ) {\n \t\t\tSlotBase *slot = *iter;\n","prefixes":["libcamera-devel","2/3"]}