[{"id":798,"web_url":"https://patchwork.libcamera.org/comment/798/","msgid":"<20190213104545.GN31044@bigcity.dyn.berto.se>","date":"2019-02-13T10:45:45","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: pipeline_handler:\n\tDisconnect MediaDevice::disconnected signal","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2019-02-13 00:37:00 +0200, Laurent Pinchart wrote:\n> The pipeline handler connects the disconnected signal of MediaDevice\n> instances registered for hotplug handling to a member slot. Disconnect\n> the signal when the slot is called, as the pipeline handler will be\n> deleted.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline_handler.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index 4e111d6d2f55..616838fed702 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -241,6 +241,8 @@ void PipelineHandler::hotplugMediaDevice(MediaDevice *media)\n> */\n> void PipelineHandler::mediaDeviceDisconnected(MediaDevice *media)\n> {\n> +\tmedia->disconnected.disconnect(this);\n> +\n> \tif (cameras_.empty())\n> \t\treturn;\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x144.google.com (mail-lf1-x144.google.com\n\t[IPv6:2a00:1450:4864:20::144])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A5674610B1\n\tfor ;\n\tWed, 13 Feb 2019 11:45:47 +0100 (CET)","by mail-lf1-x144.google.com with SMTP id u21so1419384lfu.1\n\tfor ;\n\tWed, 13 Feb 2019 02:45:47 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tz2-v6sm3360964ljk.50.2019.02.13.02.45.45\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 13 Feb 2019 02:45:45 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=0bI4Ubcq3EHZmUy70QiHiqj9BMAXZXwu0iqrjOOHYLw=;\n\tb=xK27OQhdsfhDVl7wv/VDDSLJ4yPMqTb8RhNimlJNfnHMpiUkWtudY4gDUuSJMSSZ4X\n\tBZgDRpv47mBKTZlMn26z9WDETJUNC9xVn9y+7qhV9DKMJnIou832ThAFL/g65e8Z/xSl\n\tTBl6AxsLsrAYbiT9Rqf9tP8HnYnaNyQI8DdJ47CNCu4oDcTgdfvglvw47inn5fnY1X7o\n\tgjiQWTR/wBHoD+6QhfKak8TRAGTU3+DlsbBiBkGxtkzfGK3xh/FX4gdzMycBPyLpDX33\n\tbnm35N5qGJzccWdMy65YIlpiLV43DLgrpXW0efWrJfuUW5TS7XKtEz2O1jV8iin39F+k\n\tV+nA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=0bI4Ubcq3EHZmUy70QiHiqj9BMAXZXwu0iqrjOOHYLw=;\n\tb=TdfQn8ghZUjXRm6enrU4a9Ewj9cw4x6vTNfr9eh73j1ddYz0+JhSYWpCFKgPi2YPIP\n\tQFYcYmUlIbwNgV2y7bPbD2FLyfjx5xBzSak5rRj5Q8/kbzcYsXjbUp7JP8E0aiMSjao0\n\tZH/YY2FaRm5S1W2Fb2gHjffkDQwzf5Bf3J0/HAvEr8Fg76df3XL4gZVEcVp+jpZWOzmk\n\tf19+sq21bYYsKhYVb3pdZp8OXDhW2x1Kl6aj2a6dqPzKOON957v8XBrx35ZTuuCtyOzF\n\t4O8kubqKQinN64pVB9zOKK3C/YL2a0w2s9XXoPyBA6r2NIJt9dh3na6H+tJOxBLvkohm\n\tNizg==","X-Gm-Message-State":"AHQUAuacnFsJL0bIRTt7qHa53p9k8O2CNxgPpZBL/31w6Z9wM/sQmqDL\n\tsENXBV686wgWQULHbjn38GjVDgznnIc=","X-Google-Smtp-Source":"AHgI3IZdNhjUDm8rLwCqYMuY1BTWfJFXA52rcO+c9sKfvS+GIWEbREBoEa2m+zkQOf+GZAreGDRPvQ==","X-Received":"by 2002:a19:2584:: with SMTP id\n\tl126mr5379929lfl.69.1550054746841; \n\tWed, 13 Feb 2019 02:45:46 -0800 (PST)","Date":"Wed, 13 Feb 2019 11:45:45 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190213104545.GN31044@bigcity.dyn.berto.se>","References":"<20190212223702.9582-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190212223702.9582-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: pipeline_handler:\n\tDisconnect MediaDevice::disconnected signal","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 13 Feb 2019 10:45:47 -0000"}}]