[{"id":797,"web_url":"https://patchwork.libcamera.org/comment/797/","msgid":"<20190213103022.GM31044@bigcity.dyn.berto.se>","date":"2019-02-13T10:30:22","subject":"Re: [libcamera-devel] [PATCH] cam: options: Fix coding style issue\n\trelated to templates","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2019-02-13 00:29:12 +0200, Laurent Pinchart wrote:\n> Our coding style doesn't add a space after the template keyword. Fix the\n> source code accordingly.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/cam/options.cpp | 10 +++++-----\n> src/cam/options.h | 2 +-\n> 2 files changed, 6 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/cam/options.cpp b/src/cam/options.cpp\n> index eb59376fa459..655aa36bb9c9 100644\n> --- a/src/cam/options.cpp\n> +++ b/src/cam/options.cpp\n> @@ -39,25 +39,25 @@ const char *Option::typeName() const\n> * OptionBase\n> */\n> \n> -template \n> +template\n> bool OptionsBase::valid() const\n> {\n> \treturn !values_.empty();\n> }\n> \n> -template \n> +template\n> bool OptionsBase::isSet(const T &opt) const\n> {\n> \treturn values_.find(opt) != values_.end();\n> }\n> \n> -template \n> +template\n> const OptionValue &OptionsBase::operator[](const T &opt) const\n> {\n> \treturn values_.find(opt)->second;\n> }\n> \n> -template \n> +template\n> bool OptionsBase::parseValue(const T &opt, const Option &option,\n> \t\t\t\tconst char *optarg)\n> {\n> @@ -100,7 +100,7 @@ bool OptionsBase::parseValue(const T &opt, const Option &option,\n> \treturn true;\n> }\n> \n> -template \n> +template\n> void OptionsBase::clear()\n> {\n> \tvalues_.clear();\n> diff --git a/src/cam/options.h b/src/cam/options.h\n> index 2d3aa50b5051..745f4a4a3a43 100644\n> --- a/src/cam/options.h\n> +++ b/src/cam/options.h\n> @@ -41,7 +41,7 @@ struct Option {\n> \tconst char *typeName() const;\n> };\n> \n> -template \n> +template\n> class OptionsBase\n> {\n> public:\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A4DAA610B1\n\tfor ;\n\tWed, 13 Feb 2019 11:30:24 +0100 (CET)","by mail-lj1-x243.google.com with SMTP id q128so1505915ljb.11\n\tfor ;\n\tWed, 13 Feb 2019 02:30:24 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tk3-v6sm3365669lja.8.2019.02.13.02.30.23\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 13 Feb 2019 02:30:23 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=N+yvq25ZdoPDOa4XI3VHTlYZKiz/tArH/OoUoupfiIU=;\n\tb=ZMj39rD1Drm74EiKpBGfhagSAoEIvmB+/EWuXIf1RbpxuWGcHYT9JxePRC4LINGsZc\n\tHpf2Bb1syKNpyryJy/eEfD9SeSL4kH9MFoFKiILXWbbil1echwQ+O5ODi2UPgNqarLgn\n\tm3FoEj9UPnBhFVRdUOH6I3mWRjwFABVnsbjr3y9zeyx7sduaNUIav3GkKfpHemdKRj+y\n\twXd01NZNRwA8r1IHsokWKlTCzlfWRcYVOOBhmm8ExrG4FZeH1k6Myo1o5oRles9ZstgE\n\t7Iyt17YsxIfN3e0CSR3aPZv4Vh2/PDF0TWrpTLIdkDpq3VbdmT6bGeDgwjel2dOEtegL\n\tXCGw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=N+yvq25ZdoPDOa4XI3VHTlYZKiz/tArH/OoUoupfiIU=;\n\tb=UWzsUq/epKrsqf6z1ABE+YXVpjFh8TBcbr8I7lwKcf3GMa6yDhp44LLxMdfmqyo6aW\n\t7Q3Kfy9sKYLB1kgp4OyzFmkhCJXvXLKl95NBDzOqYjWW+L77y3knoP2UuhOUfkc3vNyB\n\t4pAsIocJ4cXk6StwXPFUIfiXJevGNs+73IV5+oXVKkQC/XPmE+e0OhrE33qSWsH12yU0\n\tzmtEsHzdNZGcVl3xK1uWTO/lIScLmLDiGEWzmeDmUSJdeB9CylwgKPsD8H40EKFzyZSo\n\t/IBpByju2GBR6t5StxCURDpiGbCkHRnJavKbsTVHbPQX4kEJuRyhWPiRaWFFuXrMXa3c\n\t3roA==","X-Gm-Message-State":"AHQUAuYnRWcKXCWQt+GVu2qA5ixvh7ja/LMWwAVX/72L8NI/vd064Qw3\n\tcb4yq/wLUP4tn0FlMc5v/H9p8Q==","X-Google-Smtp-Source":"AHgI3IbSHmSvrsOvXOfbXCt2I1nmt3urGv0/cmzPfpYwGlMIwuVCMaI0FqaJQ4o6HUQ26INJ+7RyDg==","X-Received":"by 2002:a2e:85c9:: with SMTP id\n\th9-v6mr5158707ljj.101.1550053823939; \n\tWed, 13 Feb 2019 02:30:23 -0800 (PST)","Date":"Wed, 13 Feb 2019 11:30:22 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190213103022.GM31044@bigcity.dyn.berto.se>","References":"<20190212222912.9089-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190212222912.9089-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] cam: options: Fix coding style issue\n\trelated to templates","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 13 Feb 2019 10:30:24 -0000"}}]