[{"id":790,"web_url":"https://patchwork.libcamera.org/comment/790/","msgid":"<20190212223851.GW6279@pendragon.ideasonboard.com>","date":"2019-02-12T22:38:51","subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: device_enumerator:\n\tBreak line longer than 80 columns","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Feb 12, 2019 at 11:20:19PM +0100, Jacopo Mondi wrote:\n> Since there is no valid reason to exceed 80 columns for this lane, break\n> it.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/device_enumerator.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\n> index 703b03dd418a..03923b3bb457 100644\n> --- a/src/libcamera/device_enumerator.cpp\n> +++ b/src/libcamera/device_enumerator.cpp\n> @@ -234,7 +234,8 @@ int DeviceEnumerator::addDevice(const std::string &deviceNode)\n> \t\tif (entity->deviceMajor() == 0 && entity->deviceMinor() == 0)\n> \t\t\tcontinue;\n> \n> -\t\tstd::string deviceNode = lookupDeviceNode(entity->deviceMajor(), entity->deviceMinor());\n> +\t\tstd::string deviceNode = lookupDeviceNode(entity->deviceMajor(),\n> +\t\t\t\t\t\t\t entity->deviceMinor());\n> \t\tif (deviceNode.empty())\n> \t\t\treturn -EINVAL;\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB80B60B21\n\tfor ;\n\tTue, 12 Feb 2019 23:38:54 +0100 (CET)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5D84585;\n\tTue, 12 Feb 2019 23:38:54 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1550011134;\n\tbh=g8EnJv1W7sf3JJTyz7o65J1Sr1ue5LcZcLUH2OdWJFI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vpZmNYlj4TKT9AjvkSMMkSop972LB5SbBud89FRY6eSSeEjJPChAr6C3491yVbGsH\n\tqyTYyaYYAjAuwKE0a5KoOeelhAG8Sdv87Nmb+iuQzhDkaab4LM2tNAJJmXydX195aO\n\tRLyGzjfBou/X2ISrmxktLAJpb7nhHfBhZMVufwmc=","Date":"Wed, 13 Feb 2019 00:38:51 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190212223851.GW6279@pendragon.ideasonboard.com>","References":"<20190212222021.28517-1-jacopo@jmondi.org>\n\t<20190212222021.28517-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190212222021.28517-3-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: device_enumerator:\n\tBreak line longer than 80 columns","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 12 Feb 2019 22:38:55 -0000"}},{"id":802,"web_url":"https://patchwork.libcamera.org/comment/802/","msgid":"<20190213105954.GR31044@bigcity.dyn.berto.se>","date":"2019-02-13T10:59:54","subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: device_enumerator:\n\tBreak line longer than 80 columns","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your patch,\n\nOn 2019-02-12 23:20:19 +0100, Jacopo Mondi wrote:\n> Since there is no valid reason to exceed 80 columns for this lane, break\n> it.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/device_enumerator.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\n> index 703b03dd418a..03923b3bb457 100644\n> --- a/src/libcamera/device_enumerator.cpp\n> +++ b/src/libcamera/device_enumerator.cpp\n> @@ -234,7 +234,8 @@ int DeviceEnumerator::addDevice(const std::string &deviceNode)\n> \t\tif (entity->deviceMajor() == 0 && entity->deviceMinor() == 0)\n> \t\t\tcontinue;\n> \n> -\t\tstd::string deviceNode = lookupDeviceNode(entity->deviceMajor(), entity->deviceMinor());\n> +\t\tstd::string deviceNode = lookupDeviceNode(entity->deviceMajor(),\n> +\t\t\t\t\t\t\t entity->deviceMinor());\n> \t\tif (deviceNode.empty())\n> \t\t\treturn -EINVAL;\n> \n> -- \n> 2.20.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B27BB610B1\n\tfor ;\n\tWed, 13 Feb 2019 11:59:55 +0100 (CET)","by mail-lf1-x142.google.com with SMTP id f5so1395030lfc.13\n\tfor ;\n\tWed, 13 Feb 2019 02:59:55 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tx25-v6sm3367259ljd.61.2019.02.13.02.59.54\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 13 Feb 2019 02:59:54 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=d1jh1mbNFWBNanhMc2qLQzISLfNhUNYOAYkacn94C2s=;\n\tb=vSYJjYWyuYPP97AImZ/YcxN9ENYUHoC5NwCTBUpIh5DkSu/GyfWwk5yaGOkPpvqXKY\n\tSe0bX3oQBxyisGLGzg2D/41BkALS45/d0zM4WrLsToCYyTQw8urztSxz8/JwssObFHpP\n\tXNK+wuZn/BFEjNcho2eu0TJyk7X/3RirUIIDSDOP26FRu/CIALcEAv5sZg5kgestttg+\n\t/NlS1I1dIT6QY/m3R76yogUMSihI6L1zhq0EHAQfRm6Lu7SZFhOgYUXZ7VOTwgBhfzcq\n\tgkJTeHvrR53hJHOSEVGxqAfZzyGgFYmsmPK5XI9rzfZMiMe2Vc8M5BaDEekoIUNRJg1e\n\tEh7g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=d1jh1mbNFWBNanhMc2qLQzISLfNhUNYOAYkacn94C2s=;\n\tb=Cu3CTrCdS+FUDakFaxFRSWtfZT/8/NhKaJIyE2dw96d4YydW8dR6u/3cP0cumtOk4q\n\tCKgNEPOjGx3bi7v/26a/Beq4rrRjQgpnUnLnw6M6IWZTS7ZJqQWMbH19eB+qUJaM8Vvy\n\tgrLxHVMFu8EmJ38JB5slF6O6ekO1o7YRZ/z76DrBNtaEJXIkAueXak94A5TtqSQo2xZG\n\tT9azDKoyIsaLipdgw/n1IrrsFRXFWBextCdQPX0P3YwmT3uWRg62fO4iADwf1WRGCG2r\n\t1F7cQe6TPKbSLufOJc0u90P0btD5rh4mNPNeP9VIJP0YJCQOvRd74lnGMqfLLSxhQnhT\n\t7Zew==","X-Gm-Message-State":"AHQUAuZvILNMqu+z8vmOAzpVXfsG/RGHIlF6+lW/OfCexyMGstw7DWca\n\tBJ5A89ZLtbiZM0IEvgpu8xLZDg==","X-Google-Smtp-Source":"AHgI3Iby/NRKbIo5hiXwB5Kzpx8ktKOYY8oScla++J0+r4189hnsfkzbCywhHpP2O6Wbr9nj49Up3g==","X-Received":"by 2002:ac2:43c3:: with SMTP id u3mr2300565lfl.114.1550055595036;\n\tWed, 13 Feb 2019 02:59:55 -0800 (PST)","Date":"Wed, 13 Feb 2019 11:59:54 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190213105954.GR31044@bigcity.dyn.berto.se>","References":"<20190212222021.28517-1-jacopo@jmondi.org>\n\t<20190212222021.28517-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190212222021.28517-3-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: device_enumerator:\n\tBreak line longer than 80 columns","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 13 Feb 2019 10:59:56 -0000"}}]