{"id":555,"url":"https://patchwork.libcamera.org/api/patches/555/?format=json","web_url":"https://patchwork.libcamera.org/patch/555/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190212222021.28517-3-jacopo@jmondi.org>","date":"2019-02-12T22:20:19","name":"[libcamera-devel,2/4] libcamera: device_enumerator: Break line longer than 80 columns","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"74aaa03203b1d7aa9e226a92e5dbfcfebc6726b4","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/555/mbox/","series":[{"id":175,"url":"https://patchwork.libcamera.org/api/series/175/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=175","date":"2019-02-12T22:20:17","name":"libcamera: mixed updated","version":1,"mbox":"https://patchwork.libcamera.org/series/175/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/555/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/555/checks/","tags":{},"headers":{"Return-Path":"<jacopo@jmondi.org>","Received":["from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0F0E360B21\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 12 Feb 2019 23:20:09 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 4BA1D100002;\n\tTue, 12 Feb 2019 22:20:08 +0000 (UTC)"],"From":"Jacopo Mondi <jacopo@jmondi.org>","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 12 Feb 2019 23:20:19 +0100","Message-Id":"<20190212222021.28517-3-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20190212222021.28517-1-jacopo@jmondi.org>","References":"<20190212222021.28517-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/4] libcamera: device_enumerator: Break\n\tline longer than 80 columns","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 12 Feb 2019 22:20:09 -0000"},"content":"Since there is no valid reason to exceed 80 columns for this lane, break\nit.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/device_enumerator.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\nindex 703b03dd418a..03923b3bb457 100644\n--- a/src/libcamera/device_enumerator.cpp\n+++ b/src/libcamera/device_enumerator.cpp\n@@ -234,7 +234,8 @@ int DeviceEnumerator::addDevice(const std::string &deviceNode)\n \t\tif (entity->deviceMajor() == 0 && entity->deviceMinor() == 0)\n \t\t\tcontinue;\n \n-\t\tstd::string deviceNode = lookupDeviceNode(entity->deviceMajor(), entity->deviceMinor());\n+\t\tstd::string deviceNode = lookupDeviceNode(entity->deviceMajor(),\n+\t\t\t\t\t\t\t  entity->deviceMinor());\n \t\tif (deviceNode.empty())\n \t\t\treturn -EINVAL;\n \n","prefixes":["libcamera-devel","2/4"]}