[{"id":789,"web_url":"https://patchwork.libcamera.org/comment/789/","msgid":"<20190212223817.GV6279@pendragon.ideasonboard.com>","date":"2019-02-12T22:38:17","subject":"Re: [libcamera-devel] [PATCH 1/4] libcamera: v4l2_subdevice:\n\tForward-declare MediaEntity","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Feb 12, 2019 at 11:20:18PM +0100, Jacopo Mondi wrote:\n> The V4L2Subdevice class uses MediaEntity instances, and the\n> corresponding header is not included.\n> \n> Fix this by forward declaring the MediaEntity class.\n> \n> Fixes: 468176fa07d9 (\"libcamera: Add V4L2Subdevice\")\n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/include/v4l2_subdevice.h | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/include/v4l2_subdevice.h b/src/libcamera/include/v4l2_subdevice.h\n> index 8fd666078985..ffa92100ffbc 100644\n> --- a/src/libcamera/include/v4l2_subdevice.h\n> +++ b/src/libcamera/include/v4l2_subdevice.h\n> @@ -12,6 +12,7 @@\n> namespace libcamera {\n> \n> struct Rectangle;\n> +class MediaEntity;\n\nShould we sort this alphabetically ? Apart from that,\n\nReviewed-by: Laurent Pinchart \n\n> \n> struct V4L2SubdeviceFormat {\n> \tuint32_t mbus_code;","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F0C4760B21\n\tfor ;\n\tTue, 12 Feb 2019 23:38:20 +0100 (CET)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8778985;\n\tTue, 12 Feb 2019 23:38:20 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1550011100;\n\tbh=EZo7Ye9/H3d9FNqrjBCS7zJ2zvJu7wzPlvKs1zgbCxk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Gz80gspG5sqMg2s0gBZoCGAQj+3zyWClF1N24lN2pASgj8R3PoX6+26IK+TMRxH/Y\n\tvH6PBeG4J+UK4P/9PEEdLyywPKmlyEJ6hw4/DjY56Wm5LdPB8cwEPuKLyKE7D5tSLz\n\tCYe0CGCzPfVKhUiseN+ldfUtEcGpnNO8Yb5BBSfQ=","Date":"Wed, 13 Feb 2019 00:38:17 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190212223817.GV6279@pendragon.ideasonboard.com>","References":"<20190212222021.28517-1-jacopo@jmondi.org>\n\t<20190212222021.28517-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190212222021.28517-2-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 1/4] libcamera: v4l2_subdevice:\n\tForward-declare MediaEntity","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 12 Feb 2019 22:38:21 -0000"}},{"id":801,"web_url":"https://patchwork.libcamera.org/comment/801/","msgid":"<20190213105926.GQ31044@bigcity.dyn.berto.se>","date":"2019-02-13T10:59:26","subject":"Re: [libcamera-devel] [PATCH 1/4] libcamera: v4l2_subdevice:\n\tForward-declare MediaEntity","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi,\n\nOn 2019-02-13 00:38:17 +0200, Laurent Pinchart wrote:\n> Hi Jacopo,\n> \n> Thank you for the patch.\n> \n> On Tue, Feb 12, 2019 at 11:20:18PM +0100, Jacopo Mondi wrote:\n> > The V4L2Subdevice class uses MediaEntity instances, and the\n> > corresponding header is not included.\n> > \n> > Fix this by forward declaring the MediaEntity class.\n> > \n> > Fixes: 468176fa07d9 (\"libcamera: Add V4L2Subdevice\")\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > src/libcamera/include/v4l2_subdevice.h | 1 +\n> > 1 file changed, 1 insertion(+)\n> > \n> > diff --git a/src/libcamera/include/v4l2_subdevice.h b/src/libcamera/include/v4l2_subdevice.h\n> > index 8fd666078985..ffa92100ffbc 100644\n> > --- a/src/libcamera/include/v4l2_subdevice.h\n> > +++ b/src/libcamera/include/v4l2_subdevice.h\n> > @@ -12,6 +12,7 @@\n> > namespace libcamera {\n> > \n> > struct Rectangle;\n> > +class MediaEntity;\n> \n> Should we sort this alphabetically ? Apart from that,\n\nI think we should, with that fixed\n\nReviewed-by: Niklas Söderlund \n\n> \n> Reviewed-by: Laurent Pinchart \n> \n> > \n> > struct V4L2SubdeviceFormat {\n> > \tuint32_t mbus_code;\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 044EC610B1\n\tfor ;\n\tWed, 13 Feb 2019 11:59:28 +0100 (CET)","by mail-lf1-x142.google.com with SMTP id e27so1420810lfj.8\n\tfor ;\n\tWed, 13 Feb 2019 02:59:27 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\td70sm3680298lfe.14.2019.02.13.02.59.26\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 13 Feb 2019 02:59:26 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=nE9Z2KWVaK9aWrsgfb06MAnwyaEx6J2yTHnNrWJ0jSA=;\n\tb=j1pNSOChL2vGBHi5dYBQcemWfcuxzhCKQQ8NmMDjxJ005bllMvCeHI9Gr/WOZA4ofP\n\tZuUYCmRoAmcu+MX/jjngoCfVI1hWniKThxif+ebOTxTX49Gs+mlFAncnNSdFirEDNjUp\n\tBwRK8+PiT4b9qIOjUTIhMWg09g5IE+HH+Xdg37AIgP9rakpQ8k3SV+D1RvKY2fLXte95\n\tFgsaTOAD4RL+fvg7iJ8GkQJ8roSXSB4RJXM3tbH89PyTo1hvUJiePaxCHr9mkRtqaLTZ\n\tNJEu9C5P1UwpMk7LNKIjlpZb4KkmaWvIanWxTJURz3+ze7Wkn0TteDKiTs13fjDSgvfH\n\tGJfA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=nE9Z2KWVaK9aWrsgfb06MAnwyaEx6J2yTHnNrWJ0jSA=;\n\tb=al4ScZZrCvwSyY1H8vnSuBIoyR/gguV6/0jAwx2AA1t1C04b86irbNgoRnQdux9Bpn\n\tYU5CaW70WNcr5Y4moFB253RyTcPIPVXCuVIh0Sr+uhWIKPSw+0RTlUE18Lonrdjhe9te\n\tEiITWs08+0mWk/nZDbE163tRikiIQyjNcwCv7btPOdM5SpwnTZqULC7lat2GuUywjGTe\n\tlTKLl3LJz9uM51XghlFzkyEU1Vm68gHe6OWJnByggvMq20P4Aa/SW9zh5lKJSdkdt4ok\n\tky48/O6lj/w/IeSRfXPWGaIZHJE7bxHRaqx8hEHp4nbwBfjmMWaZrdajTkeFCV0buGoB\n\tneEw==","X-Gm-Message-State":"AHQUAuZerdtIKSS2VHhei356F/208gcFC8SYWPyXVxshCTAHosFmLa4N\n\tyV7gmcpOHeHX5zgb1z/c2IAJGnQRcGk=","X-Google-Smtp-Source":"AHgI3IYntgCDGZOnFHelQ1Xny4wUtZFlCO5NZBjdr7z/4lzlAabHVmKr8EDJQiy5WOY7Qp98u1XPzw==","X-Received":"by 2002:a19:a345:: with SMTP id m66mr5635616lfe.84.1550055567215;\n\tWed, 13 Feb 2019 02:59:27 -0800 (PST)","Date":"Wed, 13 Feb 2019 11:59:26 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","Message-ID":"<20190213105926.GQ31044@bigcity.dyn.berto.se>","References":"<20190212222021.28517-1-jacopo@jmondi.org>\n\t<20190212222021.28517-2-jacopo@jmondi.org>\n\t<20190212223817.GV6279@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190212223817.GV6279@pendragon.ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 1/4] libcamera: v4l2_subdevice:\n\tForward-declare MediaEntity","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 13 Feb 2019 10:59:28 -0000"}},{"id":806,"web_url":"https://patchwork.libcamera.org/comment/806/","msgid":"<20190213113018.siktcfxdhfirzgwd@uno.localdomain>","date":"2019-02-13T11:30:18","subject":"Re: [libcamera-devel] [PATCH 1/4] libcamera: v4l2_subdevice:\n\tForward-declare MediaEntity","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi,\n\nOn Wed, Feb 13, 2019 at 11:59:26AM +0100, Niklas Söderlund wrote:\n> Hi,\n>\n> On 2019-02-13 00:38:17 +0200, Laurent Pinchart wrote:\n> > Hi Jacopo,\n> >\n> > Thank you for the patch.\n> >\n> > On Tue, Feb 12, 2019 at 11:20:18PM +0100, Jacopo Mondi wrote:\n> > > The V4L2Subdevice class uses MediaEntity instances, and the\n> > > corresponding header is not included.\n> > >\n> > > Fix this by forward declaring the MediaEntity class.\n> > >\n> > > Fixes: 468176fa07d9 (\"libcamera: Add V4L2Subdevice\")\n> > > Signed-off-by: Jacopo Mondi \n> > > ---\n> > > src/libcamera/include/v4l2_subdevice.h | 1 +\n> > > 1 file changed, 1 insertion(+)\n> > >\n> > > diff --git a/src/libcamera/include/v4l2_subdevice.h b/src/libcamera/include/v4l2_subdevice.h\n> > > index 8fd666078985..ffa92100ffbc 100644\n> > > --- a/src/libcamera/include/v4l2_subdevice.h\n> > > +++ b/src/libcamera/include/v4l2_subdevice.h\n> > > @@ -12,6 +12,7 @@\n> > > namespace libcamera {\n> > >\n> > > struct Rectangle;\n> > > +class MediaEntity;\n> >\n> > Should we sort this alphabetically ? Apart from that,\n>\n> I think we should, with that fixed\n>\n> Reviewed-by: Niklas Söderlund \n\nMy reasoning was \"struct\" before \"class\", but I'll change this.\n\nThanks\n j\n\n>\n> >\n> > Reviewed-by: Laurent Pinchart \n> >\n> > >\n> > > struct V4L2SubdeviceFormat {\n> > > \tuint32_t mbus_code;\n> >\n> > --\n> > Regards,\n> >\n> > Laurent Pinchart\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> --\n> Regards,\n> Niklas Söderlund","headers":{"Return-Path":"","Received":["from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BE13560DBB\n\tfor ;\n\tWed, 13 Feb 2019 12:29:59 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 4575140002;\n\tWed, 13 Feb 2019 11:29:59 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Wed, 13 Feb 2019 12:30:18 +0100","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Message-ID":"<20190213113018.siktcfxdhfirzgwd@uno.localdomain>","References":"<20190212222021.28517-1-jacopo@jmondi.org>\n\t<20190212222021.28517-2-jacopo@jmondi.org>\n\t<20190212223817.GV6279@pendragon.ideasonboard.com>\n\t<20190213105926.GQ31044@bigcity.dyn.berto.se>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"4dl4ecap4edyivcv\"","Content-Disposition":"inline","In-Reply-To":"<20190213105926.GQ31044@bigcity.dyn.berto.se>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 1/4] libcamera: v4l2_subdevice:\n\tForward-declare MediaEntity","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 13 Feb 2019 11:30:01 -0000"}}]