[{"id":775,"web_url":"https://patchwork.libcamera.org/comment/775/","msgid":"<20190210131438.GA31044@bigcity.dyn.berto.se>","date":"2019-02-10T13:14:38","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: log: Allow extending\n\tlog messages","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2019-02-08 16:45:39 +0200, Laurent Pinchart wrote:\n> Introduce a base Loggable class that can be inherited from by other\n> classes to support adding per-instance information to the log messages.\n> \n> Signed-off-by: Laurent Pinchart \n\nIt's more complex but I like the end result and its ease of use :-)\n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/include/log.h | 23 ++++++-\n> src/libcamera/log.cpp | 124 ++++++++++++++++++++++++++++++++++++\n> 2 files changed, 145 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/include/log.h b/src/libcamera/include/log.h\n> index ad8f8452c333..8ea5a1eb673a 100644\n> --- a/src/libcamera/include/log.h\n> +++ b/src/libcamera/include/log.h\n> @@ -54,6 +54,7 @@ public:\n> \tLogMessage(const char *fileName, unsigned int line,\n> \t\t const LogCategory &category, LogSeverity severity);\n> \tLogMessage(const LogMessage &) = delete;\n> +\tLogMessage(LogMessage &&);\n> \t~LogMessage();\n> \n> \tstd::ostream &stream() { return msgStream_; }\n> @@ -66,13 +67,31 @@ private:\n> \tLogSeverity severity_;\n> };\n> \n> +class Loggable\n> +{\n> +public:\n> +\tvirtual ~Loggable();\n> +\n> +protected:\n> +\tvirtual std::string logPrefix() const = 0;\n> +\n> +\tLogMessage _log(const char *file, unsigned int line,\n> +\t\t\tLogSeverity severity);\n> +\tLogMessage _log(const char *file, unsigned int line,\n> +\t\t\tconst LogCategory &category, LogSeverity severity);\n> +};\n> +\n> +LogMessage _log(const char *file, unsigned int line, LogSeverity severity);\n> +LogMessage _log(const char *file, unsigned int line,\n> +\t\tconst LogCategory &category, LogSeverity severity);\n> +\n> #ifndef __DOXYGEN__\n> #define _LOG_CATEGORY(name) logCategory##name\n> \n> #define _LOG1(severity) \\\n> -\tLogMessage(__FILE__, __LINE__, Log##severity).stream()\n> +\t_log(__FILE__, __LINE__, Log##severity).stream()\n> #define _LOG2(category, severity) \\\n> -\tLogMessage(__FILE__, __LINE__, _LOG_CATEGORY(category)(), Log##severity).stream()\n> +\t_log(__FILE__, __LINE__, _LOG_CATEGORY(category)(), Log##severity).stream()\n> \n> /*\n> * Expand the LOG() macro to _LOG1() or _LOG2() based on the number of\n> diff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp\n> index edeb5eabb264..26ebf410a7a9 100644\n> --- a/src/libcamera/log.cpp\n> +++ b/src/libcamera/log.cpp\n> @@ -405,6 +405,25 @@ LogMessage::LogMessage(const char *fileName, unsigned int line,\n> \tinit(fileName, line);\n> }\n> \n> +/**\n> + * \\brief Move-construct a log message\n> + * \\param[in] other The other message\n> + *\n> + * The move constructor is meant to support the _log() functions. Thanks to copy\n> + * elision it will likely never be called, but C++11 only permits copy elision,\n> + * it doesn't enforce it unlike C++17. To avoid potential link errors depending\n> + * on the compiler type and version, and optimization level, the move\n> + * constructor is defined even if it will likely never be called, and ensures\n> + * that the destructor of the \\a other message will not output anything to the\n> + * log by setting the severity to -1.\n> + */\n> +LogMessage::LogMessage(LogMessage &&other)\n> +\t: msgStream_(std::move(other.msgStream_)), category_(other.category_),\n> +\t severity_(other.severity_)\n> +{\n> +\tother.severity_ = static_cast(-1);\n> +}\n> +\n> void LogMessage::init(const char *fileName, unsigned int line)\n> {\n> \t/* Log the timestamp, severity and file information. */\n> @@ -424,6 +443,10 @@ void LogMessage::init(const char *fileName, unsigned int line)\n> \n> LogMessage::~LogMessage()\n> {\n> +\t/* Don't print anything if we have been moved to another LogMessage. */\n> +\tif (severity_ == -1)\n> +\t\treturn;\n> +\n> \tmsgStream_ << std::endl;\n> \n> \tif (severity_ >= category_.severity()) {\n> @@ -445,6 +468,107 @@ LogMessage::~LogMessage()\n> * \\return A reference to the log message stream\n> */\n> \n> +/**\n> + * \\class Loggable\n> + * \\brief Base class to support log message extensions\n> + *\n> + * The Loggable class allows classes to extend log messages without any change\n> + * to the way the LOG() macro is invoked. By inheriting from Loggable and\n> + * implementing the logPrefix() virtual method, a class can specify extra\n> + * information to be automatically added to messages logged from class member\n> + * methods.\n> + */\n> +\n> +Loggable::~Loggable()\n> +{\n> +}\n> +\n> +/**\n> + * \\fn Loggable::logPrefix()\n> + * \\brief Retrieve a string to be prefixed to the log message\n> + *\n> + * This method allows classes inheriting from the Loggable class to extend the\n> + * logger with an object-specific prefix output right before the log message\n> + * contents.\n> + *\n> + * \\return A string to be prefixed to the log message\n> + */\n> +\n> +/**\n> + * \\brief Create a temporary LogMessage object to log a message\n> + * \\param[in] fileName The file name where the message is logged from\n> + * \\param[in] line The line number where the message is logged from\n> + * \\param[in] severity The log message severity\n> + *\n> + * This method is used as a backeng by the LOG() macro to create a log message\n> + * for locations inheriting from the Loggable class.\n> + *\n> + * \\return A log message\n> + */\n> +LogMessage Loggable::_log(const char *fileName, unsigned int line,\n> +\t\t\t LogSeverity severity)\n> +{\n> +\tLogMessage msg(fileName, line, severity);\n> +\n> +\tmsg.stream() << logPrefix() << \": \";\n> +\treturn msg;\n> +}\n> +\n> +/**\n> + * \\brief Create a temporary LogMessage object to log a message\n> + * \\param[in] fileName The file name where the message is logged from\n> + * \\param[in] line The line number where the message is logged from\n> + * \\param[in] category The log message category\n> + * \\param[in] severity The log message severity\n> + *\n> + * This method is used as a backeng by the LOG() macro to create a log message\n> + * for locations inheriting from the Loggable class.\n> + *\n> + * \\return A log message\n> + */\n> +LogMessage Loggable::_log(const char *fileName, unsigned int line,\n> +\t\t\t const LogCategory &category, LogSeverity severity)\n> +{\n> +\tLogMessage msg(fileName, line, category, severity);\n> +\n> +\tmsg.stream() << logPrefix() << \": \";\n> +\treturn msg;\n> +}\n> +\n> +/**\n> + * \\brief Create a temporary LogMessage object to log a message\n> + * \\param[in] fileName The file name where the message is logged from\n> + * \\param[in] line The line number where the message is logged from\n> + * \\param[in] severity The log message severity\n> + *\n> + * This function is used as a backeng by the LOG() macro to create a log\n> + * message for locations not inheriting from the Loggable class.\n> + *\n> + * \\return A log message\n> + */\n> +LogMessage _log(const char *fileName, unsigned int line, LogSeverity severity)\n> +{\n> +\treturn LogMessage(fileName, line, severity);\n> +}\n> +\n> +/**\n> + * \\brief Create a temporary LogMessage object to log a message\n> + * \\param[in] fileName The file name where the message is logged from\n> + * \\param[in] line The line number where the message is logged from\n> + * \\param[in] category The log message category\n> + * \\param[in] severity The log message severity\n> + *\n> + * This function is used as a backeng by the LOG() macro to create a log\n> + * message for locations not inheriting from the Loggable class.\n> + *\n> + * \\return A log message\n> + */\n> +LogMessage _log(const char *fileName, unsigned int line,\n> +\t\tconst LogCategory &category, LogSeverity severity)\n> +{\n> +\treturn LogMessage(fileName, line, category, severity);\n> +}\n> +\n> /**\n> * \\def LOG_DECLARE_CATEGORY(name)\n> * \\hideinitializer\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B3780610B1\n\tfor ;\n\tSun, 10 Feb 2019 14:14:40 +0100 (CET)","by mail-lj1-x243.google.com with SMTP id v12-v6so1897782ljc.6\n\tfor ;\n\tSun, 10 Feb 2019 05:14:40 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\ts27-v6sm1512137ljd.64.2019.02.10.05.14.39\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSun, 10 Feb 2019 05:14:39 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=2x0C7+LFR1MT0J2uYl39n34+dckuEypIx7OwsAtEMdE=;\n\tb=inC/piLQcoICLCPSJ8rJP7VGbMTxQFh6co/xawUX39qyyMfntLVnShog0SuR3/6gEW\n\t9eVLaFoq748dOQuBwXfqLC5uCwqGlNYpuBy2v/g27jY5NWXfDaDvSvswp7iSV60l30qQ\n\t86QdHknyRKoqelBFF+HhQiA0iSR349oVzqzYvRzOqNZUJiHGUR/okjgjJEiZCjCJxQ9J\n\tK1UDl6KZjOfD0wrluN+2h8lqHuDb7GYSga9MeYs8g3eJ3X6ze1I6T24KHtWk4p4zgRir\n\tqiYBFGhFcVUwsErJt/eEVnApkaLS61B1lnBjgBr4PuSdtP6NxUFZDBkLZ4/xb0jKX+TG\n\to4gQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=2x0C7+LFR1MT0J2uYl39n34+dckuEypIx7OwsAtEMdE=;\n\tb=cQlbqfbdLGDfn3fHDjHQFnBAZENjAby3VgRPZxMVEOtvcn3h0K4tYTzoHeFHLbNb9O\n\tTkonimOEC63lXFunpZ8hnhoH2mgA1OpiRhtS01+4ZBRk8FtcgZ9WtEHFKsJEyOu6/a7T\n\td+hTxQFuzzyPbtJKt0mN/vrgERdMj85cr/s5WPCNSFRoIySPySmHQE71/xZgEXBYogoh\n\tXYiq1Zjj3y/CtazPyD0n+sbQdaU6l7k/+giaBsf4jpZCwqHndWkYla7yn5DkTSPnVmN4\n\t+1LXuX3RB7ORyrz33XKlaqL6N9fmJlXWA4XGgbdPVL2Stv84cqXstnXJCITXlAmq/R1O\n\tcnIw==","X-Gm-Message-State":"AHQUAuabthvsdfWQY+BtrVoK1tn+aOqnrqjAPbsnOrAcMQumkH7APBPw\n\tXbOcucIFEdM02wenxbympKay9fNUtmk=","X-Google-Smtp-Source":"AHgI3IahGkyPMGtBoxPG0m0mWeISXk3Qvs5lMwkIQP1ClIq3TS+G2v0lHugbGb2BtjR74675eKny1Q==","X-Received":"by 2002:a2e:302:: with SMTP id\n\t2-v6mr18449414ljd.137.1549804479893; \n\tSun, 10 Feb 2019 05:14:39 -0800 (PST)","Date":"Sun, 10 Feb 2019 14:14:38 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190210131438.GA31044@bigcity.dyn.berto.se>","References":"<20190208144540.15529-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190208144540.15529-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: log: Allow extending\n\tlog messages","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 10 Feb 2019 13:14:41 -0000"}},{"id":787,"web_url":"https://patchwork.libcamera.org/comment/787/","msgid":"<20190212095220.c7wfhndjg735gnng@uno.localdomain>","date":"2019-02-12T09:52:20","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: log: Allow extending\n\tlog messages","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Fri, Feb 08, 2019 at 04:45:39PM +0200, Laurent Pinchart wrote:\n> Introduce a base Loggable class that can be inherited from by other\n> classes to support adding per-instance information to the log messages.\n>\n> Signed-off-by: Laurent Pinchart \n\nI like then end result and the process that brought us there!\n\nNo need for a tag, as Niklas supplied one already, but feel free to\nadd my:\n\nConfused-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/include/log.h | 23 ++++++-\n> src/libcamera/log.cpp | 124 ++++++++++++++++++++++++++++++++++++\n> 2 files changed, 145 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/include/log.h b/src/libcamera/include/log.h\n> index ad8f8452c333..8ea5a1eb673a 100644\n> --- a/src/libcamera/include/log.h\n> +++ b/src/libcamera/include/log.h\n> @@ -54,6 +54,7 @@ public:\n> \tLogMessage(const char *fileName, unsigned int line,\n> \t\t const LogCategory &category, LogSeverity severity);\n> \tLogMessage(const LogMessage &) = delete;\n> +\tLogMessage(LogMessage &&);\n> \t~LogMessage();\n>\n> \tstd::ostream &stream() { return msgStream_; }\n> @@ -66,13 +67,31 @@ private:\n> \tLogSeverity severity_;\n> };\n>\n> +class Loggable\n> +{\n> +public:\n> +\tvirtual ~Loggable();\n> +\n> +protected:\n> +\tvirtual std::string logPrefix() const = 0;\n> +\n> +\tLogMessage _log(const char *file, unsigned int line,\n> +\t\t\tLogSeverity severity);\n> +\tLogMessage _log(const char *file, unsigned int line,\n> +\t\t\tconst LogCategory &category, LogSeverity severity);\n> +};\n> +\n> +LogMessage _log(const char *file, unsigned int line, LogSeverity severity);\n> +LogMessage _log(const char *file, unsigned int line,\n> +\t\tconst LogCategory &category, LogSeverity severity);\n> +\n> #ifndef __DOXYGEN__\n> #define _LOG_CATEGORY(name) logCategory##name\n>\n> #define _LOG1(severity) \\\n> -\tLogMessage(__FILE__, __LINE__, Log##severity).stream()\n> +\t_log(__FILE__, __LINE__, Log##severity).stream()\n> #define _LOG2(category, severity) \\\n> -\tLogMessage(__FILE__, __LINE__, _LOG_CATEGORY(category)(), Log##severity).stream()\n> +\t_log(__FILE__, __LINE__, _LOG_CATEGORY(category)(), Log##severity).stream()\n>\n> /*\n> * Expand the LOG() macro to _LOG1() or _LOG2() based on the number of\n> diff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp\n> index edeb5eabb264..26ebf410a7a9 100644\n> --- a/src/libcamera/log.cpp\n> +++ b/src/libcamera/log.cpp\n> @@ -405,6 +405,25 @@ LogMessage::LogMessage(const char *fileName, unsigned int line,\n> \tinit(fileName, line);\n> }\n>\n> +/**\n> + * \\brief Move-construct a log message\n> + * \\param[in] other The other message\n> + *\n> + * The move constructor is meant to support the _log() functions. Thanks to copy\n> + * elision it will likely never be called, but C++11 only permits copy elision,\n> + * it doesn't enforce it unlike C++17. To avoid potential link errors depending\n> + * on the compiler type and version, and optimization level, the move\n> + * constructor is defined even if it will likely never be called, and ensures\n> + * that the destructor of the \\a other message will not output anything to the\n> + * log by setting the severity to -1.\n> + */\n> +LogMessage::LogMessage(LogMessage &&other)\n> +\t: msgStream_(std::move(other.msgStream_)), category_(other.category_),\n> +\t severity_(other.severity_)\n> +{\n> +\tother.severity_ = static_cast(-1);\n> +}\n> +\n> void LogMessage::init(const char *fileName, unsigned int line)\n> {\n> \t/* Log the timestamp, severity and file information. */\n> @@ -424,6 +443,10 @@ void LogMessage::init(const char *fileName, unsigned int line)\n>\n> LogMessage::~LogMessage()\n> {\n> +\t/* Don't print anything if we have been moved to another LogMessage. */\n> +\tif (severity_ == -1)\n> +\t\treturn;\n> +\n> \tmsgStream_ << std::endl;\n>\n> \tif (severity_ >= category_.severity()) {\n> @@ -445,6 +468,107 @@ LogMessage::~LogMessage()\n> * \\return A reference to the log message stream\n> */\n>\n> +/**\n> + * \\class Loggable\n> + * \\brief Base class to support log message extensions\n> + *\n> + * The Loggable class allows classes to extend log messages without any change\n> + * to the way the LOG() macro is invoked. By inheriting from Loggable and\n> + * implementing the logPrefix() virtual method, a class can specify extra\n> + * information to be automatically added to messages logged from class member\n> + * methods.\n> + */\n> +\n> +Loggable::~Loggable()\n> +{\n> +}\n> +\n> +/**\n> + * \\fn Loggable::logPrefix()\n> + * \\brief Retrieve a string to be prefixed to the log message\n> + *\n> + * This method allows classes inheriting from the Loggable class to extend the\n> + * logger with an object-specific prefix output right before the log message\n> + * contents.\n> + *\n> + * \\return A string to be prefixed to the log message\n> + */\n> +\n> +/**\n> + * \\brief Create a temporary LogMessage object to log a message\n> + * \\param[in] fileName The file name where the message is logged from\n> + * \\param[in] line The line number where the message is logged from\n> + * \\param[in] severity The log message severity\n> + *\n> + * This method is used as a backeng by the LOG() macro to create a log message\n> + * for locations inheriting from the Loggable class.\n> + *\n> + * \\return A log message\n> + */\n> +LogMessage Loggable::_log(const char *fileName, unsigned int line,\n> +\t\t\t LogSeverity severity)\n> +{\n> +\tLogMessage msg(fileName, line, severity);\n> +\n> +\tmsg.stream() << logPrefix() << \": \";\n> +\treturn msg;\n> +}\n> +\n> +/**\n> + * \\brief Create a temporary LogMessage object to log a message\n> + * \\param[in] fileName The file name where the message is logged from\n> + * \\param[in] line The line number where the message is logged from\n> + * \\param[in] category The log message category\n> + * \\param[in] severity The log message severity\n> + *\n> + * This method is used as a backeng by the LOG() macro to create a log message\n> + * for locations inheriting from the Loggable class.\n> + *\n> + * \\return A log message\n> + */\n> +LogMessage Loggable::_log(const char *fileName, unsigned int line,\n> +\t\t\t const LogCategory &category, LogSeverity severity)\n> +{\n> +\tLogMessage msg(fileName, line, category, severity);\n> +\n> +\tmsg.stream() << logPrefix() << \": \";\n> +\treturn msg;\n> +}\n> +\n> +/**\n> + * \\brief Create a temporary LogMessage object to log a message\n> + * \\param[in] fileName The file name where the message is logged from\n> + * \\param[in] line The line number where the message is logged from\n> + * \\param[in] severity The log message severity\n> + *\n> + * This function is used as a backeng by the LOG() macro to create a log\n> + * message for locations not inheriting from the Loggable class.\n> + *\n> + * \\return A log message\n> + */\n> +LogMessage _log(const char *fileName, unsigned int line, LogSeverity severity)\n> +{\n> +\treturn LogMessage(fileName, line, severity);\n> +}\n> +\n> +/**\n> + * \\brief Create a temporary LogMessage object to log a message\n> + * \\param[in] fileName The file name where the message is logged from\n> + * \\param[in] line The line number where the message is logged from\n> + * \\param[in] category The log message category\n> + * \\param[in] severity The log message severity\n> + *\n> + * This function is used as a backeng by the LOG() macro to create a log\n> + * message for locations not inheriting from the Loggable class.\n> + *\n> + * \\return A log message\n> + */\n> +LogMessage _log(const char *fileName, unsigned int line,\n> +\t\tconst LogCategory &category, LogSeverity severity)\n> +{\n> +\treturn LogMessage(fileName, line, category, severity);\n> +}\n> +\n> /**\n> * \\def LOG_DECLARE_CATEGORY(name)\n> * \\hideinitializer\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9875B60DBB\n\tfor ;\n\tTue, 12 Feb 2019 10:51:57 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 0BCE2240018;\n\tTue, 12 Feb 2019 09:51:56 +0000 (UTC)"],"Date":"Tue, 12 Feb 2019 10:52:20 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190212095220.c7wfhndjg735gnng@uno.localdomain>","References":"<20190208144540.15529-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"amukulhcuxgbmvyg\"","Content-Disposition":"inline","In-Reply-To":"<20190208144540.15529-1-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: log: Allow extending\n\tlog messages","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 12 Feb 2019 09:51:57 -0000"}}]