[{"id":767,"web_url":"https://patchwork.libcamera.org/comment/767/","msgid":"<20190208143501.GD4562@pendragon.ideasonboard.com>","date":"2019-02-08T14:35:01","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: vimc: fix name\n\tof pipeline handler class","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Fri, Feb 08, 2019 at 01:41:00PM +0100, Niklas Söderlund wrote:\n> Rename the VIMC pipeline handler to match the naming convection.\n> \n> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  src/libcamera/pipeline/vimc.cpp | 28 ++++++++++++++--------------\n>  1 file changed, 14 insertions(+), 14 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\n> index 0e9ad7b59ee57574..46840a4f410456d2 100644\n> --- a/src/libcamera/pipeline/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc.cpp\n> @@ -19,11 +19,11 @@ namespace libcamera {\n>  \n>  LOG_DEFINE_CATEGORY(VIMC)\n>  \n> -class PipeHandlerVimc : public PipelineHandler\n> +class PipelineHandlerVimc : public PipelineHandler\n>  {\n>  public:\n> -\tPipeHandlerVimc(CameraManager *manager);\n> -\t~PipeHandlerVimc();\n> +\tPipelineHandlerVimc(CameraManager *manager);\n> +\t~PipelineHandlerVimc();\n>  \n>  \tstd::map<Stream *, StreamConfiguration>\n>  \tstreamConfiguration(Camera *camera,\n> @@ -47,12 +47,12 @@ private:\n>  \tStream stream_;\n>  };\n>  \n> -PipeHandlerVimc::PipeHandlerVimc(CameraManager *manager)\n> +PipelineHandlerVimc::PipelineHandlerVimc(CameraManager *manager)\n>  \t: PipelineHandler(manager), media_(nullptr), video_(nullptr)\n>  {\n>  }\n>  \n> -PipeHandlerVimc::~PipeHandlerVimc()\n> +PipelineHandlerVimc::~PipelineHandlerVimc()\n>  {\n>  \tdelete video_;\n>  \n> @@ -61,7 +61,7 @@ PipeHandlerVimc::~PipeHandlerVimc()\n>  }\n>  \n>  std::map<Stream *, StreamConfiguration>\n> -PipeHandlerVimc::streamConfiguration(Camera *camera,\n> +PipelineHandlerVimc::streamConfiguration(Camera *camera,\n>  \t\t\t\t     std::vector<Stream *> &streams)\n>  {\n>  \tstd::map<Stream *, StreamConfiguration> configs;\n> @@ -79,7 +79,7 @@ PipeHandlerVimc::streamConfiguration(Camera *camera,\n>  \treturn configs;\n>  }\n>  \n> -int PipeHandlerVimc::configureStreams(Camera *camera,\n> +int PipelineHandlerVimc::configureStreams(Camera *camera,\n>  \t\t\t\t      std::map<Stream *, StreamConfiguration> &config)\n>  {\n>  \tStreamConfiguration *cfg = &config[&stream_];\n> @@ -95,7 +95,7 @@ int PipeHandlerVimc::configureStreams(Camera *camera,\n>  \treturn video_->setFormat(&format);\n>  }\n>  \n> -int PipeHandlerVimc::allocateBuffers(Camera *camera, Stream *stream)\n> +int PipelineHandlerVimc::allocateBuffers(Camera *camera, Stream *stream)\n>  {\n>  \tconst StreamConfiguration &cfg = stream->configuration();\n>  \n> @@ -104,22 +104,22 @@ int PipeHandlerVimc::allocateBuffers(Camera *camera, Stream *stream)\n>  \treturn video_->exportBuffers(cfg.bufferCount, &stream->bufferPool());\n>  }\n>  \n> -int PipeHandlerVimc::freeBuffers(Camera *camera, Stream *stream)\n> +int PipelineHandlerVimc::freeBuffers(Camera *camera, Stream *stream)\n>  {\n>  \treturn video_->releaseBuffers();\n>  }\n>  \n> -int PipeHandlerVimc::start(const Camera *camera)\n> +int PipelineHandlerVimc::start(const Camera *camera)\n>  {\n>  \treturn video_->streamOn();\n>  }\n>  \n> -void PipeHandlerVimc::stop(const Camera *camera)\n> +void PipelineHandlerVimc::stop(const Camera *camera)\n>  {\n>  \tvideo_->streamOff();\n>  }\n>  \n> -int PipeHandlerVimc::queueRequest(const Camera *camera, Request *request)\n> +int PipelineHandlerVimc::queueRequest(const Camera *camera, Request *request)\n>  {\n>  \tBuffer *buffer = request->findBuffer(&stream_);\n>  \tif (!buffer) {\n> @@ -134,7 +134,7 @@ int PipeHandlerVimc::queueRequest(const Camera *camera, Request *request)\n>  \treturn 0;\n>  }\n>  \n> -bool PipeHandlerVimc::match(DeviceEnumerator *enumerator)\n> +bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator)\n>  {\n>  \tDeviceMatch dm(\"vimc\");\n>  \n> @@ -169,6 +169,6 @@ bool PipeHandlerVimc::match(DeviceEnumerator *enumerator)\n>  \treturn true;\n>  }\n>  \n> -REGISTER_PIPELINE_HANDLER(PipeHandlerVimc);\n> +REGISTER_PIPELINE_HANDLER(PipelineHandlerVimc);\n>  \n>  } /* namespace libcamera */","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 99D6C60B0E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  8 Feb 2019 15:35:03 +0100 (CET)","from pendragon.ideasonboard.com (d51A4137F.access.telenet.be\n\t[81.164.19.127])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0B475F9;\n\tFri,  8 Feb 2019 15:35:02 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1549636503;\n\tbh=35VakrFeCAl2oewurRC4VcZ6YgonHOx3uCxTPj+oivs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jzwqB2EBHdX4MFu+be4CbvquAUioxD71QpfDLjG44UyIhpPULpObSxSuNxytdlXF9\n\tRccHjpLO+4uYKpqIUzeHfhkzHokec4O4YQ376Fj2wlyLZrsXSzOpHRoOp/mHpnrcwC\n\tgQaUJAELUB2HYYMjJyPBgNzDyABO8DdDQP0pcwuQ=","Date":"Fri, 8 Feb 2019 16:35:01 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Niklas =?utf-8?q?S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190208143501.GD4562@pendragon.ideasonboard.com>","References":"<20190208124100.7498-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190208124100.7498-1-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: vimc: fix name\n\tof pipeline handler class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 08 Feb 2019 14:35:03 -0000"}},{"id":768,"web_url":"https://patchwork.libcamera.org/comment/768/","msgid":"<20190208144240.GH32622@bigcity.dyn.berto.se>","date":"2019-02-08T14:42:40","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: vimc: fix name\n\tof pipeline handler class","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your feedback.\n\nOn 2019-02-08 16:35:01 +0200, Laurent Pinchart wrote:\n> Hi Niklas,\n> \n> Thank you for the patch.\n> \n> On Fri, Feb 08, 2019 at 01:41:00PM +0100, Niklas Söderlund wrote:\n> > Rename the VIMC pipeline handler to match the naming convection.\n> > \n> > Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n> \n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nAs to not cause future conflicts on names I have now pushed this with \nyour tag.\n\n> \n> > ---\n> >  src/libcamera/pipeline/vimc.cpp | 28 ++++++++++++++--------------\n> >  1 file changed, 14 insertions(+), 14 deletions(-)\n> > \n> > diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\n> > index 0e9ad7b59ee57574..46840a4f410456d2 100644\n> > --- a/src/libcamera/pipeline/vimc.cpp\n> > +++ b/src/libcamera/pipeline/vimc.cpp\n> > @@ -19,11 +19,11 @@ namespace libcamera {\n> >  \n> >  LOG_DEFINE_CATEGORY(VIMC)\n> >  \n> > -class PipeHandlerVimc : public PipelineHandler\n> > +class PipelineHandlerVimc : public PipelineHandler\n> >  {\n> >  public:\n> > -\tPipeHandlerVimc(CameraManager *manager);\n> > -\t~PipeHandlerVimc();\n> > +\tPipelineHandlerVimc(CameraManager *manager);\n> > +\t~PipelineHandlerVimc();\n> >  \n> >  \tstd::map<Stream *, StreamConfiguration>\n> >  \tstreamConfiguration(Camera *camera,\n> > @@ -47,12 +47,12 @@ private:\n> >  \tStream stream_;\n> >  };\n> >  \n> > -PipeHandlerVimc::PipeHandlerVimc(CameraManager *manager)\n> > +PipelineHandlerVimc::PipelineHandlerVimc(CameraManager *manager)\n> >  \t: PipelineHandler(manager), media_(nullptr), video_(nullptr)\n> >  {\n> >  }\n> >  \n> > -PipeHandlerVimc::~PipeHandlerVimc()\n> > +PipelineHandlerVimc::~PipelineHandlerVimc()\n> >  {\n> >  \tdelete video_;\n> >  \n> > @@ -61,7 +61,7 @@ PipeHandlerVimc::~PipeHandlerVimc()\n> >  }\n> >  \n> >  std::map<Stream *, StreamConfiguration>\n> > -PipeHandlerVimc::streamConfiguration(Camera *camera,\n> > +PipelineHandlerVimc::streamConfiguration(Camera *camera,\n> >  \t\t\t\t     std::vector<Stream *> &streams)\n> >  {\n> >  \tstd::map<Stream *, StreamConfiguration> configs;\n> > @@ -79,7 +79,7 @@ PipeHandlerVimc::streamConfiguration(Camera *camera,\n> >  \treturn configs;\n> >  }\n> >  \n> > -int PipeHandlerVimc::configureStreams(Camera *camera,\n> > +int PipelineHandlerVimc::configureStreams(Camera *camera,\n> >  \t\t\t\t      std::map<Stream *, StreamConfiguration> &config)\n> >  {\n> >  \tStreamConfiguration *cfg = &config[&stream_];\n> > @@ -95,7 +95,7 @@ int PipeHandlerVimc::configureStreams(Camera *camera,\n> >  \treturn video_->setFormat(&format);\n> >  }\n> >  \n> > -int PipeHandlerVimc::allocateBuffers(Camera *camera, Stream *stream)\n> > +int PipelineHandlerVimc::allocateBuffers(Camera *camera, Stream *stream)\n> >  {\n> >  \tconst StreamConfiguration &cfg = stream->configuration();\n> >  \n> > @@ -104,22 +104,22 @@ int PipeHandlerVimc::allocateBuffers(Camera *camera, Stream *stream)\n> >  \treturn video_->exportBuffers(cfg.bufferCount, &stream->bufferPool());\n> >  }\n> >  \n> > -int PipeHandlerVimc::freeBuffers(Camera *camera, Stream *stream)\n> > +int PipelineHandlerVimc::freeBuffers(Camera *camera, Stream *stream)\n> >  {\n> >  \treturn video_->releaseBuffers();\n> >  }\n> >  \n> > -int PipeHandlerVimc::start(const Camera *camera)\n> > +int PipelineHandlerVimc::start(const Camera *camera)\n> >  {\n> >  \treturn video_->streamOn();\n> >  }\n> >  \n> > -void PipeHandlerVimc::stop(const Camera *camera)\n> > +void PipelineHandlerVimc::stop(const Camera *camera)\n> >  {\n> >  \tvideo_->streamOff();\n> >  }\n> >  \n> > -int PipeHandlerVimc::queueRequest(const Camera *camera, Request *request)\n> > +int PipelineHandlerVimc::queueRequest(const Camera *camera, Request *request)\n> >  {\n> >  \tBuffer *buffer = request->findBuffer(&stream_);\n> >  \tif (!buffer) {\n> > @@ -134,7 +134,7 @@ int PipeHandlerVimc::queueRequest(const Camera *camera, Request *request)\n> >  \treturn 0;\n> >  }\n> >  \n> > -bool PipeHandlerVimc::match(DeviceEnumerator *enumerator)\n> > +bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator)\n> >  {\n> >  \tDeviceMatch dm(\"vimc\");\n> >  \n> > @@ -169,6 +169,6 @@ bool PipeHandlerVimc::match(DeviceEnumerator *enumerator)\n> >  \treturn true;\n> >  }\n> >  \n> > -REGISTER_PIPELINE_HANDLER(PipeHandlerVimc);\n> > +REGISTER_PIPELINE_HANDLER(PipelineHandlerVimc);\n> >  \n> >  } /* namespace libcamera */\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from mail-lj1-f177.google.com (mail-lj1-f177.google.com\n\t[209.85.208.177])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C66CC6101F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  8 Feb 2019 15:43:42 +0100 (CET)","by mail-lj1-f177.google.com with SMTP id z25-v6so3180470ljk.7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 08 Feb 2019 06:43:42 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tg70-v6sm406107ljg.92.2019.02.08.06.42.40\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 08 Feb 2019 06:42:40 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=8GMaqCnqpWlQh+wrfVU7kZURbHl2tM/R82MfysUU2fA=;\n\tb=KqnQKVvIN2eWJRj9XyTZZILlnXCOy6geFSuxfc34JhUKec7GqEl6zPh46T1oiAGerO\n\tkXtu23pTNAbRBa361fLuLwbt3t00MXPqNWjLrR2VUFfZ/9FjYBwh04bjlxwoP2Dm7gMk\n\tZ/Lk92D1ihDHghyqtigpORcKPNE7bkZDGPrukzOTSRcnxISxvoJPY8lQ0Aisr7Hv/UsZ\n\tM87eVi3R6Fixlwb502+bia1nbOEiiGZarWjzMRAHElBLngDBnhZFPJ8wRQ5l6EQQM184\n\t6gImEAiQc3ecwrUb4mYXISY/tKS5gUAaHc5XAQF+WEPF7Np0D+qGyWgo2spDcdNYCFfL\n\tfa6g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=8GMaqCnqpWlQh+wrfVU7kZURbHl2tM/R82MfysUU2fA=;\n\tb=pRkSxFbOee3mYgTG/0wX/THRfL1ZrfGupIaEvJ6Ko7bR6rDfJad0x/9EqMgzlF3Qzl\n\tr39xXhSesR7vHeNIuJF7icjHj82+uW3mgfp7JhSCGtt8YqP/dJ2Yjds2clybEfkw1BtV\n\t0hi8ASy3Rx10TNaoTgGzuRrnHuHkgOlm9WxiRLaho0mpv/5cNcwwi0yeFsIB2/tcmdl3\n\tiORAqabR6PMJq2iF+T0BiokQIyw/UjO2z7gme83nHahj8KFRJciq/D2GQnFvRbYOV6zE\n\t19x0Ed2QiOut/HC4P3JUYsLQOXcyC7BbuJvwVZe5KI4Gq9jBMYzjI+3km35ASu3z9ilu\n\tt7Bg==","X-Gm-Message-State":"AHQUAubTKYShSHA2NDASho+hehlTxcy7nELsGKUxv8cLtDJJXux4vWcF\n\tbg+L+WXSWz6PYecj4TWiIsvt+HOrT34=","X-Google-Smtp-Source":"AHgI3IbMztQpYUQr5oyq+AfMeVQqf+HYO/9IRWaLzS8eXvJiPKuO077rD2jyy2Gb/jCUFIwXT329MQ==","X-Received":"by 2002:a2e:9694:: with SMTP id\n\tq20-v6mr13718124lji.173.1549636961526; \n\tFri, 08 Feb 2019 06:42:41 -0800 (PST)","Date":"Fri, 8 Feb 2019 15:42:40 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190208144240.GH32622@bigcity.dyn.berto.se>","References":"<20190208124100.7498-1-niklas.soderlund@ragnatech.se>\n\t<20190208143501.GD4562@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190208143501.GD4562@pendragon.ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: vimc: fix name\n\tof pipeline handler class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 08 Feb 2019 14:43:43 -0000"}}]