[{"id":766,"web_url":"https://patchwork.libcamera.org/comment/766/","msgid":"<20190207225622.l42cg63uv72yor4u@uno.localdomain>","date":"2019-02-07T22:56:22","subject":"Re: [libcamera-devel] [PATCH 5/5] libcamera: v4l2_device: Provide\n\tV4L2 Log helper","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n   while this goes in the right direction in my opnion,\ncould we maybe hide this behind a regular LOG, maybe adding an\noptional third argument?\n\nSomething like:\n\n------------------------------------------------------------------------------\ndiff --git a/src/libcamera/include/log.h b/src/libcamera/include/log.h\nindex ad8f845..91fe093 100644\n--- a/src/libcamera/include/log.h\n+++ b/src/libcamera/include/log.h\n@@ -8,6 +8,7 @@\n #define __LIBCAMERA_LOG_H__\n\n #include <sstream>\n+#include <string>\n\n namespace libcamera {\n\n@@ -53,6 +54,8 @@ public:\n                   LogSeverity severity);\n        LogMessage(const char *fileName, unsigned int line,\n                   const LogCategory &category, LogSeverity severity);\n+       LogMessage(const char *fileName, unsigned int line, std::string id,\n+                  const LogCategory &category, LogSeverity severity);\n        LogMessage(const LogMessage &) = delete;\n        ~LogMessage();\n\n@@ -64,6 +67,7 @@ private:\n        std::ostringstream msgStream_;\n        const LogCategory &category_;\n        LogSeverity severity_;\n+       std::string id_;\n };\n\n #ifndef __DOXYGEN__\n@@ -73,13 +77,15 @@ private:\n        LogMessage(__FILE__, __LINE__, Log##severity).stream()\n #define _LOG2(category, severity) \\\n        LogMessage(__FILE__, __LINE__, _LOG_CATEGORY(category)(), Log##severity).stream()\n+#define _LOG3(category, severity, id) \\\n+       LogMessage(__FILE__, __LINE__, id, _LOG_CATEGORY(category)(), Log##severity).stream()\n\n /*\n  * Expand the LOG() macro to _LOG1() or _LOG2() based on the number of\n  * arguments.\n  */\n-#define _LOG_MACRO(_1, _2, NAME, ...) NAME\n-#define LOG(...) _LOG_MACRO(__VA_ARGS__, _LOG2, _LOG1)(__VA_ARGS__)\n+#define _LOG_MACRO(_1, _2, _3, NAME, ...) NAME\n+#define LOG(...) _LOG_MACRO(__VA_ARGS__, _LOG3, _LOG2, _LOG1)(__VA_ARGS__)\n #else /* __DOXYGEN___ */\n #define LOG(category, severity)\n #endif /* __DOXYGEN__ */\ndiff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp\nindex edeb5ea..2e68a0d 100644\n--- a/src/libcamera/log.cpp\n+++ b/src/libcamera/log.cpp\n@@ -380,7 +380,7 @@ static const char *log_severity_name(LogSeverity severity)\n  */\n LogMessage::LogMessage(const char *fileName, unsigned int line,\n                       LogSeverity severity)\n-       : category_(LogCategory::defaultCategory()), severity_(severity)\n+       : category_(LogCategory::defaultCategory()), severity_(severity), id_(\"\")\n {\n        init(fileName, line);\n }\n@@ -400,11 +400,17 @@ LogMessage::LogMessage(const char *fileName, unsigned int line,\n  */\n LogMessage::LogMessage(const char *fileName, unsigned int line,\n                       const LogCategory &category, LogSeverity severity)\n-       : category_(category), severity_(severity)\n+       : category_(category), severity_(severity), id_(\"\")\n {\n        init(fileName, line);\n }\n\n+LogMessage::LogMessage(const char *fileName, unsigned int line, std::string id,\n+                      const LogCategory &category, LogSeverity severity)\n+       : category_(category), severity_(severity), id_(id)\n+{\n+       init(fileName, line);\n+}\n void LogMessage::init(const char *fileName, unsigned int line)\n {\n        /* Log the timestamp, severity and file information. */\n@@ -420,6 +426,7 @@ void LogMessage::init(const char *fileName, unsigned int line)\n        msgStream_ << \" \" << log_severity_name(severity_);\n        msgStream_ << \" \" << category_.name();\n        msgStream_ << \" \" << basename(fileName) << \":\" << line << \" \";\n+       msgStream_ << \" \" << id_ << \" \";\n }\n\n LogMessage::~LogMessage()\n -----------------------------------------------------------------------------\n\nThis would produce something like:\n[9:20:55.697520218]   ERR V4L2 v4l2_device.cpp:255  /dev/video0 Device already open\n\nThanks\n   j\n\n\nOn Thu, Feb 07, 2019 at 09:21:19PM +0000, Kieran Bingham wrote:\n> Add a V4L2DEVICE_LOG Macro helper to prepend the V4L2 Video Device node to\n> every log output.  This is particularly useful when more than one V4L2Device is\n> utilised in the system.\n>\n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> ---\n>  src/libcamera/v4l2_device.cpp | 48 +++++++++++++++++++----------------\n>  1 file changed, 26 insertions(+), 22 deletions(-)\n>\n> diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\n> index c2e4d0ea8db2..ce977613ff20 100644\n> --- a/src/libcamera/v4l2_device.cpp\n> +++ b/src/libcamera/v4l2_device.cpp\n> @@ -28,6 +28,8 @@ namespace libcamera {\n>\n>  LOG_DEFINE_CATEGORY(V4L2)\n>\n> +#define V4L2DEVICE_LOG(severity) LOG(V4L2, severity) << deviceNode_ << \": \"\n> +\n>  /**\n>   * \\struct V4L2Capability\n>   * \\brief struct v4l2_capability object wrapper and helpers\n> @@ -254,14 +256,14 @@ int V4L2Device::open()\n>  \tint ret;\n>\n>  \tif (isOpen()) {\n> -\t\tLOG(V4L2, Error) << \"Device already open\";\n> +\t\tV4L2DEVICE_LOG(Error) << \"Device already open\";\n>  \t\treturn -EBUSY;\n>  \t}\n>\n>  \tret = ::open(deviceNode_.c_str(), O_RDWR | O_NONBLOCK);\n>  \tif (ret < 0) {\n>  \t\tret = -errno;\n> -\t\tLOG(V4L2, Error)\n> +\t\tV4L2DEVICE_LOG(Error)\n>  \t\t\t<< \"Failed to open V4L2 device '\" << deviceNode_\n>  \t\t\t<< \"': \" << strerror(-ret);\n>  \t\treturn ret;\n> @@ -271,24 +273,25 @@ int V4L2Device::open()\n>  \tret = ioctl(fd_, VIDIOC_QUERYCAP, &caps_);\n>  \tif (ret < 0) {\n>  \t\tret = -errno;\n> -\t\tLOG(V4L2, Error)\n> +\t\tV4L2DEVICE_LOG(Error)\n>  \t\t\t<< \"Failed to query device capabilities: \"\n>  \t\t\t<< strerror(-ret);\n>  \t\treturn ret;\n>  \t}\n>\n> -\tLOG(V4L2, Debug)\n> +\tV4L2DEVICE_LOG(Debug)\n>  \t\t<< \"Opened '\" << deviceNode_ << \"' \"\n>  \t\t<< caps_.bus_info() << \": \" << caps_.driver()\n>  \t\t<< \": \" << caps_.card();\n>\n>  \tif (!caps_.isCapture() && !caps_.isOutput()) {\n> -\t\tLOG(V4L2, Debug) << \"Device is not a supported type\";\n> +\t\tV4L2DEVICE_LOG(Debug) << \"Device is not a supported type\";\n>  \t\treturn -EINVAL;\n>  \t}\n>\n>  \tif (!caps_.hasStreaming()) {\n> -\t\tLOG(V4L2, Error) << \"Device does not support streaming I/O\";\n> +\t\tV4L2DEVICE_LOG(Error)\n> +\t\t\t<< \"Device does not support streaming I/O\";\n>  \t\treturn -EINVAL;\n>  \t}\n>\n> @@ -513,13 +516,13 @@ int V4L2Device::requestBuffers(unsigned int count)\n>  \tret = ioctl(fd_, VIDIOC_REQBUFS, &rb);\n>  \tif (ret < 0) {\n>  \t\tret = -errno;\n> -\t\tLOG(V4L2, Error)\n> +\t\tV4L2DEVICE_LOG(Error)\n>  \t\t\t<< \"Unable to request \" << count << \" buffers: \"\n>  \t\t\t<< strerror(-ret);\n>  \t\treturn ret;\n>  \t}\n>\n> -\tLOG(V4L2, Debug)\n> +\tV4L2DEVICE_LOG(Debug)\n>  \t\t<< deviceNode_ << \":\" << rb.count << \" buffers requested.\";\n>\n>  \treturn rb.count;\n> @@ -545,7 +548,8 @@ int V4L2Device::exportBuffers(BufferPool *pool)\n>\n>  \tallocatedBuffers = ret;\n>  \tif (allocatedBuffers < pool->count()) {\n> -\t\tLOG(V4L2, Error) << \"Not enough buffers provided by V4L2Device\";\n> +\t\tV4L2DEVICE_LOG(Error)\n> +\t\t\t<< \"Not enough buffers provided by V4L2Device\";\n>  \t\trequestBuffers(0);\n>  \t\treturn -ENOMEM;\n>  \t}\n> @@ -565,7 +569,7 @@ int V4L2Device::exportBuffers(BufferPool *pool)\n>  \t\tret = ioctl(fd_, VIDIOC_QUERYBUF, &buf);\n>  \t\tif (ret < 0) {\n>  \t\t\tret = -errno;\n> -\t\t\tLOG(V4L2, Error)\n> +\t\t\tV4L2DEVICE_LOG(Error)\n>  \t\t\t\t<< \"Unable to query buffer \" << i << \": \"\n>  \t\t\t\t<< strerror(-ret);\n>  \t\t\tbreak;\n> @@ -583,7 +587,7 @@ int V4L2Device::exportBuffers(BufferPool *pool)\n>  \t\t}\n>\n>  \t\tif (ret) {\n> -\t\t\tLOG(V4L2, Error) << \"Failed to create plane\";\n> +\t\t\tV4L2DEVICE_LOG(Error) << \"Failed to create plane\";\n>  \t\t\tbreak;\n>  \t\t}\n>  \t}\n> @@ -605,7 +609,7 @@ int V4L2Device::createPlane(Buffer *buffer, unsigned int planeIndex,\n>  \tstruct v4l2_exportbuffer expbuf = {};\n>  \tint ret;\n>\n> -\tLOG(V4L2, Debug)\n> +\tV4L2DEVICE_LOG(Debug)\n>  \t\t<< \"Buffer \" << buffer->index()\n>  \t\t<< \" plane \" << planeIndex\n>  \t\t<< \": length=\" << length;\n> @@ -618,7 +622,7 @@ int V4L2Device::createPlane(Buffer *buffer, unsigned int planeIndex,\n>  \tret = ioctl(fd_, VIDIOC_EXPBUF, &expbuf);\n>  \tif (ret < 0) {\n>  \t\tret = -errno;\n> -\t\tLOG(V4L2, Error)\n> +\t\tV4L2DEVICE_LOG(Error)\n>  \t\t\t<< \"Failed to export buffer: \" << strerror(-ret);\n>  \t\treturn ret;\n>  \t}\n> @@ -648,13 +652,13 @@ int V4L2Device::importBuffers(BufferPool *pool)\n>\n>  \tallocatedBuffers = ret;\n>  \tif (allocatedBuffers < pool->count()) {\n> -\t\tLOG(V4L2, Error)\n> +\t\tV4L2DEVICE_LOG(Error)\n>  \t\t\t<< \"Not enough buffers provided by V4L2Device\";\n>  \t\trequestBuffers(0);\n>  \t\treturn -ENOMEM;\n>  \t}\n>\n> -\tLOG(V4L2, Debug) << \"Device using an externally provided pool\";\n> +\tV4L2DEVICE_LOG(Debug) << \"Device using an externally provided pool\";\n>  \tbufferPool_ = pool;\n>\n>  \treturn 0;\n> @@ -665,7 +669,7 @@ int V4L2Device::importBuffers(BufferPool *pool)\n>   */\n>  int V4L2Device::releaseBuffers()\n>  {\n> -\tLOG(V4L2, Debug) << \"Releasing bufferPool\";\n> +\tV4L2DEVICE_LOG(Debug) << \"Releasing bufferPool\";\n>\n>  \trequestBuffers(0);\n>  \tbufferPool_ = nullptr;\n> @@ -715,12 +719,12 @@ int V4L2Device::queueBuffer(Buffer *buffer)\n>  \t\tbuf.m.planes = planes;\n>  \t}\n>\n> -\tLOG(V4L2, Debug) << \"Queueing buffer \" << buf.index;\n> +\tV4L2DEVICE_LOG(Debug) << \"Queueing buffer \" << buf.index;\n>\n>  \tret = ioctl(fd_, VIDIOC_QBUF, &buf);\n>  \tif (ret < 0) {\n>  \t\tret = -errno;\n> -\t\tLOG(V4L2, Error)\n> +\t\tV4L2DEVICE_LOG(Error)\n>  \t\t\t<< \"Failed to queue buffer \" << buf.index << \": \"\n>  \t\t\t<< strerror(-ret);\n>  \t\treturn ret;\n> @@ -757,7 +761,7 @@ Buffer *V4L2Device::dequeueBuffer()\n>  \tret = ioctl(fd_, VIDIOC_DQBUF, &buf);\n>  \tif (ret < 0) {\n>  \t\tret = -errno;\n> -\t\tLOG(V4L2, Error)\n> +\t\tV4L2DEVICE_LOG(Error)\n>  \t\t\t<< \"Failed to dequeue buffer: \" << strerror(-ret);\n>  \t\treturn nullptr;\n>  \t}\n> @@ -793,7 +797,7 @@ void V4L2Device::bufferAvailable(EventNotifier *notifier)\n>  \tif (!buffer)\n>  \t\treturn;\n>\n> -\tLOG(V4L2, Debug) << \"Buffer \" << buffer->index() << \" is available\";\n> +\tV4L2DEVICE_LOG(Debug) << \"Buffer \" << buffer->index() << \" is available\";\n>\n>  \t/* Notify anyone listening to the device. */\n>  \tbufferReady.emit(buffer);\n> @@ -819,7 +823,7 @@ int V4L2Device::streamOn()\n>  \tret = ioctl(fd_, VIDIOC_STREAMON, &bufferType_);\n>  \tif (ret < 0) {\n>  \t\tret = -errno;\n> -\t\tLOG(V4L2, Error)\n> +\t\tV4L2DEVICE_LOG(Error)\n>  \t\t\t<< \"Failed to start streaming: \" << strerror(-ret);\n>  \t\treturn ret;\n>  \t}\n> @@ -841,7 +845,7 @@ int V4L2Device::streamOff()\n>  \tret = ioctl(fd_, VIDIOC_STREAMOFF, &bufferType_);\n>  \tif (ret < 0) {\n>  \t\tret = -errno;\n> -\t\tLOG(V4L2, Error)\n> +\t\tV4L2DEVICE_LOG(Error)\n>  \t\t\t<< \"Failed to stop streaming: \" << strerror(-ret);\n>  \t\treturn ret;\n>  \t}\n> --\n> 2.19.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<jacopo@jmondi.org>","Received":["from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C2C75610B2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  7 Feb 2019 23:56:02 +0100 (CET)","from uno.localdomain (d51A4137F.access.telenet.be [81.164.19.127])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 436DAFF805;\n\tThu,  7 Feb 2019 22:56:02 +0000 (UTC)"],"X-Originating-IP":"81.164.19.127","Date":"Thu, 7 Feb 2019 23:56:22 +0100","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Message-ID":"<20190207225622.l42cg63uv72yor4u@uno.localdomain>","References":"<20190207212119.30299-1-kieran.bingham@ideasonboard.com>\n\t<20190207212119.30299-6-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"b4grqwru525tniui\"","Content-Disposition":"inline","In-Reply-To":"<20190207212119.30299-6-kieran.bingham@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 5/5] libcamera: v4l2_device: Provide\n\tV4L2 Log helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Thu, 07 Feb 2019 22:56:02 -0000"}},{"id":773,"web_url":"https://patchwork.libcamera.org/comment/773/","msgid":"<20190208173331.GJ4562@pendragon.ideasonboard.com>","date":"2019-02-08T17:33:31","subject":"Re: [libcamera-devel] [PATCH 5/5] libcamera: v4l2_device: Provide\n\tV4L2 Log helper","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Thu, Feb 07, 2019 at 09:21:19PM +0000, Kieran Bingham wrote:\n> Add a V4L2DEVICE_LOG Macro helper to prepend the V4L2 Video Device node to\n> every log output.  This is particularly useful when more than one V4L2Device is\n> utilised in the system.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nI've sent a patch that adds a Loggable class, it should cover your use\ncase in a more generic way.\n\n> ---\n>  src/libcamera/v4l2_device.cpp | 48 +++++++++++++++++++----------------\n>  1 file changed, 26 insertions(+), 22 deletions(-)\n> \n> diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\n> index c2e4d0ea8db2..ce977613ff20 100644\n> --- a/src/libcamera/v4l2_device.cpp\n> +++ b/src/libcamera/v4l2_device.cpp\n> @@ -28,6 +28,8 @@ namespace libcamera {\n>  \n>  LOG_DEFINE_CATEGORY(V4L2)\n>  \n> +#define V4L2DEVICE_LOG(severity) LOG(V4L2, severity) << deviceNode_ << \": \"\n> +\n>  /**\n>   * \\struct V4L2Capability\n>   * \\brief struct v4l2_capability object wrapper and helpers\n> @@ -254,14 +256,14 @@ int V4L2Device::open()\n>  \tint ret;\n>  \n>  \tif (isOpen()) {\n> -\t\tLOG(V4L2, Error) << \"Device already open\";\n> +\t\tV4L2DEVICE_LOG(Error) << \"Device already open\";\n>  \t\treturn -EBUSY;\n>  \t}\n>  \n>  \tret = ::open(deviceNode_.c_str(), O_RDWR | O_NONBLOCK);\n>  \tif (ret < 0) {\n>  \t\tret = -errno;\n> -\t\tLOG(V4L2, Error)\n> +\t\tV4L2DEVICE_LOG(Error)\n>  \t\t\t<< \"Failed to open V4L2 device '\" << deviceNode_\n>  \t\t\t<< \"': \" << strerror(-ret);\n>  \t\treturn ret;\n> @@ -271,24 +273,25 @@ int V4L2Device::open()\n>  \tret = ioctl(fd_, VIDIOC_QUERYCAP, &caps_);\n>  \tif (ret < 0) {\n>  \t\tret = -errno;\n> -\t\tLOG(V4L2, Error)\n> +\t\tV4L2DEVICE_LOG(Error)\n>  \t\t\t<< \"Failed to query device capabilities: \"\n>  \t\t\t<< strerror(-ret);\n>  \t\treturn ret;\n>  \t}\n>  \n> -\tLOG(V4L2, Debug)\n> +\tV4L2DEVICE_LOG(Debug)\n>  \t\t<< \"Opened '\" << deviceNode_ << \"' \"\n>  \t\t<< caps_.bus_info() << \": \" << caps_.driver()\n>  \t\t<< \": \" << caps_.card();\n>  \n>  \tif (!caps_.isCapture() && !caps_.isOutput()) {\n> -\t\tLOG(V4L2, Debug) << \"Device is not a supported type\";\n> +\t\tV4L2DEVICE_LOG(Debug) << \"Device is not a supported type\";\n>  \t\treturn -EINVAL;\n>  \t}\n>  \n>  \tif (!caps_.hasStreaming()) {\n> -\t\tLOG(V4L2, Error) << \"Device does not support streaming I/O\";\n> +\t\tV4L2DEVICE_LOG(Error)\n> +\t\t\t<< \"Device does not support streaming I/O\";\n>  \t\treturn -EINVAL;\n>  \t}\n>  \n> @@ -513,13 +516,13 @@ int V4L2Device::requestBuffers(unsigned int count)\n>  \tret = ioctl(fd_, VIDIOC_REQBUFS, &rb);\n>  \tif (ret < 0) {\n>  \t\tret = -errno;\n> -\t\tLOG(V4L2, Error)\n> +\t\tV4L2DEVICE_LOG(Error)\n>  \t\t\t<< \"Unable to request \" << count << \" buffers: \"\n>  \t\t\t<< strerror(-ret);\n>  \t\treturn ret;\n>  \t}\n>  \n> -\tLOG(V4L2, Debug)\n> +\tV4L2DEVICE_LOG(Debug)\n>  \t\t<< deviceNode_ << \":\" << rb.count << \" buffers requested.\";\n>  \n>  \treturn rb.count;\n> @@ -545,7 +548,8 @@ int V4L2Device::exportBuffers(BufferPool *pool)\n>  \n>  \tallocatedBuffers = ret;\n>  \tif (allocatedBuffers < pool->count()) {\n> -\t\tLOG(V4L2, Error) << \"Not enough buffers provided by V4L2Device\";\n> +\t\tV4L2DEVICE_LOG(Error)\n> +\t\t\t<< \"Not enough buffers provided by V4L2Device\";\n>  \t\trequestBuffers(0);\n>  \t\treturn -ENOMEM;\n>  \t}\n> @@ -565,7 +569,7 @@ int V4L2Device::exportBuffers(BufferPool *pool)\n>  \t\tret = ioctl(fd_, VIDIOC_QUERYBUF, &buf);\n>  \t\tif (ret < 0) {\n>  \t\t\tret = -errno;\n> -\t\t\tLOG(V4L2, Error)\n> +\t\t\tV4L2DEVICE_LOG(Error)\n>  \t\t\t\t<< \"Unable to query buffer \" << i << \": \"\n>  \t\t\t\t<< strerror(-ret);\n>  \t\t\tbreak;\n> @@ -583,7 +587,7 @@ int V4L2Device::exportBuffers(BufferPool *pool)\n>  \t\t}\n>  \n>  \t\tif (ret) {\n> -\t\t\tLOG(V4L2, Error) << \"Failed to create plane\";\n> +\t\t\tV4L2DEVICE_LOG(Error) << \"Failed to create plane\";\n>  \t\t\tbreak;\n>  \t\t}\n>  \t}\n> @@ -605,7 +609,7 @@ int V4L2Device::createPlane(Buffer *buffer, unsigned int planeIndex,\n>  \tstruct v4l2_exportbuffer expbuf = {};\n>  \tint ret;\n>  \n> -\tLOG(V4L2, Debug)\n> +\tV4L2DEVICE_LOG(Debug)\n>  \t\t<< \"Buffer \" << buffer->index()\n>  \t\t<< \" plane \" << planeIndex\n>  \t\t<< \": length=\" << length;\n> @@ -618,7 +622,7 @@ int V4L2Device::createPlane(Buffer *buffer, unsigned int planeIndex,\n>  \tret = ioctl(fd_, VIDIOC_EXPBUF, &expbuf);\n>  \tif (ret < 0) {\n>  \t\tret = -errno;\n> -\t\tLOG(V4L2, Error)\n> +\t\tV4L2DEVICE_LOG(Error)\n>  \t\t\t<< \"Failed to export buffer: \" << strerror(-ret);\n>  \t\treturn ret;\n>  \t}\n> @@ -648,13 +652,13 @@ int V4L2Device::importBuffers(BufferPool *pool)\n>  \n>  \tallocatedBuffers = ret;\n>  \tif (allocatedBuffers < pool->count()) {\n> -\t\tLOG(V4L2, Error)\n> +\t\tV4L2DEVICE_LOG(Error)\n>  \t\t\t<< \"Not enough buffers provided by V4L2Device\";\n>  \t\trequestBuffers(0);\n>  \t\treturn -ENOMEM;\n>  \t}\n>  \n> -\tLOG(V4L2, Debug) << \"Device using an externally provided pool\";\n> +\tV4L2DEVICE_LOG(Debug) << \"Device using an externally provided pool\";\n>  \tbufferPool_ = pool;\n>  \n>  \treturn 0;\n> @@ -665,7 +669,7 @@ int V4L2Device::importBuffers(BufferPool *pool)\n>   */\n>  int V4L2Device::releaseBuffers()\n>  {\n> -\tLOG(V4L2, Debug) << \"Releasing bufferPool\";\n> +\tV4L2DEVICE_LOG(Debug) << \"Releasing bufferPool\";\n>  \n>  \trequestBuffers(0);\n>  \tbufferPool_ = nullptr;\n> @@ -715,12 +719,12 @@ int V4L2Device::queueBuffer(Buffer *buffer)\n>  \t\tbuf.m.planes = planes;\n>  \t}\n>  \n> -\tLOG(V4L2, Debug) << \"Queueing buffer \" << buf.index;\n> +\tV4L2DEVICE_LOG(Debug) << \"Queueing buffer \" << buf.index;\n>  \n>  \tret = ioctl(fd_, VIDIOC_QBUF, &buf);\n>  \tif (ret < 0) {\n>  \t\tret = -errno;\n> -\t\tLOG(V4L2, Error)\n> +\t\tV4L2DEVICE_LOG(Error)\n>  \t\t\t<< \"Failed to queue buffer \" << buf.index << \": \"\n>  \t\t\t<< strerror(-ret);\n>  \t\treturn ret;\n> @@ -757,7 +761,7 @@ Buffer *V4L2Device::dequeueBuffer()\n>  \tret = ioctl(fd_, VIDIOC_DQBUF, &buf);\n>  \tif (ret < 0) {\n>  \t\tret = -errno;\n> -\t\tLOG(V4L2, Error)\n> +\t\tV4L2DEVICE_LOG(Error)\n>  \t\t\t<< \"Failed to dequeue buffer: \" << strerror(-ret);\n>  \t\treturn nullptr;\n>  \t}\n> @@ -793,7 +797,7 @@ void V4L2Device::bufferAvailable(EventNotifier *notifier)\n>  \tif (!buffer)\n>  \t\treturn;\n>  \n> -\tLOG(V4L2, Debug) << \"Buffer \" << buffer->index() << \" is available\";\n> +\tV4L2DEVICE_LOG(Debug) << \"Buffer \" << buffer->index() << \" is available\";\n>  \n>  \t/* Notify anyone listening to the device. */\n>  \tbufferReady.emit(buffer);\n> @@ -819,7 +823,7 @@ int V4L2Device::streamOn()\n>  \tret = ioctl(fd_, VIDIOC_STREAMON, &bufferType_);\n>  \tif (ret < 0) {\n>  \t\tret = -errno;\n> -\t\tLOG(V4L2, Error)\n> +\t\tV4L2DEVICE_LOG(Error)\n>  \t\t\t<< \"Failed to start streaming: \" << strerror(-ret);\n>  \t\treturn ret;\n>  \t}\n> @@ -841,7 +845,7 @@ int V4L2Device::streamOff()\n>  \tret = ioctl(fd_, VIDIOC_STREAMOFF, &bufferType_);\n>  \tif (ret < 0) {\n>  \t\tret = -errno;\n> -\t\tLOG(V4L2, Error)\n> +\t\tV4L2DEVICE_LOG(Error)\n>  \t\t\t<< \"Failed to stop streaming: \" << strerror(-ret);\n>  \t\treturn ret;\n>  \t}","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D82DF6101F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  8 Feb 2019 18:33:33 +0100 (CET)","from pendragon.ideasonboard.com (d51A4137F.access.telenet.be\n\t[81.164.19.127])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7D5D8F9;\n\tFri,  8 Feb 2019 18:33:33 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1549647213;\n\tbh=CaU7wK70b+E5hRSH2xQhmISCB/61nqtfvSdkigKjn50=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WtsLPamUaERHqnwBU8iuwCWlVwCX6DuQYEqba11DyPzlEr8V6SUajVVFU4kGP6EMB\n\tR/f7MYpX3XATurdb6ajRbGV5WziHrBn9F/6lPNygUQ69Zrd+MMQvgaDc1tbxAyI/nG\n\tl5kSnamNViLwbKMNkrmsHDr/kqsncyAFcp3feVj0=","Date":"Fri, 8 Feb 2019 19:33:31 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Message-ID":"<20190208173331.GJ4562@pendragon.ideasonboard.com>","References":"<20190207212119.30299-1-kieran.bingham@ideasonboard.com>\n\t<20190207212119.30299-6-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190207212119.30299-6-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 5/5] libcamera: v4l2_device: Provide\n\tV4L2 Log helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 08 Feb 2019 17:33:34 -0000"}},{"id":782,"web_url":"https://patchwork.libcamera.org/comment/782/","msgid":"<b0318a3f-e103-2dc7-c0b9-a292a38c72bd@ideasonboard.com>","date":"2019-02-11T11:59:38","subject":"Re: [libcamera-devel] [PATCH 5/5] libcamera: v4l2_device: Provide\n\tV4L2 Log helper","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 08/02/2019 17:33, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Thu, Feb 07, 2019 at 09:21:19PM +0000, Kieran Bingham wrote:\n>> Add a V4L2DEVICE_LOG Macro helper to prepend the V4L2 Video Device node to\n>> every log output.  This is particularly useful when more than one V4L2Device is\n>> utilised in the system.\n>>\n>> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> \n> I've sent a patch that adds a Loggable class, it should cover your use\n> case in a more generic way.\n\nSure, I'll just drop this.\n--\nKieran\n\n\n> \n>> ---\n>>  src/libcamera/v4l2_device.cpp | 48 +++++++++++++++++++----------------\n>>  1 file changed, 26 insertions(+), 22 deletions(-)\n>>\n>> diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\n>> index c2e4d0ea8db2..ce977613ff20 100644\n>> --- a/src/libcamera/v4l2_device.cpp\n>> +++ b/src/libcamera/v4l2_device.cpp\n>> @@ -28,6 +28,8 @@ namespace libcamera {\n>>  \n>>  LOG_DEFINE_CATEGORY(V4L2)\n>>  \n>> +#define V4L2DEVICE_LOG(severity) LOG(V4L2, severity) << deviceNode_ << \": \"\n>> +\n>>  /**\n>>   * \\struct V4L2Capability\n>>   * \\brief struct v4l2_capability object wrapper and helpers\n>> @@ -254,14 +256,14 @@ int V4L2Device::open()\n>>  \tint ret;\n>>  \n>>  \tif (isOpen()) {\n>> -\t\tLOG(V4L2, Error) << \"Device already open\";\n>> +\t\tV4L2DEVICE_LOG(Error) << \"Device already open\";\n>>  \t\treturn -EBUSY;\n>>  \t}\n>>  \n>>  \tret = ::open(deviceNode_.c_str(), O_RDWR | O_NONBLOCK);\n>>  \tif (ret < 0) {\n>>  \t\tret = -errno;\n>> -\t\tLOG(V4L2, Error)\n>> +\t\tV4L2DEVICE_LOG(Error)\n>>  \t\t\t<< \"Failed to open V4L2 device '\" << deviceNode_\n>>  \t\t\t<< \"': \" << strerror(-ret);\n>>  \t\treturn ret;\n>> @@ -271,24 +273,25 @@ int V4L2Device::open()\n>>  \tret = ioctl(fd_, VIDIOC_QUERYCAP, &caps_);\n>>  \tif (ret < 0) {\n>>  \t\tret = -errno;\n>> -\t\tLOG(V4L2, Error)\n>> +\t\tV4L2DEVICE_LOG(Error)\n>>  \t\t\t<< \"Failed to query device capabilities: \"\n>>  \t\t\t<< strerror(-ret);\n>>  \t\treturn ret;\n>>  \t}\n>>  \n>> -\tLOG(V4L2, Debug)\n>> +\tV4L2DEVICE_LOG(Debug)\n>>  \t\t<< \"Opened '\" << deviceNode_ << \"' \"\n>>  \t\t<< caps_.bus_info() << \": \" << caps_.driver()\n>>  \t\t<< \": \" << caps_.card();\n>>  \n>>  \tif (!caps_.isCapture() && !caps_.isOutput()) {\n>> -\t\tLOG(V4L2, Debug) << \"Device is not a supported type\";\n>> +\t\tV4L2DEVICE_LOG(Debug) << \"Device is not a supported type\";\n>>  \t\treturn -EINVAL;\n>>  \t}\n>>  \n>>  \tif (!caps_.hasStreaming()) {\n>> -\t\tLOG(V4L2, Error) << \"Device does not support streaming I/O\";\n>> +\t\tV4L2DEVICE_LOG(Error)\n>> +\t\t\t<< \"Device does not support streaming I/O\";\n>>  \t\treturn -EINVAL;\n>>  \t}\n>>  \n>> @@ -513,13 +516,13 @@ int V4L2Device::requestBuffers(unsigned int count)\n>>  \tret = ioctl(fd_, VIDIOC_REQBUFS, &rb);\n>>  \tif (ret < 0) {\n>>  \t\tret = -errno;\n>> -\t\tLOG(V4L2, Error)\n>> +\t\tV4L2DEVICE_LOG(Error)\n>>  \t\t\t<< \"Unable to request \" << count << \" buffers: \"\n>>  \t\t\t<< strerror(-ret);\n>>  \t\treturn ret;\n>>  \t}\n>>  \n>> -\tLOG(V4L2, Debug)\n>> +\tV4L2DEVICE_LOG(Debug)\n>>  \t\t<< deviceNode_ << \":\" << rb.count << \" buffers requested.\";\n>>  \n>>  \treturn rb.count;\n>> @@ -545,7 +548,8 @@ int V4L2Device::exportBuffers(BufferPool *pool)\n>>  \n>>  \tallocatedBuffers = ret;\n>>  \tif (allocatedBuffers < pool->count()) {\n>> -\t\tLOG(V4L2, Error) << \"Not enough buffers provided by V4L2Device\";\n>> +\t\tV4L2DEVICE_LOG(Error)\n>> +\t\t\t<< \"Not enough buffers provided by V4L2Device\";\n>>  \t\trequestBuffers(0);\n>>  \t\treturn -ENOMEM;\n>>  \t}\n>> @@ -565,7 +569,7 @@ int V4L2Device::exportBuffers(BufferPool *pool)\n>>  \t\tret = ioctl(fd_, VIDIOC_QUERYBUF, &buf);\n>>  \t\tif (ret < 0) {\n>>  \t\t\tret = -errno;\n>> -\t\t\tLOG(V4L2, Error)\n>> +\t\t\tV4L2DEVICE_LOG(Error)\n>>  \t\t\t\t<< \"Unable to query buffer \" << i << \": \"\n>>  \t\t\t\t<< strerror(-ret);\n>>  \t\t\tbreak;\n>> @@ -583,7 +587,7 @@ int V4L2Device::exportBuffers(BufferPool *pool)\n>>  \t\t}\n>>  \n>>  \t\tif (ret) {\n>> -\t\t\tLOG(V4L2, Error) << \"Failed to create plane\";\n>> +\t\t\tV4L2DEVICE_LOG(Error) << \"Failed to create plane\";\n>>  \t\t\tbreak;\n>>  \t\t}\n>>  \t}\n>> @@ -605,7 +609,7 @@ int V4L2Device::createPlane(Buffer *buffer, unsigned int planeIndex,\n>>  \tstruct v4l2_exportbuffer expbuf = {};\n>>  \tint ret;\n>>  \n>> -\tLOG(V4L2, Debug)\n>> +\tV4L2DEVICE_LOG(Debug)\n>>  \t\t<< \"Buffer \" << buffer->index()\n>>  \t\t<< \" plane \" << planeIndex\n>>  \t\t<< \": length=\" << length;\n>> @@ -618,7 +622,7 @@ int V4L2Device::createPlane(Buffer *buffer, unsigned int planeIndex,\n>>  \tret = ioctl(fd_, VIDIOC_EXPBUF, &expbuf);\n>>  \tif (ret < 0) {\n>>  \t\tret = -errno;\n>> -\t\tLOG(V4L2, Error)\n>> +\t\tV4L2DEVICE_LOG(Error)\n>>  \t\t\t<< \"Failed to export buffer: \" << strerror(-ret);\n>>  \t\treturn ret;\n>>  \t}\n>> @@ -648,13 +652,13 @@ int V4L2Device::importBuffers(BufferPool *pool)\n>>  \n>>  \tallocatedBuffers = ret;\n>>  \tif (allocatedBuffers < pool->count()) {\n>> -\t\tLOG(V4L2, Error)\n>> +\t\tV4L2DEVICE_LOG(Error)\n>>  \t\t\t<< \"Not enough buffers provided by V4L2Device\";\n>>  \t\trequestBuffers(0);\n>>  \t\treturn -ENOMEM;\n>>  \t}\n>>  \n>> -\tLOG(V4L2, Debug) << \"Device using an externally provided pool\";\n>> +\tV4L2DEVICE_LOG(Debug) << \"Device using an externally provided pool\";\n>>  \tbufferPool_ = pool;\n>>  \n>>  \treturn 0;\n>> @@ -665,7 +669,7 @@ int V4L2Device::importBuffers(BufferPool *pool)\n>>   */\n>>  int V4L2Device::releaseBuffers()\n>>  {\n>> -\tLOG(V4L2, Debug) << \"Releasing bufferPool\";\n>> +\tV4L2DEVICE_LOG(Debug) << \"Releasing bufferPool\";\n>>  \n>>  \trequestBuffers(0);\n>>  \tbufferPool_ = nullptr;\n>> @@ -715,12 +719,12 @@ int V4L2Device::queueBuffer(Buffer *buffer)\n>>  \t\tbuf.m.planes = planes;\n>>  \t}\n>>  \n>> -\tLOG(V4L2, Debug) << \"Queueing buffer \" << buf.index;\n>> +\tV4L2DEVICE_LOG(Debug) << \"Queueing buffer \" << buf.index;\n>>  \n>>  \tret = ioctl(fd_, VIDIOC_QBUF, &buf);\n>>  \tif (ret < 0) {\n>>  \t\tret = -errno;\n>> -\t\tLOG(V4L2, Error)\n>> +\t\tV4L2DEVICE_LOG(Error)\n>>  \t\t\t<< \"Failed to queue buffer \" << buf.index << \": \"\n>>  \t\t\t<< strerror(-ret);\n>>  \t\treturn ret;\n>> @@ -757,7 +761,7 @@ Buffer *V4L2Device::dequeueBuffer()\n>>  \tret = ioctl(fd_, VIDIOC_DQBUF, &buf);\n>>  \tif (ret < 0) {\n>>  \t\tret = -errno;\n>> -\t\tLOG(V4L2, Error)\n>> +\t\tV4L2DEVICE_LOG(Error)\n>>  \t\t\t<< \"Failed to dequeue buffer: \" << strerror(-ret);\n>>  \t\treturn nullptr;\n>>  \t}\n>> @@ -793,7 +797,7 @@ void V4L2Device::bufferAvailable(EventNotifier *notifier)\n>>  \tif (!buffer)\n>>  \t\treturn;\n>>  \n>> -\tLOG(V4L2, Debug) << \"Buffer \" << buffer->index() << \" is available\";\n>> +\tV4L2DEVICE_LOG(Debug) << \"Buffer \" << buffer->index() << \" is available\";\n>>  \n>>  \t/* Notify anyone listening to the device. */\n>>  \tbufferReady.emit(buffer);\n>> @@ -819,7 +823,7 @@ int V4L2Device::streamOn()\n>>  \tret = ioctl(fd_, VIDIOC_STREAMON, &bufferType_);\n>>  \tif (ret < 0) {\n>>  \t\tret = -errno;\n>> -\t\tLOG(V4L2, Error)\n>> +\t\tV4L2DEVICE_LOG(Error)\n>>  \t\t\t<< \"Failed to start streaming: \" << strerror(-ret);\n>>  \t\treturn ret;\n>>  \t}\n>> @@ -841,7 +845,7 @@ int V4L2Device::streamOff()\n>>  \tret = ioctl(fd_, VIDIOC_STREAMOFF, &bufferType_);\n>>  \tif (ret < 0) {\n>>  \t\tret = -errno;\n>> -\t\tLOG(V4L2, Error)\n>> +\t\tV4L2DEVICE_LOG(Error)\n>>  \t\t\t<< \"Failed to stop streaming: \" << strerror(-ret);\n>>  \t\treturn ret;\n>>  \t}\n>","headers":{"Return-Path":"<kieran.bingham@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4A709610B2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 11 Feb 2019 12:59:41 +0100 (CET)","from [192.168.0.21]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D8B182E4;\n\tMon, 11 Feb 2019 12:59:40 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1549886381;\n\tbh=JDEm3h0SRxTfbZUQZlUfMV+9cSipal0Ph2EqqrbBMTQ=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=oFCDm6D7Qpfx/AcDBEoY4HZxQP6AQ5825oNPLoG832dwoJRJP+vY4fJdgeyem+rr2\n\tAIZmLUfgbaW5x42etNJDX7ap9r1GBAOudwNr34sPgdR7ZqFoAOQsfluJoxStPC97aX\n\t6wpNjQI4tTH+yORUwcbYq0+tJLqBKMZ7uQp2xZjg=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","References":"<20190207212119.30299-1-kieran.bingham@ideasonboard.com>\n\t<20190207212119.30299-6-kieran.bingham@ideasonboard.com>\n\t<20190208173331.GJ4562@pendragon.ideasonboard.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<b0318a3f-e103-2dc7-c0b9-a292a38c72bd@ideasonboard.com>","Date":"Mon, 11 Feb 2019 11:59:38 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.4.0","MIME-Version":"1.0","In-Reply-To":"<20190208173331.GJ4562@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 5/5] libcamera: v4l2_device: Provide\n\tV4L2 Log helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 11 Feb 2019 11:59:41 -0000"}}]