{"id":536,"url":"https://patchwork.libcamera.org/api/patches/536/?format=json","web_url":"https://patchwork.libcamera.org/patch/536/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190206060818.13907-22-laurent.pinchart@ideasonboard.com>","date":"2019-02-06T06:08:12","name":"[libcamera-devel,21/27] libcamera: pipeline: vimc: Set a default format","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"e5777e558477772b152355d927818f3d3e4b729a","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/536/mbox/","series":[{"id":170,"url":"https://patchwork.libcamera.org/api/series/170/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=170","date":"2019-02-06T06:07:51","name":"Capture frames throught requests","version":1,"mbox":"https://patchwork.libcamera.org/series/170/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/536/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/536/checks/","tags":{},"headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9796D61022\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  6 Feb 2019 07:08:28 +0100 (CET)","from pendragon.ideasonboard.com (d51A4137F.access.telenet.be\n\t[81.164.19.127])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 42FA62D8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  6 Feb 2019 07:08:28 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1549433308;\n\tbh=OxR2dVUYzTcPjktGWfvQKEVJbM1cGNhPqnsRzEdtwg8=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=jj9MSK/vMVxzcRLn8on8at3AKH4PkheOlrbOoL1qBLCAkF74ULZc64Xzm45AwzHs+\n\telNWsgrlMqq6AZk+7uLd0ihJwQRqtJGpAFDyR9TAfM4W3C4Zab/b8DomqfDjw0v4ij\n\tPBSmXMSRIJqEDgHTLK/bXL14vOE1lmDi2T0AaFRk=","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Wed,  6 Feb 2019 08:08:12 +0200","Message-Id":"<20190206060818.13907-22-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.19.2","In-Reply-To":"<20190206060818.13907-1-laurent.pinchart@ideasonboard.com>","References":"<20190206060818.13907-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 21/27] libcamera: pipeline: vimc: Set a\n\tdefault format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Wed, 06 Feb 2019 06:08:30 -0000"},"content":"From: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\nPick a default format for the one stream in a vimc camera. This is\njust a starting point to define a good default format for the vimc\ncamera, and is expected to evolve over time as the capabilities of the\nlibrary grows.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/vimc.cpp | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\nindex ea6f28c64cc0..9c0406bef9dc 100644\n--- a/src/libcamera/pipeline/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc.cpp\n@@ -67,7 +67,11 @@ PipeHandlerVimc::streamConfiguration(Camera *camera,\n \n \tStreamConfiguration config{};\n \n-\tLOG(VIMC, Info) << \"TODO: Return a good default format\";\n+\tLOG(VIMC, Debug) << \"Retrieving default format\";\n+\tconfig.width = 640;\n+\tconfig.height = 480;\n+\tconfig.pixelFormat = V4L2_PIX_FMT_RGB24;\n+\tconfig.bufferCount = 4;\n \n \tconfigs[&stream_] = config;\n \n","prefixes":["libcamera-devel","21/27"]}