[{"id":761,"web_url":"https://patchwork.libcamera.org/comment/761/","msgid":"<20190205183038.GD32622@bigcity.dyn.berto.se>","date":"2019-02-05T18:30:38","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: v4l2_device: Add\n\tmethod parameters comment","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your patch.\n\nOn 2019-02-05 18:10:08 +0100, Jacopo Mondi wrote:\n> Please the doxygen overlord!\n\nI would use a slightly more descriptive commit message. However I'm sure \nthe Doxygen overloard is happy for the attention :-)\n\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/v4l2_device.cpp | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\n> index 1823457..3cecfc8 100644\n> --- a/src/libcamera/v4l2_device.cpp\n> +++ b/src/libcamera/v4l2_device.cpp\n> @@ -329,6 +329,8 @@ void V4L2Device::close()\n> \n> /**\n> * \\brief Retrieve the image format set on the V4L2 device\n> + * \\param[out] format The image format applied on the device\n> + *\n> * \\return 0 for success, a negative error code otherwise\n> */\n> int V4L2Device::getFormat(V4L2DeviceFormat *format)\n> @@ -339,6 +341,7 @@ int V4L2Device::getFormat(V4L2DeviceFormat *format)\n> \n> /**\n> * \\brief Configure an image format on the V4L2 device\n> + * \\param[in] format format The image format to apply to the device\n\ns/format format/format/\n\nWith these two issues fixed,\n\nReviewed-by: Niklas Söderlund \n\n> *\n> * Apply the supplied \\a format to the device, and return the actually\n> * applied format parameters, as \\ref V4L2Device::getFormat would do.\n> -- \n> 2.20.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 74ABD60B2D\n\tfor ;\n\tTue, 5 Feb 2019 19:30:41 +0100 (CET)","by mail-lj1-x244.google.com with SMTP id t9-v6so3760827ljh.6\n\tfor ;\n\tTue, 05 Feb 2019 10:30:41 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\te5-v6sm3368723ljj.91.2019.02.05.10.30.39\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 05 Feb 2019 10:30:39 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=8irha+lUG8gtrqyJGhLa3ghj1Ma+viuL/UhFVBZYmpk=;\n\tb=ytPfkj37WolLxaxoGoGYcEfj5ASkBMX/87BRihLRx3McyBp/d6WSSM5VhaOmKWx9ha\n\tP6gT9zhKzUvmhgTHngc6awN6vShJyN3wMDBSSnNkE2EP3UWUZg55cBfWk0mE+btZAKXo\n\tY5ZXP7vAV+UHnVEdaAjBe/t2gkj3zE2l+MzXssK1pKqc1+F0u+uqidonD4dGO+NGPnyq\n\tNgQBjSLVncI7EWpKWpj/MWcKaCn8DRFG6UeQBZ8ptGLN7xGT6/WQxMefA8DU8g/YYI/k\n\tPXmhFxAASvtEN1juauzfQI6l/2f1pWu/9Cet286b/J970LEmXbcvmkmhOjH8IflQjDTQ\n\tyvxA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=8irha+lUG8gtrqyJGhLa3ghj1Ma+viuL/UhFVBZYmpk=;\n\tb=ULBBcImqSuzlZU7mHBwHUZpOSy0b/tP/4qn9s8JYOExbgf7OLNO/TEVhQeHoHWoQQ5\n\tAFr5gEjiXdqteQZiqHbkFodlqmh3jHpa8aEpsA/zV0a1cCS0udN5wjiO6yOcAnpfnz/N\n\tOPRkMQHfk3yBLaWkV7q3/GSIEWamU6uNA+xZ5AvaZJhYdprh4uwLmJZL+74ljcKhvfAd\n\tD/hiUXrZFUItYPRGeciF0HcA79VMXS9T5pY54MsGLJ67NasiCoUzKt2U9nxj2pAMt6W5\n\tFYMlEN4gSzDmGOKfWDOChUT08FYQxUqvVrotymlYf1X3IbviZk0NcVT3FVLZCnNpfbS5\n\tEdFg==","X-Gm-Message-State":"AHQUAuZ5v6Zc732k+SdUZA4dHEOLvG39ZUpPGXKVUfMFBq33wlPlt25v\n\tWp/p00CEQcclLzHRnnzZPJYjPA==","X-Google-Smtp-Source":"AHgI3IZwzVJgaVO7yNYC0yOn5aQViIzLOJ8k/WkqEqgwFzZZVxa1sa/MYy5jdHGAt8VUhlr/GtmMMA==","X-Received":"by 2002:a2e:2407:: with SMTP id\n\tk7-v6mr228039ljk.59.1549391440445; \n\tTue, 05 Feb 2019 10:30:40 -0800 (PST)","Date":"Tue, 5 Feb 2019 19:30:38 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190205183038.GD32622@bigcity.dyn.berto.se>","References":"<20190205171010.1356-1-jacopo@jmondi.org>\n\t<20190205171010.1356-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190205171010.1356-2-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: v4l2_device: Add\n\tmethod parameters comment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 05 Feb 2019 18:30:41 -0000"}}]