[{"id":757,"web_url":"https://patchwork.libcamera.org/comment/757/","msgid":"<9f7c2abe-fa5a-d5fa-566d-847d7798896c@ideasonboard.com>","date":"2019-02-04T19:08:25","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: streams: extend stream\n\tconfiguration with buffer count","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nOn 04/02/2019 19:55, Niklas Söderlund wrote:\n> The camera needs to be configured with the number of buffers to use to\n> satisfy the application use-case. While it's free for the application to> request any number of buffers the pipeline needs to take the Linux\n> drivers constraints into consideration.\n\nSome minor rewording, it was easier to write out the paragraph: This is\nhow I would phrase it:\n\n\nThe camera needs to be configured with the number of buffers required to\nsatisfy the applications use case. While the application can request any\nnumber of buffers, the pipeline must take the constraints of the Linux\ndriver into consideration.\n\n\n\n\n\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Kieran Bingham \n\n\n\n> ---\n> include/libcamera/stream.h | 2 ++\n> src/libcamera/stream.cpp | 5 +++++\n> 2 files changed, 7 insertions(+)\n> \n> diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\n> index 4b24dd841dd64b64..890678360ee87fd7 100644\n> --- a/include/libcamera/stream.h\n> +++ b/include/libcamera/stream.h\n> @@ -17,6 +17,8 @@ struct StreamConfiguration {\n> \tunsigned int width;\n> \tunsigned int height;\n> \tunsigned int pixelFormat;\n> +\n> +\tunsigned int bufferCount;\n> };\n> \n> } /* namespace libcamera */\n> diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> index b0b4efe39c81e747..5ebdce9acdbd3560 100644\n> --- a/src/libcamera/stream.cpp\n> +++ b/src/libcamera/stream.cpp\n> @@ -73,4 +73,9 @@ namespace libcamera {\n> * format described in V4L2 using the V4L2_PIX_FMT_* definitions.\n> */\n> \n> +/**\n> + * \\var StreamConfiguration::bufferCount\n> + * \\brief Number of buffers to allocate for the stream\n\nThis is fine - but do we need to say this is a 'request'?:\n\n\"Requested number of buffers to allocate for the stream\"\n\nEither way is fine with me.\n\n--\nKieran\n\n\n> + */\n> +\n> } /* namespace libcamera */\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 93CBE60B2D\n\tfor ;\n\tMon, 4 Feb 2019 20:08:29 +0100 (CET)","from [192.168.0.245] (d51A4137F.access.telenet.be [81.164.19.127])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 089EB41;\n\tMon, 4 Feb 2019 20:08:28 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1549307309;\n\tbh=vdnIEk/qI+qQPWB50RitolUpMQdI6YmhyEHPfvUo/5w=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=WEwGioFwnaUs4VCBvGu5u7al9jGCvJjJ3TjZbDl6dHvGN6uq4Yo/ITtmmp0Rtrytm\n\tqSzrNVAaNhDbdaTfC+yoQGHi0Bsl0PxDL/bM8AhZ2oOb5IXPxYyeeVfPOJKEK6f6V8\n\tYv1ef9JXktHFjo9OOYZIfwCG5lbsPjWqJYohtBSM=","Reply-To":"kieran.bingham@ideasonboard.com","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20190204185521.23471-1-niklas.soderlund@ragnatech.se>\n\t<20190204185521.23471-2-niklas.soderlund@ragnatech.se>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<9f7c2abe-fa5a-d5fa-566d-847d7798896c@ideasonboard.com>","Date":"Mon, 4 Feb 2019 20:08:25 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.4.0","MIME-Version":"1.0","In-Reply-To":"<20190204185521.23471-2-niklas.soderlund@ragnatech.se>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: streams: extend stream\n\tconfiguration with buffer count","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 04 Feb 2019 19:08:29 -0000"}},{"id":759,"web_url":"https://patchwork.libcamera.org/comment/759/","msgid":"<20190204193121.GB16152@bigcity.dyn.berto.se>","date":"2019-02-04T19:31:21","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: streams: extend stream\n\tconfiguration with buffer count","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nThanks for your feedback.\n\nOn 2019-02-04 20:08:25 +0100, Kieran Bingham wrote:\n> Hi Niklas,\n> \n> On 04/02/2019 19:55, Niklas Söderlund wrote:\n> > The camera needs to be configured with the number of buffers to use to\n> > satisfy the application use-case. While it's free for the application to> request any number of buffers the pipeline needs to take the Linux\n> > drivers constraints into consideration.\n> \n> Some minor rewording, it was easier to write out the paragraph: This is\n> how I would phrase it:\n> \n> \n> The camera needs to be configured with the number of buffers required to\n> satisfy the applications use case. While the application can request any\n> number of buffers, the pipeline must take the constraints of the Linux\n> driver into consideration.\n> \n> \n> \n> \n> \n> > \n> > Signed-off-by: Niklas Söderlund \n> \n> Reviewed-by: Kieran Bingham \n\nI incorporated your comments to this patch and merged this series to \nmaster.\n\n> \n> \n> \n> > ---\n> > include/libcamera/stream.h | 2 ++\n> > src/libcamera/stream.cpp | 5 +++++\n> > 2 files changed, 7 insertions(+)\n> > \n> > diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\n> > index 4b24dd841dd64b64..890678360ee87fd7 100644\n> > --- a/include/libcamera/stream.h\n> > +++ b/include/libcamera/stream.h\n> > @@ -17,6 +17,8 @@ struct StreamConfiguration {\n> > \tunsigned int width;\n> > \tunsigned int height;\n> > \tunsigned int pixelFormat;\n> > +\n> > +\tunsigned int bufferCount;\n> > };\n> > \n> > } /* namespace libcamera */\n> > diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> > index b0b4efe39c81e747..5ebdce9acdbd3560 100644\n> > --- a/src/libcamera/stream.cpp\n> > +++ b/src/libcamera/stream.cpp\n> > @@ -73,4 +73,9 @@ namespace libcamera {\n> > * format described in V4L2 using the V4L2_PIX_FMT_* definitions.\n> > */\n> > \n> > +/**\n> > + * \\var StreamConfiguration::bufferCount\n> > + * \\brief Number of buffers to allocate for the stream\n> \n> This is fine - but do we need to say this is a 'request'?:\n> \n> \"Requested number of buffers to allocate for the stream\"\n> \n> Either way is fine with me.\n> \n> --\n> Kieran\n> \n> \n> > + */\n> > +\n> > } /* namespace libcamera */\n> > \n> \n> -- \n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6091260DB4\n\tfor ;\n\tMon, 4 Feb 2019 20:31:24 +0100 (CET)","by mail-lj1-x243.google.com with SMTP id v1-v6so929046ljd.0\n\tfor ;\n\tMon, 04 Feb 2019 11:31:24 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tm199sm1064414lfg.16.2019.02.04.11.31.22\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 04 Feb 2019 11:31:22 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=SX/OJ88n2f6U7Anqh8qZDLiVf2YNlra/te32kfrK0Wo=;\n\tb=jyomfEHiz2ZY0tSVn1Mpf1LU5iCipZd9J66Ilrgzgk0v9vexlE6EDhhuB3GncAHSYL\n\tIvdjT7r/K772k4uzh4Jp2N8M5d6hfiHLs0lEgOtcqBoVoGj2/STV79dcHgNzT12iO7Ye\n\tCzQpjZPruWhbjs34KvQ4MtwEYvC+ZNAgChwRxYH5pMQWRzw/j0jbDJRb5G7wzNWNpxxb\n\twuWc9sUseGGnhhNivNBvDzDdv4S77czEiEyzJ4LRshJllms3ldkhlPWV8BAM70V6fZqA\n\tICb7RhFWq3r97s0JDhGqyZa5peUxs3HnMsvFTBt2UJgkf5nnqZ9tcF0dmemgLmUpiOo+\n\tDgag==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=SX/OJ88n2f6U7Anqh8qZDLiVf2YNlra/te32kfrK0Wo=;\n\tb=jbjkSb3WWra0/ClXdmXcE3gYnhY1/FQN3x3sJgifwE6wNQ2SOZGJnDSud86JoGTx1g\n\tLXSp7a+rfyAJJceiuRoywdaQutlcn045GZiY3KqnpOkl1kGZr6VEf/0DKp8AZ8bO3LAR\n\trIw2ONZLpDEGA0yuaMwzAdCbjf3ywAH0Ecc1ylNxYc+GGrsYwct8sSqCnSKcbsdT5X3z\n\tJAeuRbJgUuydBB0ZcGFVd2LXRp7POZyh49w0OzbaKeMuJrK8RZF4/aQCTim7oG9zlry8\n\tf7s7Nez5Kx10W9HKXH7Ye52+lCpaqL7oVvPrDlqm1bSoZWKztoXb4pyzG+kRQzFKvdWJ\n\tBalA==","X-Gm-Message-State":"AHQUAuYMeYN/CQ2hK2vMqbDPpvvufr5PWEdaNN7ZBM49L/MDj/yUfxCx\n\tricYpX3eGBUtL4krH9bn1MOA+WtPWDE=","X-Google-Smtp-Source":"AHgI3IamDeMkI5OPJTaB7T71zqOMW60OvIkoOFV4FiYxb9qd5COwb4gnRp0Ooo1ivWOfdz6ZfExGzg==","X-Received":"by 2002:a05:651c:c8:: with SMTP id 8mr581295ljr.53.1549308683368;\n\tMon, 04 Feb 2019 11:31:23 -0800 (PST)","Date":"Mon, 4 Feb 2019 20:31:21 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190204193121.GB16152@bigcity.dyn.berto.se>","References":"<20190204185521.23471-1-niklas.soderlund@ragnatech.se>\n\t<20190204185521.23471-2-niklas.soderlund@ragnatech.se>\n\t<9f7c2abe-fa5a-d5fa-566d-847d7798896c@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<9f7c2abe-fa5a-d5fa-566d-847d7798896c@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: streams: extend stream\n\tconfiguration with buffer count","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 04 Feb 2019 19:31:24 -0000"}}]