[{"id":754,"web_url":"https://patchwork.libcamera.org/comment/754/","msgid":"<20190204182505.GA4561@pendragon.ideasonboard.com>","date":"2019-02-04T18:25:05","subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_device: Construct\n\tfrom MediaEntity*","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Mon, Feb 04, 2019 at 04:56:05PM +0100, Jacopo Mondi wrote:\n> The V4L2Device constructor wanted a \"const MediaEntity &\", while\n> entities are usually retrieved by pointer before being used to construct\n> a V4L2Device. Change the constructor argument to \"MediaEntity *\".\n\nA non-const pointer hints that the function could keep a reference,\nmodify the object instance and/or accept a NULL parameter. None of this\nis true in this case. Do we really need to pass by pointer ? Shouldn't\nit then be at least a const pointer ?\n\n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/include/v4l2_device.h | 2 +-\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> src/libcamera/pipeline/uvcvideo.cpp | 2 +-\n> src/libcamera/v4l2_device.cpp | 4 ++--\n> 4 files changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/libcamera/include/v4l2_device.h b/src/libcamera/include/v4l2_device.h\n> index 4ff48fb..1067e45 100644\n> --- a/src/libcamera/include/v4l2_device.h\n> +++ b/src/libcamera/include/v4l2_device.h\n> @@ -72,7 +72,7 @@ class V4L2Device\n> {\n> public:\n> \texplicit V4L2Device(const std::string &deviceNode);\n> -\texplicit V4L2Device(const MediaEntity &entity);\n> +\texplicit V4L2Device(MediaEntity *entity);\n> \tV4L2Device(const V4L2Device &) = delete;\n> \t~V4L2Device();\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 7823bbb..fa3c522 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -182,7 +182,7 @@ V4L2Device *PipelineHandlerIPU3::createVideoDevice(unsigned int id)\n> \tif (!cio2)\n> \t\treturn nullptr;\n> \n> -\tV4L2Device *dev = new V4L2Device(*cio2);\n> +\tV4L2Device *dev = new V4L2Device(cio2);\n> \tif (dev->open()) {\n> \t\tdelete dev;\n> \t\treturn nullptr;\n> diff --git a/src/libcamera/pipeline/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo.cpp\n> index 821e4c2..e31816b 100644\n> --- a/src/libcamera/pipeline/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo.cpp\n> @@ -91,7 +91,7 @@ bool PipelineHandlerUVC::match(DeviceEnumerator *enumerator)\n> \n> \tfor (MediaEntity *entity : media_->entities()) {\n> \t\tif (entity->flags() & MEDIA_ENT_FL_DEFAULT) {\n> -\t\t\tvideo_ = new V4L2Device(*entity);\n> +\t\t\tvideo_ = new V4L2Device(entity);\n> \t\t\tbreak;\n> \t\t}\n> \t}\n> diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\n> index 4d1f76b..61db7f6 100644\n> --- a/src/libcamera/v4l2_device.cpp\n> +++ b/src/libcamera/v4l2_device.cpp\n> @@ -169,8 +169,8 @@ V4L2Device::V4L2Device(const std::string &deviceNode)\n> *\n> * Construct a V4L2Device from a MediaEntity's device node path.\n> */\n> -V4L2Device::V4L2Device(const MediaEntity &entity)\n> -\t: V4L2Device(entity.deviceNode())\n> +V4L2Device::V4L2Device(MediaEntity *entity)\n> +\t: V4L2Device(entity->deviceNode())\n> {\n> }\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6576060B2D\n\tfor ;\n\tMon, 4 Feb 2019 19:25:09 +0100 (CET)","from pendragon.ideasonboard.com (85-76-64-229-nat.elisa-mobile.fi\n\t[85.76.64.229])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 34326572;\n\tMon, 4 Feb 2019 19:25:07 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1549304708;\n\tbh=1cg0wb1rwy5HL1HBOVs3UhHzQhKK7to2B8kLgKgkPI8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PHibVOvw6qH6M1XfB4fdiKxbeB1piD6rimndsNI3BaW+yPN9yw+SpbL8rhDBh68AK\n\txT+IS+1pRqCIaXs1hbLhNBFC+dFmooSJK3YryWulMxqhm2Ug/qN6tpUShD8ltk/QCP\n\tMhuqw9mhl+C6eBR5rsvn8kOujGj040SfL4HJJ9+k=","Date":"Mon, 4 Feb 2019 20:25:05 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190204182505.GA4561@pendragon.ideasonboard.com>","References":"<20190204155605.7900-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190204155605.7900-1-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_device: Construct\n\tfrom MediaEntity*","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 04 Feb 2019 18:25:09 -0000"}}]