{"id":492,"url":"https://patchwork.libcamera.org/api/patches/492/?format=json","web_url":"https://patchwork.libcamera.org/patch/492/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190203110102.5663-6-kieran.bingham@ideasonboard.com>","date":"2019-02-03T11:00:56","name":"[libcamera-devel,05/11] test: v4l2_device: Add request_buffers test","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"4c2a46df4fb1c5b7279197cf8a0a182e43de6a1f","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/492/mbox/","series":[{"id":165,"url":"https://patchwork.libcamera.org/api/series/165/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=165","date":"2019-02-03T11:00:51","name":"libcamera: V4L2 Streams","version":1,"mbox":"https://patchwork.libcamera.org/series/165/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/492/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/492/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E7DD460B1B\n\tfor ;\n\tSun, 3 Feb 2019 12:01:07 +0100 (CET)","from localhost.localdomain\n\t(218.182-78-194.adsl-static.isp.belgacom.be [194.78.182.218])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 936F85AA;\n\tSun, 3 Feb 2019 12:01:07 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1549191667;\n\tbh=2lZdF4EKlfd+Qs7P7uWQt6FhfoMHH8BdFkjfYeFpk1Y=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=qjc3/GC66Vx8ksESPpYYmH3wtCqygQmOaW1aodtmktSFuE0/9XmwesFFY9CXZbTyw\n\ty8s6Ht0B3gumKqzAumwlxw7bF9MiXT1tx6Fy9tdB1Ezybi3mpMA4KjXB4pztLimQp9\n\tS7gOh7hQkl2QfuCcEECXfCpP3YHb2eJtFtLLib/Q=","From":"Kieran Bingham ","To":"LibCamera Devel ","Date":"Sun, 3 Feb 2019 12:00:56 +0100","Message-Id":"<20190203110102.5663-6-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.19.1","In-Reply-To":"<20190203110102.5663-1-kieran.bingham@ideasonboard.com>","References":"<20190203110102.5663-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 05/11] test: v4l2_device: Add\n\trequest_buffers test","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 03 Feb 2019 11:01:08 -0000"},"content":"Add a utility to the test suite to request and allocate buffers from\na V4L2Device to ensure it functions successfully.\n\nSigned-off-by: Kieran Bingham \n---\n test/v4l2_device/meson.build | 1 +\n test/v4l2_device/request_buffers.cpp | 28 ++++++++++++++++++++++++++++\n 2 files changed, 29 insertions(+)\n create mode 100644 test/v4l2_device/request_buffers.cpp","diff":"diff --git a/test/v4l2_device/meson.build b/test/v4l2_device/meson.build\nindex 41675a303498..b6b672611d60 100644\n--- a/test/v4l2_device/meson.build\n+++ b/test/v4l2_device/meson.build\n@@ -2,6 +2,7 @@\n # They are not alphabetically sorted.\n v4l2_device_tests = [\n [ 'double_open', 'double_open.cpp' ],\n+ [ 'request_buffers', 'request_buffers.cpp' ],\n ]\n \n foreach t : v4l2_device_tests\ndiff --git a/test/v4l2_device/request_buffers.cpp b/test/v4l2_device/request_buffers.cpp\nnew file mode 100644\nindex 000000000000..8ab0f560516f\n--- /dev/null\n+++ b/test/v4l2_device/request_buffers.cpp\n@@ -0,0 +1,28 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2019, Google Inc.\n+ *\n+ * libcamera V4L2 API tests\n+ */\n+\n+#include \"v4l2_device_test.h\"\n+\n+class RequestBuffers : public V4L2DeviceTest\n+{\n+protected:\n+\tint run()\n+\t{\n+\t\t/* TODO:\n+\t\t * Test invalid requests\n+\t\t * Test different buffer allocations\n+\t\t */\n+\t\tBufferPool *pool = dev_->requestBuffers(8);\n+\n+\t\tif (!pool)\n+\t\t\treturn TestFail;\n+\n+\t\treturn TestPass;\n+\t}\n+};\n+\n+TEST_REGISTER(RequestBuffers);\n","prefixes":["libcamera-devel","05/11"]}