[{"id":54,"web_url":"https://patchwork.libcamera.org/comment/54/","msgid":"<1997032.mb46lZF7IO@avalon>","date":"2018-12-14T09:37:07","subject":"Re: [libcamera-devel] [PATCH] Documentation: Add linkcheck target","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Friday, 14 December 2018 11:01:01 EET Kieran Bingham wrote:\n> Sphinx provides a run-target to verify external links specified in the\n> documentation. This requires an active connection to be able to validate\n> the links.\n> \n> Add a meson target to integrate the linkcheck facility into our build\n> and test system.\n> \n> This rule does not run by default, but can be called with:\n> \n> ninja Documentation/linkcheck\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> Documentation/meson.build | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/Documentation/meson.build b/Documentation/meson.build\n> index dd43b2cbd401..cf91202224db 100644\n> --- a/Documentation/meson.build\n> +++ b/Documentation/meson.build\n> @@ -55,4 +55,9 @@ if sphinx.found()\n> build_by_default: true,\n> install: true,\n> install_dir: doc_install_dir)\n> +\n> + custom_target('documentation-linkcheck',\n\nWhat's the use of the first argument by the way, given that ninja seems to use \nthe target directory only as target specifiers ?\n\n> + command: [sphinx, '-W', '-b', 'linkcheck',\n> meson.current_source_dir(), '@OUTPUT@'],\n> + input: docs_sources,\n> + output: 'linkcheck')\n\nDoes this create any file in the linkcheck directory ? Will it be re-run every \ntime it is manually invoked ? I think it should be, as there's a use case for \nchecking links without modifying the source files.\n\n> endif","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EFA6260B10\n\tfor ;\n\tFri, 14 Dec 2018 10:36:19 +0100 (CET)","from avalon.localnet (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6375B549;\n\tFri, 14 Dec 2018 10:36:19 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1544780179;\n\tbh=edKPmRaamTRgnJuF/lTKaD37PjaZ87m83uKHjC90JXI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=p0+PVLYY7SaMXod9MyqFamynTyhYC9j6zMPQ1IDSJLuO0KdUoqbZYgKPQoYVgJebk\n\ttC9zK3ydET1uWHKTYH3fm0HmuOpb3PTrXmpXenbV88H/oKyvQMyHeCNId52ECgX33O\n\t+fCAp4D/KigCViE6wFwwzGxF+q62i1ddKbX12xzY=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 14 Dec 2018 11:37:07 +0200","Message-ID":"<1997032.mb46lZF7IO@avalon>","Organization":"Ideas on Board Oy","In-Reply-To":"<20181214090101.32511-1-kieran.bingham@ideasonboard.com>","References":"<20181214090101.32511-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"7Bit","Content-Type":"text/plain; charset=\"us-ascii\"","Subject":"Re: [libcamera-devel] [PATCH] Documentation: Add linkcheck target","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 14 Dec 2018 09:36:20 -0000"}},{"id":56,"web_url":"https://patchwork.libcamera.org/comment/56/","msgid":"<54cb48c2-d518-3fa3-419a-daccdd844e65@ideasonboard.com>","date":"2018-12-14T13:20:35","subject":"Re: [libcamera-devel] [PATCH] Documentation: Add linkcheck target","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 14/12/2018 09:37, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Friday, 14 December 2018 11:01:01 EET Kieran Bingham wrote:\n>> Sphinx provides a run-target to verify external links specified in the\n>> documentation. This requires an active connection to be able to validate\n>> the links.\n>>\n>> Add a meson target to integrate the linkcheck facility into our build\n>> and test system.\n>>\n>> This rule does not run by default, but can be called with:\n>>\n>> ninja Documentation/linkcheck\n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> Documentation/meson.build | 5 +++++\n>> 1 file changed, 5 insertions(+)\n>>\n>> diff --git a/Documentation/meson.build b/Documentation/meson.build\n>> index dd43b2cbd401..cf91202224db 100644\n>> --- a/Documentation/meson.build\n>> +++ b/Documentation/meson.build\n>> @@ -55,4 +55,9 @@ if sphinx.found()\n>> build_by_default: true,\n>> install: true,\n>> install_dir: doc_install_dir)\n>> +\n>> + custom_target('documentation-linkcheck',\n> \n> What's the use of the first argument by the way, given that ninja seems to use \n> the target directory only as target specifiers ?\n\nAs far as I can tell - it's only use is as the string that gets\ndisplayed to show what stage is running.\n\n> \n>> + command: [sphinx, '-W', '-b', 'linkcheck',\n>> meson.current_source_dir(), '@OUTPUT@'],\n>> + input: docs_sources,\n>> + output: 'linkcheck')\n> \n> Does this create any file in the linkcheck directory ? Will it be re-run every \n> time it is manually invoked ? I think it should be, as there's a use case for \n> checking links without modifying the source files.\n\nYes, it does create some files in the output - but currently - it does\nnot re-run if it has already run successfully.\n\nHere we have a pickle - as the 'correct' fix for this was only\nintroduced in meson 0.47.\n\nhttps://mesonbuild.com/Release-notes-for-0-47-0.html#deprecated-build_always-for-custom-targets\n\nThe correct solution is to add 'build_always_stale: true,' to the custom\ntarget.\n\nAdding 'build_always' will make it always rebuild, but also include it\nin the main 'ninja' build, which I don't want to do with this target.\n\nSo we can either leave this out - (we are currently on a minimum meson\nbuild 0.40) - or bump up our minimum version requirements ...\n\nWhat do you think ?\n\n--\nKieran\n\n\n> \n>> endif\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 73DB560B13\n\tfor ;\n\tFri, 14 Dec 2018 14:20:38 +0100 (CET)","from [192.168.0.21]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CD2E9549;\n\tFri, 14 Dec 2018 14:20:37 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1544793638;\n\tbh=74w8y1NPme6GBLv2RGcG8bvz9Pto6nSdM1W3rAhjOV4=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=bybFcBeIYMeK8aXAQwntY3NANbo62CP4VDC9wmRzR3Nb/fZZdI+k9ixEjlvMK03Sq\n\tA9I1Y4m8YESbdKmdFIkZL0E4YWzJQSn8c7RauZsBAqDio5lDiNChebSP2Cv0qPBbXZ\n\tJjnspOp423m0oyp09ov0zm+FnqSOUEfiAjsnI/u8=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20181214090101.32511-1-kieran.bingham@ideasonboard.com>\n\t<1997032.mb46lZF7IO@avalon>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<54cb48c2-d518-3fa3-419a-daccdd844e65@ideasonboard.com>","Date":"Fri, 14 Dec 2018 13:20:35 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.2.1","MIME-Version":"1.0","In-Reply-To":"<1997032.mb46lZF7IO@avalon>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] Documentation: Add linkcheck target","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 14 Dec 2018 13:20:38 -0000"}},{"id":58,"web_url":"https://patchwork.libcamera.org/comment/58/","msgid":"<772414314.HQhPnklOOW@avalon>","date":"2018-12-14T13:44:37","subject":"Re: [libcamera-devel] [PATCH] Documentation: Add linkcheck target","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Friday, 14 December 2018 15:20:35 EET Kieran Bingham wrote:\n> On 14/12/2018 09:37, Laurent Pinchart wrote:\n> > On Friday, 14 December 2018 11:01:01 EET Kieran Bingham wrote:\n> >> Sphinx provides a run-target to verify external links specified in the\n> >> documentation. This requires an active connection to be able to validate\n> >> the links.\n> >> \n> >> Add a meson target to integrate the linkcheck facility into our build\n> >> and test system.\n> >> \n> >> This rule does not run by default, but can be called with:\n> >> ninja Documentation/linkcheck\n> >> \n> >> Signed-off-by: Kieran Bingham \n> >> ---\n> >> \n> >> Documentation/meson.build | 5 +++++\n> >> 1 file changed, 5 insertions(+)\n> >> \n> >> diff --git a/Documentation/meson.build b/Documentation/meson.build\n> >> index dd43b2cbd401..cf91202224db 100644\n> >> --- a/Documentation/meson.build\n> >> +++ b/Documentation/meson.build\n> >> @@ -55,4 +55,9 @@ if sphinx.found()\n> >> \n> >> build_by_default: true,\n> >> install: true,\n> >> install_dir: doc_install_dir)\n> >> \n> >> +\n> >> + custom_target('documentation-linkcheck',\n> > \n> > What's the use of the first argument by the way, given that ninja seems to\n> > use the target directory only as target specifiers ?\n> \n> As far as I can tell - it's only use is as the string that gets\n> displayed to show what stage is running.\n> \n> >> + command: [sphinx, '-W', '-b', 'linkcheck',\n> >> meson.current_source_dir(), '@OUTPUT@'],\n> >> + input: docs_sources,\n> >> + output: 'linkcheck')\n> > \n> > Does this create any file in the linkcheck directory ? Will it be re-run\n> > every time it is manually invoked ? I think it should be, as there's a\n> > use case for checking links without modifying the source files.\n> \n> Yes, it does create some files in the output - but currently - it does\n> not re-run if it has already run successfully.\n> \n> Here we have a pickle - as the 'correct' fix for this was only\n> introduced in meson 0.47.\n> \n> https://mesonbuild.com/Release-notes-for-0-47-0.html#deprecated-build_always\n> -for-custom-targets\n> \n> The correct solution is to add 'build_always_stale: true,' to the custom\n> target.\n> \n> Adding 'build_always' will make it always rebuild, but also include it\n> in the main 'ninja' build, which I don't want to do with this target.\n> \n> So we can either leave this out - (we are currently on a minimum meson\n> build 0.40) - or bump up our minimum version requirements ...\n> \n> What do you think ?\n\nWe already require 0.40 while Debian ships 0.37. Debian testing has 0.48, so \ndoes gentoo, and Ubuntu ships 0.47. The previous Ubuntu release shipped 0.45 \nthough. I'm tempted to say we could bump the minimum version to 0.47, but I \nmay be a rushing it a bit. What do you think ?","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1DE3160B0C\n\tfor ;\n\tFri, 14 Dec 2018 14:43:54 +0100 (CET)","from avalon.localnet (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7578A549;\n\tFri, 14 Dec 2018 14:43:50 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1544795030;\n\tbh=X99W95CNGNjFMD9hyEo2D2cASSKMJagEOqgJ3KRL6j0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=fWgNyS55RK5S66TzlqfOGiqB1NMaJv0XGTq41pHWMnyFG7YWQqQcwq9V4YS2cr9dI\n\t/6RY08JLwauWaPAZ/cp+5JFZbab7R0Vr2EEBwd0cq+u6kJgtP/WlV4xhg3WpAYU60k\n\tUYFcn3ZQucGim46+xpXiJCzyndjznkr77+MujK6k=","From":"Laurent Pinchart ","To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Date":"Fri, 14 Dec 2018 15:44:37 +0200","Message-ID":"<772414314.HQhPnklOOW@avalon>","Organization":"Ideas on Board Oy","In-Reply-To":"<54cb48c2-d518-3fa3-419a-daccdd844e65@ideasonboard.com>","References":"<20181214090101.32511-1-kieran.bingham@ideasonboard.com>\n\t<1997032.mb46lZF7IO@avalon>\n\t<54cb48c2-d518-3fa3-419a-daccdd844e65@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"7Bit","Content-Type":"text/plain; charset=\"us-ascii\"","Subject":"Re: [libcamera-devel] [PATCH] Documentation: Add linkcheck target","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 14 Dec 2018 13:43:54 -0000"}}]