[{"id":55,"web_url":"https://patchwork.libcamera.org/comment/55/","msgid":"<7380230.qfovmLv1Sd@avalon>","date":"2018-12-14T09:41:39","subject":"Re: [libcamera-devel] [PATCH] log: Use libgen implementation of\n\tbasename","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Friday, 14 December 2018 10:59:09 EET Kieran Bingham wrote:\n> Pull in the libgen header to define basename. Unfortuantely this\n> requires casting away the const flag on the filename.\n\nPlease don't ! There's a reason why basename() from libgen.h has no const, \nthat's because it may modify its argument.\n\nLet's handle other libc implementations later (for the record I think recent \nAndroid versions provide the GNU_SOURCE implementation of basename()).\n\n> Signed-off-by: Kieran Bingham \n> ---\n> src/libcamera/log.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp\n> index 3715e69d810e..7096071e53f6 100644\n> --- a/src/libcamera/log.cpp\n> +++ b/src/libcamera/log.cpp\n> @@ -9,6 +9,7 @@\n> #include \n> #include \n> #include \n> +#include \n> \n> #include \"log.h\"\n> #include \"utils.h\"\n> @@ -80,7 +81,7 @@ LogMessage::LogMessage(const char *fileName, unsigned int\n> line, << std::setw(9) << timestamp.tv_nsec << \"]\";\n> \n> \tmsgStream << \" \" << log_severity_name(severity);\n> -\tmsgStream << \" \" << basename(fileName) << \":\" << line << \" \";\n> +\tmsgStream << \" \" << basename((char *)fileName) << \":\" << line << \" \";\n> }\n> \n> LogMessage::~LogMessage()","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0199C60B10\n\tfor ;\n\tFri, 14 Dec 2018 10:40:50 +0100 (CET)","from avalon.localnet (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5DA9B549;\n\tFri, 14 Dec 2018 10:40:50 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1544780450;\n\tbh=dKogDSLGnWMq46rNtZaAKiy/B4Jj2eMt9Zj6P192pNk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=joMTyFl9cDQ7SjQTLBxIrpr5FMVl7vdhI21ot1yxnkG3HwCrn5WjipTWYTrfXFxm/\n\t2hprwyD6ZLDK5UJ5jCoZDfDNJY7WU2DqMTo7YjaPm6KkzQOMLvZZ9SFAM6fQAczqap\n\tawDU8Ww2YoIaXHgWbFnBKXLNsfgRJAbcD8k6pbgo=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 14 Dec 2018 11:41:39 +0200","Message-ID":"<7380230.qfovmLv1Sd@avalon>","Organization":"Ideas on Board Oy","In-Reply-To":"<20181214085909.32325-1-kieran.bingham@ideasonboard.com>","References":"<20181214085909.32325-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"7Bit","Content-Type":"text/plain; charset=\"us-ascii\"","Subject":"Re: [libcamera-devel] [PATCH] log: Use libgen implementation of\n\tbasename","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 14 Dec 2018 09:40:51 -0000"}}]