[{"id":748,"web_url":"https://patchwork.libcamera.org/comment/748/","msgid":"<20190201223811.GH4359@pendragon.ideasonboard.com>","date":"2019-02-01T22:38:11","subject":"Re: [libcamera-devel] [PATCH 6/7] libcamera: v4l2_device: Set\n\tbytesperline in single plane S_FMT","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Fri, Feb 01, 2019 at 04:42:47PM +0100, Jacopo Mondi wrote:\n> The 'bytesperline' field of 'struct v4l2_pix_format' has to be set for\n> the single planar set format use case.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/v4l2_device.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\n> index b86a629..4d1f76b 100644\n> --- a/src/libcamera/v4l2_device.cpp\n> +++ b/src/libcamera/v4l2_device.cpp\n> @@ -331,6 +331,7 @@ int V4L2Device::setFormatSingleplane(V4L2DeviceFormat *format)\n> \tpix->width = format->width;\n> \tpix->height = format->height;\n> \tpix->pixelformat = format->fourcc;\n> +\tpix->bytesperline = format->planes[0].bpl;\n> \n> \tret = ioctl(fd_, VIDIOC_S_FMT, &v4l2Format);\n> \tif (ret) {","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4E3D260B10\n\tfor ;\n\tFri, 1 Feb 2019 23:38:19 +0100 (CET)","from pendragon.ideasonboard.com (85-76-65-45-nat.elisa-mobile.fi\n\t[85.76.65.45])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A3B554F7;\n\tFri, 1 Feb 2019 23:38:16 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1549060697;\n\tbh=Q6kNUWYs38xtlijudpE6zeki/xX/fRfese32t/X8J7k=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vRGd36Ni4EuiZ9XTaEiizefan65b3sMrDDbCxGAjtpeJBEN8pRdyqtk6AJNdN0xV9\n\tUMPsoawljSpctmkvSjD8wJGMPCZpn3WajltT2sFqRjgQ62ME0khwwPL+N5qxoInrYO\n\tg0V4BZK/r5kpVaozJiqshWpvheD78CF/DijHMqBM=","Date":"Sat, 2 Feb 2019 00:38:11 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190201223811.GH4359@pendragon.ideasonboard.com>","References":"<20190201154248.15006-1-jacopo@jmondi.org>\n\t<20190201154248.15006-7-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190201154248.15006-7-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 6/7] libcamera: v4l2_device: Set\n\tbytesperline in single plane S_FMT","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 01 Feb 2019 22:38:19 -0000"}}]