[{"id":741,"web_url":"https://patchwork.libcamera.org/comment/741/","msgid":"<6c3e2ae8-757c-e12f-6f87-24a15b253926@ideasonboard.com>","date":"2019-02-01T21:19:33","subject":"Re: [libcamera-devel] [PATCH 2/7] libcamera: v4l2_device: Fix\n\tgetFormatSingleplane ioclt","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 01/02/2019 16:42, Jacopo Mondi wrote:\n> The single plane getFormat() function wrongly used the VIDIOC_S_FMT ioctl.\n> Fix that by using the more opportune VIDIOC_G_FMT one.\nI think this one deserves a fixes tag:\n\nFixes: ba8da0f2fcd0 (\"libcamera: v4l2_device: Add methods to get/set\nformat\")\n\nWith s/ioclt/ioctl/ in the commit title:\n\nReviewed-by: Kieran Bingham Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/v4l2_device.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\n> index 26b6ff3..5ba89b9 100644\n> --- a/src/libcamera/v4l2_device.cpp\n> +++ b/src/libcamera/v4l2_device.cpp\n> @@ -305,7 +305,7 @@ int V4L2Device::getFormatSingleplane(V4L2DeviceFormat *fmt)\n> \tint ret;\n> \n> \tv4l2Fmt.type = bufferType_;\n> -\tret = ioctl(fd_, VIDIOC_S_FMT, &v4l2Fmt);\n> +\tret = ioctl(fd_, VIDIOC_G_FMT, &v4l2Fmt);\n> \tif (ret) {\n> \t\tret = -errno;\n> \t\tLOG(Error) << \"Unable to get format: \" << strerror(-ret);\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 26C1160B10\n\tfor ;\n\tFri, 1 Feb 2019 22:19:37 +0100 (CET)","from [10.10.152.147] (218.182-78-194.adsl-static.isp.belgacom.be\n\t[194.78.182.218])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 87A624F7;\n\tFri, 1 Feb 2019 22:19:36 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1549055976;\n\tbh=s3FqxJzjsLPIozqazc3dhPNJ0h1v+27a5SfXCwTYSuQ=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=iQVndKebm6wnzSEHXi6nulxw9rVkzKgzNV36Hk7EH25aygtfw7olO9LFcGpcQpyNW\n\t3awyQ1CibKa/0xvZReqxtDTiFGi9BwCrK90YTsSbnYjIMjvxu8zOyp8r1J3mzd9jZ7\n\ti5Z9iIkpwNCnQmrWsoNbcVKxG6XirSS9rgn3vFOw=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20190201154248.15006-1-jacopo@jmondi.org>\n\t<20190201154248.15006-3-jacopo@jmondi.org>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<6c3e2ae8-757c-e12f-6f87-24a15b253926@ideasonboard.com>","Date":"Fri, 1 Feb 2019 22:19:33 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.4.0","MIME-Version":"1.0","In-Reply-To":"<20190201154248.15006-3-jacopo@jmondi.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 2/7] libcamera: v4l2_device: Fix\n\tgetFormatSingleplane ioclt","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 01 Feb 2019 21:19:37 -0000"}},{"id":744,"web_url":"https://patchwork.libcamera.org/comment/744/","msgid":"<20190201221021.GD4359@pendragon.ideasonboard.com>","date":"2019-02-01T22:10:21","subject":"Re: [libcamera-devel] [PATCH 2/7] libcamera: v4l2_device: Fix\n\tgetFormatSingleplane ioclt","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Feb 01, 2019 at 10:19:33PM +0100, Kieran Bingham wrote:\n> On 01/02/2019 16:42, Jacopo Mondi wrote:\n> > The single plane getFormat() function wrongly used the VIDIOC_S_FMT ioctl.\n> > Fix that by using the more opportune VIDIOC_G_FMT one.\n> I think this one deserves a fixes tag:\n> \n> Fixes: ba8da0f2fcd0 (\"libcamera: v4l2_device: Add methods to get/set\n> format\")\n> \n> With s/ioclt/ioctl/ in the commit title:\n\nI had the exact same comments :-)\n\nReviewed-by: Laurent Pinchart \n\n> Reviewed-by: Kieran Bingham \n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > src/libcamera/v4l2_device.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\n> > index 26b6ff3..5ba89b9 100644\n> > --- a/src/libcamera/v4l2_device.cpp\n> > +++ b/src/libcamera/v4l2_device.cpp\n> > @@ -305,7 +305,7 @@ int V4L2Device::getFormatSingleplane(V4L2DeviceFormat *fmt)\n> > \tint ret;\n> > \n> > \tv4l2Fmt.type = bufferType_;\n> > -\tret = ioctl(fd_, VIDIOC_S_FMT, &v4l2Fmt);\n> > +\tret = ioctl(fd_, VIDIOC_G_FMT, &v4l2Fmt);\n> > \tif (ret) {\n> > \t\tret = -errno;\n> > \t\tLOG(Error) << \"Unable to get format: \" << strerror(-ret);","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7220F60B10\n\tfor ;\n\tFri, 1 Feb 2019 23:10:29 +0100 (CET)","from pendragon.ideasonboard.com (85-76-65-45-nat.elisa-mobile.fi\n\t[85.76.65.45])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C07404F7;\n\tFri, 1 Feb 2019 23:10:23 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1549059024;\n\tbh=hN8hesKWeizIJbsbmSvM41KrjB11y1PF5HBS/8BLRHQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=TMZlb+j8ecBp/XWVTRBcuNUqk13OLsLVGYC7D9U42ArWD99f4axLGU62bdkUvwk0W\n\tGp1gviivLHImtjiKdggYKAdJMJbiHZ8oT/OYmVWAEnE0/9EWJbM2CyLWLLCXQlN3HE\n\tlTiGVTkqGi1fuee/bESbNFE0vOaw9OBrBbU7uDKA=","Date":"Sat, 2 Feb 2019 00:10:21 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","Message-ID":"<20190201221021.GD4359@pendragon.ideasonboard.com>","References":"<20190201154248.15006-1-jacopo@jmondi.org>\n\t<20190201154248.15006-3-jacopo@jmondi.org>\n\t<6c3e2ae8-757c-e12f-6f87-24a15b253926@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<6c3e2ae8-757c-e12f-6f87-24a15b253926@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 2/7] libcamera: v4l2_device: Fix\n\tgetFormatSingleplane ioclt","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 01 Feb 2019 22:10:29 -0000"}}]