[{"id":752,"web_url":"https://patchwork.libcamera.org/comment/752/","msgid":"<9f8e7a22-84d5-acd2-771d-83ffbe860432@ideasonboard.com>","date":"2019-02-04T15:40:43","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: vimc: create\n\tcamera for Sensor B","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nOn 01/02/2019 16:13, Niklas Söderlund wrote:\n> Create a camera for Sensor B of the vimc pipeline. At this stage only\n> Sensor B is exposed while the are in total two sensors in the graph.\n> Going forward Sensor A should also be exposed as another camera. Sensor\n> B was chosen since the graph is configured correctly for it out of the\n> box. As we lack control over sub devices formats it's not really\n> possible to use Sensor A yet with the library.\n> \n> Once both cameras are registered with the library they should be\n> extended to provide two streams each, one for the raw output and one for\n> the output which uses the shared scaler.\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/pipeline/vimc.cpp | 17 +++++++++++++++--\n> 1 file changed, 15 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\n> index 6ed069edec550a61..6ab6e203785499ec 100644\n> --- a/src/libcamera/pipeline/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc.cpp\n> @@ -12,6 +12,7 @@\n> #include \"log.h\"\n> #include \"media_device.h\"\n> #include \"pipeline_handler.h\"\n> +#include \"v4l2_device.h\"\n> \n> namespace libcamera {\n> \n> @@ -33,16 +34,20 @@ public:\n> \n> private:\n> \tstd::shared_ptr media_;\n> +\tV4L2Device *video_;\n> \tStream stream_;\n> };\n> \n> PipeHandlerVimc::PipeHandlerVimc(CameraManager *manager)\n> -\t: PipelineHandler(manager), media_(nullptr)\n> +\t: PipelineHandler(manager), media_(nullptr), video_(nullptr)\n> {\n> }\n> \n> PipeHandlerVimc::~PipeHandlerVimc()\n> {\n> +\tif (video_)\n> +\t\tdelete video_;\n\nI don't think you need the if (video_) here.\ndelete (nullptr); should be safe.\n\nOther than that,\n\nReviewed-by: Kieran Bingham \n\n\n> +\n> \tif (media_)\n> \t\tmedia_->release();\n> }\n> @@ -93,8 +98,16 @@ bool PipeHandlerVimc::match(DeviceEnumerator *enumerator)\n> \n> \tmedia_->acquire();\n> \n> +\tvideo_ = new V4L2Device(*media_->getEntityByName(\"Raw Capture 1\"));\n> +\n> +\tif (video_->open()) {\n> +\t\tmedia_->release();\n> +\t\treturn false;\n> +\t}\n> +\n> \tstd::vector streams{ &stream_ };\n> -\tstd::shared_ptr camera = Camera::create(this, \"Dummy VIMC Camera\", streams);\n> +\tstd::shared_ptr camera = Camera::create(this, \"VIMC Sensor B\",\n> +\t\t\t\t\t\t\tstreams);\n> \tregisterCamera(std::move(camera));\n> \n> \treturn true;\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A3DDB60DBB\n\tfor ;\n\tMon, 4 Feb 2019 16:40:47 +0100 (CET)","from [192.168.0.245] (d51A4137F.access.telenet.be [81.164.19.127])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0F88841;\n\tMon, 4 Feb 2019 16:40:47 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1549294847;\n\tbh=iwdROvg+94HkwUtBrB5vllCn3h6NCMjjyWPyO4hthtM=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=GVGEwBW1fkPAbZUuHTJEeMvQzQpld95Rs5yiaamShAKjLEVpVf/9zvyVJl3kv0k3Z\n\tzHyaUaQiT8my+XKV6x42pqYlg5OHmRdKRuv27eN22OpdIZ+WiH5X5W5igMJ4vuHf8C\n\tFeWBepcMbPfvDgXijhmlY3cHtrt/eaGMyvNSgW60=","Reply-To":"kieran.bingham@ideasonboard.com","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20190201151354.17980-1-niklas.soderlund@ragnatech.se>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<9f8e7a22-84d5-acd2-771d-83ffbe860432@ideasonboard.com>","Date":"Mon, 4 Feb 2019 16:40:43 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.4.0","MIME-Version":"1.0","In-Reply-To":"<20190201151354.17980-1-niklas.soderlund@ragnatech.se>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: vimc: create\n\tcamera for Sensor B","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 04 Feb 2019 15:40:47 -0000"}},{"id":753,"web_url":"https://patchwork.libcamera.org/comment/753/","msgid":"<20190204155537.GA16152@bigcity.dyn.berto.se>","date":"2019-02-04T15:55:37","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: vimc: create\n\tcamera for Sensor B","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nThanks for your feedback.\n\nOn 2019-02-04 16:40:43 +0100, Kieran Bingham wrote:\n> Hi Niklas,\n> \n> On 01/02/2019 16:13, Niklas Söderlund wrote:\n> > Create a camera for Sensor B of the vimc pipeline. At this stage only\n> > Sensor B is exposed while the are in total two sensors in the graph.\n> > Going forward Sensor A should also be exposed as another camera. Sensor\n> > B was chosen since the graph is configured correctly for it out of the\n> > box. As we lack control over sub devices formats it's not really\n> > possible to use Sensor A yet with the library.\n> > \n> > Once both cameras are registered with the library they should be\n> > extended to provide two streams each, one for the raw output and one for\n> > the output which uses the shared scaler.\n> > \n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > src/libcamera/pipeline/vimc.cpp | 17 +++++++++++++++--\n> > 1 file changed, 15 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\n> > index 6ed069edec550a61..6ab6e203785499ec 100644\n> > --- a/src/libcamera/pipeline/vimc.cpp\n> > +++ b/src/libcamera/pipeline/vimc.cpp\n> > @@ -12,6 +12,7 @@\n> > #include \"log.h\"\n> > #include \"media_device.h\"\n> > #include \"pipeline_handler.h\"\n> > +#include \"v4l2_device.h\"\n> > \n> > namespace libcamera {\n> > \n> > @@ -33,16 +34,20 @@ public:\n> > \n> > private:\n> > \tstd::shared_ptr media_;\n> > +\tV4L2Device *video_;\n> > \tStream stream_;\n> > };\n> > \n> > PipeHandlerVimc::PipeHandlerVimc(CameraManager *manager)\n> > -\t: PipelineHandler(manager), media_(nullptr)\n> > +\t: PipelineHandler(manager), media_(nullptr), video_(nullptr)\n> > {\n> > }\n> > \n> > PipeHandlerVimc::~PipeHandlerVimc()\n> > {\n> > +\tif (video_)\n> > +\t\tdelete video_;\n> \n> I don't think you need the if (video_) here.\n> delete (nullptr); should be safe.\n> \n> Other than that,\n> \n> Reviewed-by: Kieran Bingham \n\nWith this fixed pushed to master.\n\n> \n> \n> > +\n> > \tif (media_)\n> > \t\tmedia_->release();\n> > }\n> > @@ -93,8 +98,16 @@ bool PipeHandlerVimc::match(DeviceEnumerator *enumerator)\n> > \n> > \tmedia_->acquire();\n> > \n> > +\tvideo_ = new V4L2Device(*media_->getEntityByName(\"Raw Capture 1\"));\n> > +\n> > +\tif (video_->open()) {\n> > +\t\tmedia_->release();\n> > +\t\treturn false;\n> > +\t}\n> > +\n> > \tstd::vector streams{ &stream_ };\n> > -\tstd::shared_ptr camera = Camera::create(this, \"Dummy VIMC Camera\", streams);\n> > +\tstd::shared_ptr camera = Camera::create(this, \"VIMC Sensor B\",\n> > +\t\t\t\t\t\t\tstreams);\n> > \tregisterCamera(std::move(camera));\n> > \n> > \treturn true;\n> > \n> \n> -- \n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","Received":["from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 69B3560DBB\n\tfor ;\n\tMon, 4 Feb 2019 16:55:39 +0100 (CET)","by mail-lf1-x141.google.com with SMTP id v5so256426lfe.7\n\tfor ;\n\tMon, 04 Feb 2019 07:55:39 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tt18sm3145581lft.93.2019.02.04.07.55.37\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 04 Feb 2019 07:55:37 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=ZYJBmQ4isxlfEGx9gty8eFbETy84iHoWdsIToPu/CW0=;\n\tb=J9PWvcxxHknL8zjXLvEiIuBv4ZjUHQkutjzSaTavwCmQXrChKQdPD7eQlY6zI2Zdil\n\tygqpQaaazWJY1ubivC1D8lwl2W5RbzqNbkjv/80soiplO9xbEoMU7lZO7e7uZr/6oQ1a\n\tzb7FLNtw53R8BNZ8+d+DXAAzFeAZFo1Q+b6uXcsujf33A5MSJ8lPbmclS4cWnzNVCVsC\n\tFFtuTxCIl0FgoBxmtsKtQWo2oSJqzogrW5s/VaTdlxUlv4XPa97JI1ku7RFLZsCHGJan\n\t7b8oSrRw70qirDDptBouoYpRzB2W+3CjYbrESMcmhfGYuM5MAfE/Vxn3Cmi1ELf+ZEe7\n\tvYtA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=ZYJBmQ4isxlfEGx9gty8eFbETy84iHoWdsIToPu/CW0=;\n\tb=TBW6wkpEjW/zKeJi+zQGnfo5ajbPSpzNy1WuAdWgjNLXlh4NHhYhoNi1Ayszi7saL+\n\to+GM7s43OIDSLnx5WfG2wMrdVwReHID+/sV7ZiCND9yAXBoVC0rxCmhd++V+JOHpMDSM\n\tWDSRE9GrQ63fAkIhGJAd/hhuwyv2QkNHiFfaxHWxoZLPixdQoZhwonKWsFBQT3gzGl/R\n\tXYEHU0o3ReAhQBwQa0DwCgGZbrUSrPAe4/XK1pOWkl2L0IUgcFAn6VYhlUkK7D12ug3G\n\tXDBeutjq+zLzlyj9lpP/EPXvQ+HRySCqZNca7CeCH2rXr4lXDTddSi0OMl7kXSfvE7dx\n\tjpLg==","X-Gm-Message-State":"AHQUAuafFGVqVKqGqj86Q+5+vmMFW+S+N8ZzsmS+lP8wvP79L/zvdZCK\n\t93/IgqKisPk4mJ9Raeg5rfQ8P1nW1M8=","X-Google-Smtp-Source":"AHgI3IZ7lISbr2J7sPwors8avz6+Yx9IKS04bXMsK8+165uUnTYaCROe9SdslVha/POSEXPrhMYb6Q==","X-Received":"by 2002:ac2:520e:: with SMTP id a14mr56957lfl.16.1549295738455; \n\tMon, 04 Feb 2019 07:55:38 -0800 (PST)","Date":"Mon, 4 Feb 2019 16:55:37 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190204155537.GA16152@bigcity.dyn.berto.se>","References":"<20190201151354.17980-1-niklas.soderlund@ragnatech.se>\n\t<9f8e7a22-84d5-acd2-771d-83ffbe860432@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<9f8e7a22-84d5-acd2-771d-83ffbe860432@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: vimc: create\n\tcamera for Sensor B","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 04 Feb 2019 15:55:39 -0000"}}]