[{"id":733,"web_url":"https://patchwork.libcamera.org/comment/733/","msgid":"<20190201090222.GM19527@bigcity.dyn.berto.se>","date":"2019-02-01T09:02:22","subject":"Re: [libcamera-devel] [PATCH v2 5/8] cam: options: Store options in\n\ta list instead of a vector","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-02-01 01:47:18 +0200, Laurent Pinchart wrote:\n> When option are added to the parser, they are stored in the\n> OptionsParser::options_ vector, and a pointer to the option referencing\n> the vector entry is indexed in the OptionsParser::optionsMap_ map. When\n> the next option is added the vector may be resized, which invalidates\n> the pointers stored in the map.\n> \n> Fix this by storing the options in an std::list<> instead of\n> std::vector<>.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/cam/options.h | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/cam/options.h b/src/cam/options.h\n> index 2272385a0b83..b9b7bd258c03 100644\n> --- a/src/cam/options.h\n> +++ b/src/cam/options.h\n> @@ -8,8 +8,8 @@\n> #define __CAM_OPTIONS_H__\n> \n> #include \n> +#include \n> #include \n> -#include \n> \n> enum OptionArgument {\n> \tArgumentNone,\n> @@ -57,7 +57,7 @@ public:\n> \tvoid usage();\n> \n> private:\n> -\tstd::vector