{"id":465,"url":"https://patchwork.libcamera.org/api/patches/465/?format=json","web_url":"https://patchwork.libcamera.org/patch/465/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190131234721.22606-6-laurent.pinchart@ideasonboard.com>","date":"2019-01-31T23:47:18","name":"[libcamera-devel,v2,5/8] cam: options: Store options in a list instead of a vector","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"454661fd138daf11fbbe2587124542b17f613015","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/465/mbox/","series":[{"id":158,"url":"https://patchwork.libcamera.org/api/series/158/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=158","date":"2019-01-31T23:47:13","name":"cam: add --format option to configure a stream","version":2,"mbox":"https://patchwork.libcamera.org/series/158/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/465/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/465/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F0D2060DBE\n\tfor ;\n\tFri, 1 Feb 2019 00:47:41 +0100 (CET)","from pendragon.ideasonboard.com (85-76-34-136-nat.elisa-mobile.fi\n\t[85.76.34.136])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9DE6441;\n\tFri, 1 Feb 2019 00:47:40 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1548978461;\n\tbh=1SjAz47QewbqEpJqOPs+aEs9AXpL3qZv/nw0xVmU9ss=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=rzMzcyv4pBwlMJ+SYSEIOsLfaLqV1qK3vGXFq3TuSl+EuSZ9AY9lhZCuc3SAuscU5\n\tTSJVgMmrT6feo9utmn2vc109kzts4Iiduhz4lT4AOQzIRG9oG3X+d5Epa5Yw5yKnh9\n\tAMiULa1Jm1uslciErlBgSJSXjPTiBI3gQCQNZcWQ=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 1 Feb 2019 01:47:18 +0200","Message-Id":"<20190131234721.22606-6-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.19.2","In-Reply-To":"<20190131234721.22606-1-laurent.pinchart@ideasonboard.com>","References":"<20190131234721.22606-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 5/8] cam: options: Store options in a\n\tlist instead of a vector","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 31 Jan 2019 23:47:42 -0000"},"content":"When option are added to the parser, they are stored in the\nOptionsParser::options_ vector, and a pointer to the option referencing\nthe vector entry is indexed in the OptionsParser::optionsMap_ map. When\nthe next option is added the vector may be resized, which invalidates\nthe pointers stored in the map.\n\nFix this by storing the options in an std::list<> instead of\nstd::vector<>.\n\nSigned-off-by: Laurent Pinchart \n---\n src/cam/options.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/cam/options.h b/src/cam/options.h\nindex 2272385a0b83..b9b7bd258c03 100644\n--- a/src/cam/options.h\n+++ b/src/cam/options.h\n@@ -8,8 +8,8 @@\n #define __CAM_OPTIONS_H__\n \n #include \n+#include \n #include \n-#include \n \n enum OptionArgument {\n \tArgumentNone,\n@@ -57,7 +57,7 @@ public:\n \tvoid usage();\n \n private:\n-\tstd::vector