[{"id":732,"web_url":"https://patchwork.libcamera.org/comment/732/","msgid":"<20190201085733.GL19527@bigcity.dyn.berto.se>","date":"2019-02-01T08:57:33","subject":"Re: [libcamera-devel] [PATCH v2 2/8] cam: options: Move struct\n\tOption","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-02-01 01:47:15 +0200, Laurent Pinchart wrote:\n> The Option structure is declared within the OptionsParser, but will\n> later be needed by other parsers. Move it outside the OptionsParser\n> class.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/cam/options.h | 22 +++++++++++-----------\n> 1 file changed, 11 insertions(+), 11 deletions(-)\n> \n> diff --git a/src/cam/options.h b/src/cam/options.h\n> index 491f6a316fff..6d1b12d235d8 100644\n> --- a/src/cam/options.h\n> +++ b/src/cam/options.h\n> @@ -17,6 +17,17 @@ enum OptionArgument {\n> \tArgumentOptional,\n> };\n> \n> +struct Option {\n> +\tint opt;\n> +\tconst char *name;\n> +\tOptionArgument argument;\n> +\tconst char *argumentName;\n> +\tconst char *help;\n> +\n> +\tbool hasShortOption() const { return isalnum(opt); }\n> +\tbool hasLongOption() const { return name != nullptr; }\n> +};\n> +\n> class OptionsParser\n> {\n> public:\n> @@ -42,17 +53,6 @@ public:\n> \tvoid usage();\n> \n> private:\n> -\tstruct Option {\n> -\t\tint opt;\n> -\t\tconst char *name;\n> -\t\tOptionArgument argument;\n> -\t\tconst char *argumentName;\n> -\t\tconst char *help;\n> -\n> -\t\tbool hasShortOption() const { return isalnum(opt); }\n> -\t\tbool hasLongOption() const { return name != nullptr; }\n> -\t};\n> -\n> \tstd::vector