[{"id":51,"web_url":"https://patchwork.libcamera.org/comment/51/","msgid":"<20181214081614.GT5597@w540>","date":"2018-12-14T08:16:14","subject":"Re: [libcamera-devel] [PATCH 1/2] Documentation: coding-style: Fix\n\tlist indentation","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Thu, Dec 13, 2018 at 04:53:12PM +0200, Laurent Pinchart wrote:\n> The various lists in the document are not quoted blocks. Don't indent\n> them.\n>\n> Signed-off-by: Laurent Pinchart \n\nAll: these patches depends on the the previous 3 ones.\n\nThese fixes are welcome. Please push.\n\nAcked-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> Documentation/coding-style.rst | 62 +++++++++++++++++-----------------\n> 1 file changed, 31 insertions(+), 31 deletions(-)\n>\n> diff --git a/Documentation/coding-style.rst b/Documentation/coding-style.rst\n> index d03eb3d5b96d..1b67abed3a53 100644\n> --- a/Documentation/coding-style.rst\n> +++ b/Documentation/coding-style.rst\n> @@ -26,13 +26,13 @@ Even if the programming language in use is different, the project embraces the\n>\n> In particular, from the kernel style document, the following section are adopted:\n>\n> - * 1 \"Indentation\"\n> - * 2 \"Breaking Long Lines\" striving to fit code within 80 columns and\n> - accepting up to 120 columns when necessary\n> - * 3 \"Placing Braces and Spaces\"\n> - * 3.1 \"Spaces\"\n> - * 8 \"Commenting\" with the exception that in-function comments are not\n> - always un-welcome.\n> +* 1 \"Indentation\"\n> +* 2 \"Breaking Long Lines\" striving to fit code within 80 columns and\n> + accepting up to 120 columns when necessary\n> +* 3 \"Placing Braces and Spaces\"\n> +* 3.1 \"Spaces\"\n> +* 8 \"Commenting\" with the exception that in-function comments are not\n> + always un-welcome.\n>\n> While libcamera uses the kernel coding style for all typographic matters, the\n> project is a user space library, developed in a different programming language,\n> @@ -47,19 +47,19 @@ few exceptions and relaxed limitations on some subjects.\n> The following exceptions apply to the naming conventions specified in the\n> document:\n>\n> - * File names: libcamera uses the .cpp extensions for C++ source files and\n> - the .h extension for header files\n> - * Variables, function parameters, function names and class members use\n> - camel case style, with the first letter in lower-case (as in 'camelCase'\n> - and not 'CamelCase')\n> - * Types (classes, structs, type aliases, and type template parameters) use\n> - camel case, with the first letter in capital case (as in 'CamelCase' and\n> - not 'camelCase')\n> - * Enum members use 'CamelCase', while macros are in capital case with\n> - underscores in between\n> - * All formatting rules specified in the selected sections of the Linux kernel\n> - Code Style for indentation, braces, spacing, etc\n> - * Header guards are formatted as '__LIBCAMERA_FILE_NAME_H__'\n> +* File names: libcamera uses the .cpp extensions for C++ source files and\n> + the .h extension for header files\n> +* Variables, function parameters, function names and class members use\n> + camel case style, with the first letter in lower-case (as in 'camelCase'\n> + and not 'CamelCase')\n> +* Types (classes, structs, type aliases, and type template parameters) use\n> + camel case, with the first letter in capital case (as in 'CamelCase' and\n> + not 'camelCase')\n> +* Enum members use 'CamelCase', while macros are in capital case with\n> + underscores in between\n> +* All formatting rules specified in the selected sections of the Linux kernel\n> + Code Style for indentation, braces, spacing, etc\n> +* Header guards are formatted as '__LIBCAMERA_FILE_NAME_H__'\n>\n>\n> C++ Specific Rules\n> @@ -68,14 +68,14 @@ C++ Specific Rules\n> The code shall be implemented in C++03, extended with the following\n> C++-11-specific features:\n>\n> - * Initializer lists\n> - * Type inference (auto and decltype)\n> - Type inference shall be used with caution, to avoid drifting towards an\n> - untyped language.\n> - * Range-based for loop\n> - * Lambda functions\n> - * Explicit overrides and final\n> - * Null pointer constant\n> - * General-purpose smart pointers (std::unique_ptr), deprecating std::auto_ptr.\n> - Smart pointers, as well as shared pointers and weak pointers, shall not be\n> - overused.\n> +* Initializer lists\n> +* Type inference (auto and decltype)\n> + Type inference shall be used with caution, to avoid drifting towards an\n> + untyped language.\n> +* Range-based for loop\n> +* Lambda functions\n> +* Explicit overrides and final\n> +* Null pointer constant\n> +* General-purpose smart pointers (std::unique_ptr), deprecating std::auto_ptr.\n> + Smart pointers, as well as shared pointers and weak pointers, shall not be\n> + overused.\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 557D960B0C\n\tfor ;\n\tFri, 14 Dec 2018 09:16:18 +0100 (CET)","from w540 (unknown [37.177.107.242])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 9720C40003;\n\tFri, 14 Dec 2018 08:16:16 +0000 (UTC)"],"X-Originating-IP":"37.177.107.242","Date":"Fri, 14 Dec 2018 09:16:14 +0100","From":"jacopo mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20181214081614.GT5597@w540>","References":"<20181213145313.6754-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"WcQ7DTTOeW3GIUV5\"","Content-Disposition":"inline","In-Reply-To":"<20181213145313.6754-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Subject":"Re: [libcamera-devel] [PATCH 1/2] Documentation: coding-style: Fix\n\tlist indentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 14 Dec 2018 08:16:18 -0000"}}]