[{"id":701,"web_url":"https://patchwork.libcamera.org/comment/701/","msgid":"<20190130122653.GI4336@pendragon.ideasonboard.com>","date":"2019-01-30T12:26:53","subject":"Re: [libcamera-devel] [PATCH] clang-format: Enable\n\tBreakBeforeTernaryOperators","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Wed, Jan 30, 2019 at 11:13:49AM +0000, Kieran Bingham wrote:\n> This produces code with the ternary operators at the beginning instead of the\n> end of the line:\n> \n>        return caps_.isMultiplanar() ? getFormatMultiplane(fmt)\n>                                     : getFormatSingleplane(fmt);\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  .clang-format | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/.clang-format b/.clang-format\n> index 59a61d050e3d..d4669dd93f8d 100644\n> --- a/.clang-format\n> +++ b/.clang-format\n> @@ -47,7 +47,7 @@ BraceWrapping:\n>  BreakBeforeBinaryOperators: None\n>  BreakBeforeBraces: Custom\n>  #BreakBeforeInheritanceComma: false # Unknown to clang-format-4.0\n> -BreakBeforeTernaryOperators: false\n> +BreakBeforeTernaryOperators: true\n>  BreakConstructorInitializersBeforeComma: false\n>  #BreakConstructorInitializers: BeforeComma # Unknown to clang-format-4.0\n>  BreakAfterJavaFieldAnnotations: false","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3583560C78\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 30 Jan 2019 13:26:57 +0100 (CET)","from pendragon.ideasonboard.com (85-76-73-0-nat.elisa-mobile.fi\n\t[85.76.73.0])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BFDCB41;\n\tWed, 30 Jan 2019 13:26:55 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1548851216;\n\tbh=u4Q8zaQXoM6pnQXGr5P9AHlaLafMLVX8wHVA7zKQQMM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=KSm4sObR0S8vVWOt761vxl57HUuuvDk7xKFRBooM1Fymsl5JtkA1HjmR7vieQuqV2\n\tvw40PkJ64CZnSi9eUzpEDa7Xj/zDn0j6eiThZtiNgRK8OZcuz0kNcsRBTVUjA5I8Rc\n\tRfhoh1xBUBXhiG/dD36O9cgWai0Xez8/dHQs1Xv0=","Date":"Wed, 30 Jan 2019 14:26:53 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Message-ID":"<20190130122653.GI4336@pendragon.ideasonboard.com>","References":"<20190130111349.20891-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190130111349.20891-1-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] clang-format: Enable\n\tBreakBeforeTernaryOperators","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Wed, 30 Jan 2019 12:26:57 -0000"}}]