[{"id":677,"web_url":"https://patchwork.libcamera.org/comment/677/","msgid":"<3b181385-a184-45f2-af2c-b7413835aae9@ideasonboard.com>","date":"2019-01-29T09:51:54","subject":"Re: [libcamera-devel] [PATCH v4 3/6] libcamera: camera: Add\n\tacquire() and release()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas, (/Laurent,)\n\nOn 29/01/2019 02:00, Niklas Söderlund wrote:\n> From: Laurent Pinchart \n> \n> Exclusive access must be obtained before performing operations that\n> change the device state. Define an internal flag to track ownership and\n> provide a means of protecting functions that change device\n> configuration.\n> \n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Niklas Söderlund \n> Signed-off-by: Niklas Söderlund \n\nWith capitalisation comments considered,\n\nReviewed-by: Kieran Bingham \n\n\n\n> ---\n> include/libcamera/camera.h | 5 +++++\n> src/libcamera/camera.cpp | 39 +++++++++++++++++++++++++++++++++++++-\n> 2 files changed, 43 insertions(+), 1 deletion(-)\n> \n> diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\n> index a2ded62de94814c4..7e358f8c0aa093cf 100644\n> --- a/include/libcamera/camera.h\n> +++ b/include/libcamera/camera.h\n> @@ -29,6 +29,9 @@ public:\n> \n> \tSignal disconnected;\n> \n> +\tint acquire();\n> +\tvoid release();\n> +\n> private:\n> \tCamera(PipelineHandler *pipe, const std::string &name);\n> \t~Camera();\n> @@ -38,6 +41,8 @@ private:\n> \n> \tstd::shared_ptr pipe_;\n> \tstd::string name_;\n> +\n> +\tbool acquired_;\n> };\n> \n> } /* namespace libcamera */\n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index 9cec289282e4797b..500976b237bcbd2d 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -102,12 +102,14 @@ const std::string &Camera::name() const\n> */\n> \n> Camera::Camera(PipelineHandler *pipe, const std::string &name)\n> -\t: pipe_(pipe->shared_from_this()), name_(name)\n> +\t: pipe_(pipe->shared_from_this()), name_(name), acquired_(false)\n> {\n> }\n> \n> Camera::~Camera()\n> {\n> +\tif (acquired_)\n> +\t\tLOG(Camera, Error) << \"Removing camera while still in use\";\n> }\n> \n> /**\n> @@ -127,4 +129,39 @@ void Camera::disconnect()\n> \tdisconnected.emit(this);\n> }\n> \n> +/**\n> + * \\brief Acquire the camera device for exclusive access\n\nBack on my Doxygen Capitalisation Front....\n\nI think we should be capitalising any use of a class name so that\nDoxygen links the types and makes it clear that we are referencing an\nobject of that type.\n\n\n> + *\n> + * After opening the device with open(), exclusive access must be obtained\n> + * before performing operations that change the device state. This function is\n> + * not blocking, if the device has already been acquired (by the same or another\n> + * process) the -EBUSY error code is returned.\n> + *\n> + * Once exclusive access isn't needed anymore, the device should be released\n> + * with a call to the release() function.\n> + *\n> + * \\todo Implement exclusive access across processes.\n> + *\n> + * \\return 0 on success or a negative error code on error.\n> + */\n> +int Camera::acquire()\n> +{\n> +\tif (acquired_)\n> +\t\treturn -EBUSY;\n> +\n> +\tacquired_ = true;\n> +\treturn 0;\n> +}\n> +\n> +/**\n> + * \\brief Release exclusive access to the camera device\n\ns/camera/Camera/\n\n> + *\n> + * Releasing the camera device allows other users to acquire exclusive access\n\ns/camera/Camera/\n\n> + * with the acquire() function.\n> + */\n> +void Camera::release()\n> +{\n> +\tacquired_ = false;\n> +}\n> +\n> } /* namespace libcamera */\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A7BE360B2D\n\tfor ;\n\tTue, 29 Jan 2019 10:51:57 +0100 (CET)","from [192.168.0.21]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 099C285;\n\tTue, 29 Jan 2019 10:51:56 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1548755517;\n\tbh=IoKSVmEHuRzzKO4fRNsUpDRS12mjBSctCIf4DTK2CuM=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=iL/NODV20w3deZWDk9NFvrGIBJPsi7HM6yIepdxmXkVxAdRDCcwRWc+lsGnki85Fk\n\tBxsl/nLwORtK0tfJjLlEkhVEnbOY6MKQZdSk1iiOU9a7G176yOEvsHRmI7pFbbLo9j\n\tpBINcgcddCsZ+KUWJsBgN3Kx0sz+K/jcf/aohohY=","Reply-To":"kieran.bingham@ideasonboard.com","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20190129020048.16774-1-niklas.soderlund@ragnatech.se>\n\t<20190129020048.16774-4-niklas.soderlund@ragnatech.se>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<3b181385-a184-45f2-af2c-b7413835aae9@ideasonboard.com>","Date":"Tue, 29 Jan 2019 09:51:54 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.2.1","MIME-Version":"1.0","In-Reply-To":"<20190129020048.16774-4-niklas.soderlund@ragnatech.se>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v4 3/6] libcamera: camera: Add\n\tacquire() and release()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 29 Jan 2019 09:51:57 -0000"}},{"id":682,"web_url":"https://patchwork.libcamera.org/comment/682/","msgid":"<20190129131551.GC19527@bigcity.dyn.berto.se>","date":"2019-01-29T13:15:51","subject":"Re: [libcamera-devel] [PATCH v4 3/6] libcamera: camera: Add\n\tacquire() and release()","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nThanks for your feedback.\n\nOn 2019-01-29 09:51:54 +0000, Kieran Bingham wrote:\n> Hi Niklas, (/Laurent,)\n> \n> On 29/01/2019 02:00, Niklas Söderlund wrote:\n> > From: Laurent Pinchart \n> > \n> > Exclusive access must be obtained before performing operations that\n> > change the device state. Define an internal flag to track ownership and\n> > provide a means of protecting functions that change device\n> > configuration.\n> > \n> > Signed-off-by: Laurent Pinchart \n> > Reviewed-by: Niklas Söderlund \n> > Signed-off-by: Niklas Söderlund \n> \n> With capitalisation comments considered,\n> \n> Reviewed-by: Kieran Bingham \n\nI have collected your tag while leaving the capitalisation as is for now \n:-) Lets discuss this in patch the first patch in this series and reach \na conclusion if we should capitalise or not. I think whatever we decide \nthere is an opportunity to align this in the existing code.\n\n> \n> \n> \n> > ---\n> > include/libcamera/camera.h | 5 +++++\n> > src/libcamera/camera.cpp | 39 +++++++++++++++++++++++++++++++++++++-\n> > 2 files changed, 43 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\n> > index a2ded62de94814c4..7e358f8c0aa093cf 100644\n> > --- a/include/libcamera/camera.h\n> > +++ b/include/libcamera/camera.h\n> > @@ -29,6 +29,9 @@ public:\n> > \n> > \tSignal disconnected;\n> > \n> > +\tint acquire();\n> > +\tvoid release();\n> > +\n> > private:\n> > \tCamera(PipelineHandler *pipe, const std::string &name);\n> > \t~Camera();\n> > @@ -38,6 +41,8 @@ private:\n> > \n> > \tstd::shared_ptr pipe_;\n> > \tstd::string name_;\n> > +\n> > +\tbool acquired_;\n> > };\n> > \n> > } /* namespace libcamera */\n> > diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> > index 9cec289282e4797b..500976b237bcbd2d 100644\n> > --- a/src/libcamera/camera.cpp\n> > +++ b/src/libcamera/camera.cpp\n> > @@ -102,12 +102,14 @@ const std::string &Camera::name() const\n> > */\n> > \n> > Camera::Camera(PipelineHandler *pipe, const std::string &name)\n> > -\t: pipe_(pipe->shared_from_this()), name_(name)\n> > +\t: pipe_(pipe->shared_from_this()), name_(name), acquired_(false)\n> > {\n> > }\n> > \n> > Camera::~Camera()\n> > {\n> > +\tif (acquired_)\n> > +\t\tLOG(Camera, Error) << \"Removing camera while still in use\";\n> > }\n> > \n> > /**\n> > @@ -127,4 +129,39 @@ void Camera::disconnect()\n> > \tdisconnected.emit(this);\n> > }\n> > \n> > +/**\n> > + * \\brief Acquire the camera device for exclusive access\n> \n> Back on my Doxygen Capitalisation Front....\n> \n> I think we should be capitalising any use of a class name so that\n> Doxygen links the types and makes it clear that we are referencing an\n> object of that type.\n> \n> \n> > + *\n> > + * After opening the device with open(), exclusive access must be obtained\n> > + * before performing operations that change the device state. This function is\n> > + * not blocking, if the device has already been acquired (by the same or another\n> > + * process) the -EBUSY error code is returned.\n> > + *\n> > + * Once exclusive access isn't needed anymore, the device should be released\n> > + * with a call to the release() function.\n> > + *\n> > + * \\todo Implement exclusive access across processes.\n> > + *\n> > + * \\return 0 on success or a negative error code on error.\n> > + */\n> > +int Camera::acquire()\n> > +{\n> > +\tif (acquired_)\n> > +\t\treturn -EBUSY;\n> > +\n> > +\tacquired_ = true;\n> > +\treturn 0;\n> > +}\n> > +\n> > +/**\n> > + * \\brief Release exclusive access to the camera device\n> \n> s/camera/Camera/\n> \n> > + *\n> > + * Releasing the camera device allows other users to acquire exclusive access\n> \n> s/camera/Camera/\n> \n> > + * with the acquire() function.\n> > + */\n> > +void Camera::release()\n> > +{\n> > +\tacquired_ = false;\n> > +}\n> > +\n> > } /* namespace libcamera */\n> > \n> \n> -- \n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","Received":["from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9BB4560DB6\n\tfor ;\n\tTue, 29 Jan 2019 14:15:53 +0100 (CET)","by mail-lf1-x141.google.com with SMTP id c16so14570829lfj.8\n\tfor ;\n\tTue, 29 Jan 2019 05:15:53 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tm4-v6sm3442174ljb.58.2019.01.29.05.15.51\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 29 Jan 2019 05:15:52 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=99QOzvkt+lzUyH5xwoWM3cttt4AWGAMOadQgVMPpqlk=;\n\tb=TnlVAkHdaC7yFCae/SvVsMkD7gsELwHQnBGwUf29bUPu6ppHhfu4H+fdAXNKo783LW\n\tVCaeRkFIxlnYjACAkruYvqO1RS1PN4HN3hC+1V7+EhAMwTBng9O7C8F9/ppyjRIaGhBl\n\tIV+XhOUrXA8B+6+U78lPpOs+VDGG3lXh0B0anRK5ZLmpmWYJHREIq0XjFAB3s0I9wyez\n\tBK8aNmhTBeEmb8R5nqZB+VGkclbC46y9bDh08gjYwUjTjY9H/TuUQc080qaIxderOz8s\n\tqHlfoOXPhJUqwoggk1gXiwAY/r7ssrS82CzPftUSj/fmgbPSzMn+ou729VjnjvMEH1RY\n\tlRvA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=99QOzvkt+lzUyH5xwoWM3cttt4AWGAMOadQgVMPpqlk=;\n\tb=BQcqOQbXZxN0XfhGrqtS8NItszNaR9ZJgJQHowxR+7Kezjrnz6vy5/KJWtRXgGQbAF\n\t8tF4ELaBqkUQ7h014nQBgT3b7X8z2nFG3U+QWNR5hn6iVKvEtnNpKMMCboJ6wo4nbJ2h\n\tWb0Gqn+AcuKSv16PepaDGbl5jo+7ehrTwSLbGNLftcGiBBX6A2fZ+wRg/AUoI4acjWTC\n\tLICvdrtQPykV5TKbLgJ/LxipFirGABjpQfUkbivmIvRJcOdc1H3WLvc2wZD0oDCYBJin\n\tEGjjQS90sL3lJH4aIWWZ8c4RD7wBZhkTdOho+OAPlTDq9vMmKMEHeemJe6jC3YzWttQX\n\tyrnw==","X-Gm-Message-State":"AJcUukftvAKUK4Npewt7js6EWOvTIzHlFezDSVsogd/F4tdBii1Xm5GE\n\tcu4R6EnoUWXdhLmREUYi+s1NX6Tb4nc=","X-Google-Smtp-Source":"ALg8bN5JEzoeoP9vcLb5zzNWAhAidfwJgmE/oSJyZBG106Wtu0U1JzLlEWQLpbWNyCM7KbAIEG4fRA==","X-Received":"by 2002:a19:7919:: with SMTP id\n\tu25mr20835837lfc.18.1548767752813; \n\tTue, 29 Jan 2019 05:15:52 -0800 (PST)","Date":"Tue, 29 Jan 2019 14:15:51 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190129131551.GC19527@bigcity.dyn.berto.se>","References":"<20190129020048.16774-1-niklas.soderlund@ragnatech.se>\n\t<20190129020048.16774-4-niklas.soderlund@ragnatech.se>\n\t<3b181385-a184-45f2-af2c-b7413835aae9@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<3b181385-a184-45f2-af2c-b7413835aae9@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v4 3/6] libcamera: camera: Add\n\tacquire() and release()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 29 Jan 2019 13:15:53 -0000"}}]