[{"id":675,"web_url":"https://patchwork.libcamera.org/comment/675/","msgid":"<2bc0e6b4-82fe-fda3-1786-d98fbf4d6926@ideasonboard.com>","date":"2019-01-29T09:45:22","subject":"Re: [libcamera-devel] [PATCH v4 1/6] libcamera: stream: add initial\n\tStream class","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nOn 29/01/2019 02:00, Niklas Söderlund wrote:\n> Add an initial Stream implementation. The idea is that once capability\n> support is added to the library each stream will describe its\n> capabilities using this class. An application will then select one or\n> more streams based on these capabilities and use them to configure the\n> camera and capture.\n> \n> At this stage the Stream class is empty as capabilities are yet to be\n> added. The class is still useful as it will be used to communicate how\n> many streams a Camera object provides.\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Kieran Bingham \n\nSome queries about capitalisation in the Doxygen - but I'm you can\nhandle that however you see fit.\n\n--\nKieran\n\n\n> ---\n> include/libcamera/libcamera.h | 1 +\n> include/libcamera/meson.build | 1 +\n> include/libcamera/stream.h | 18 +++++++++++++\n> src/libcamera/meson.build | 1 +\n> src/libcamera/stream.cpp | 51 +++++++++++++++++++++++++++++++++++\n> 5 files changed, 72 insertions(+)\n> create mode 100644 include/libcamera/stream.h\n> create mode 100644 src/libcamera/stream.cpp\n> \n> diff --git a/include/libcamera/libcamera.h b/include/libcamera/libcamera.h\n> index c0511cf6d662b63f..272dfd5e4a67d5de 100644\n> --- a/include/libcamera/libcamera.h\n> +++ b/include/libcamera/libcamera.h\n> @@ -12,6 +12,7 @@\n> #include \n> #include \n> #include \n> +#include \n> #include \n> \n> #endif /* __LIBCAMERA_LIBCAMERA_H__ */\n> diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\n> index d7cb55ba4a49e1e8..54a680787e5c17aa 100644\n> --- a/include/libcamera/meson.build\n> +++ b/include/libcamera/meson.build\n> @@ -5,6 +5,7 @@ libcamera_api = files([\n> 'event_notifier.h',\n> 'libcamera.h',\n> 'signal.h',\n> + 'stream.h',\n> 'timer.h',\n> ])\n> \n> diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\n> new file mode 100644\n> index 0000000000000000..4f47d85ed6382b36\n> --- /dev/null\n> +++ b/include/libcamera/stream.h\n> @@ -0,0 +1,18 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2019, Google Inc.\n> + *\n> + * stream.h - Video stream for a Camera\n> + */\n> +#ifndef __LIBCAMERA_STREAM_H__\n> +#define __LIBCAMERA_STREAM_H__\n> +\n> +namespace libcamera {\n> +\n> +class Stream final\n> +{\n> +};\n> +\n> +} /* namespace libcamera */\n> +\n> +#endif /* __LIBCAMERA_STREAM_H__ */\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index f9f25c0ecf1564cc..9f6ff99eebe2f5bc 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -10,6 +10,7 @@ libcamera_sources = files([\n> 'media_object.cpp',\n> 'pipeline_handler.cpp',\n> 'signal.cpp',\n> + 'stream.cpp',\n> 'timer.cpp',\n> 'v4l2_device.cpp',\n> ])\n> diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> new file mode 100644\n> index 0000000000000000..01f4e5008af8ac46\n> --- /dev/null\n> +++ b/src/libcamera/stream.cpp\n> @@ -0,0 +1,51 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2019, Google Inc.\n> + *\n> + * stream.cpp - Video stream for a Camera\n> + */\n> +\n> +#include \n> +\n> +/**\n> + * \\file stream.h\n> + * \\brief Video stream for a Camera\n> + *\n> + * A camera device can provide frames in different resolutions and formats\n\nShould we capitalise 'camera' as it's the name of one of our classes?\n\n\n\n> + * concurrently from a single image source. The Stream class represents\n> + * one of the multiple concurrent streams.\n> + *\n> + * All streams exposed by a camera device share the same image source and are\n\nSame here ? 'Camera'?\n\n> + * thus not fully independent. Parameters related to the image source, such as\n> + * the exposure time or flash control, are common to all streams. Other\n> + * parameters, such as format or resolution, may be specified per-stream,\n> + * depending on the capabilities of the camera device.\n> + *\n> + * Camera devices expose at least one stream, and may expose additional streams\n\nStream? on the same basis?\n\n> + * based on the device capabilities. This can be used, for instance, to\n> + * implement concurrent viewfinder and video capture, or concurrent viewfinder,\n> + * video capture and still image capture.\n> + */\n> +\n> +namespace libcamera {\n> +\n> +/**\n> + * \\class Stream\n> + * \\brief Video stream for a camera\n> + *\n> + * The Stream class models of all static information which are associated\n> + * with a single video stream. Stream are exposed by the Camera object they\n\ns/video stream/video Stream/ ?\n\ns/Stream are exposed by/Streams are exposed by/\n\n> + * belong to.\n> + *\n> + * Some cameras are capable of supplying more then one stream from the same\n\nSome Cameras, ... one Stream ?\n\n> + * video source. In such cases an application can inspect all available streams\n> + * and select the ones that best fit its use case.\n> + *\n> + * \\todo Add capabilities to the stream API. Without this the Stream class only\n> + * serves to reveal how many streams of unknown capabilities a camera supports.\n> + * This in itself is productive as it allows applications to configure and\n> + * capture from one or more streams even if they won't be able to select the\n> + * optimal stream for the task.\n\nI agree - even just for abstraction - it's better to get this in soon to\nmodel the layouts.\n\n\n> + */\n> +\n> +} /* namespace libcamera */\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E8C3D60B2D\n\tfor ;\n\tTue, 29 Jan 2019 10:45:25 +0100 (CET)","from [192.168.0.21]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5A2F085;\n\tTue, 29 Jan 2019 10:45:25 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1548755125;\n\tbh=C+2xFyy+imf4XjYjtV0HKbEJ8C9iCFab0vgHmyoyQ0M=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=X+krTK48sHG4csiCgAIGsfkE24A5L929TJ3OCJS3Yrlo9kB4mCu3AO4sZOk0kxycS\n\tMrajiDnh91UNt2/Lagn7gsPGHuhXuvAJGHd2+VyFSIV/ppg/C/v3cTRMj67gpBab7T\n\ttuEGHhT0DsMEeP1hPp7VmveYREM6FkmifRTVnTLM=","Reply-To":"kieran.bingham@ideasonboard.com","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20190129020048.16774-1-niklas.soderlund@ragnatech.se>\n\t<20190129020048.16774-2-niklas.soderlund@ragnatech.se>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<2bc0e6b4-82fe-fda3-1786-d98fbf4d6926@ideasonboard.com>","Date":"Tue, 29 Jan 2019 09:45:22 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.2.1","MIME-Version":"1.0","In-Reply-To":"<20190129020048.16774-2-niklas.soderlund@ragnatech.se>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v4 1/6] libcamera: stream: add initial\n\tStream class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 29 Jan 2019 09:45:26 -0000"}},{"id":680,"web_url":"https://patchwork.libcamera.org/comment/680/","msgid":"<20190129130947.GA19527@bigcity.dyn.berto.se>","date":"2019-01-29T13:09:47","subject":"Re: [libcamera-devel] [PATCH v4 1/6] libcamera: stream: add initial\n\tStream class","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nThanks for your feedback.\n\nOn 2019-01-29 09:45:22 +0000, Kieran Bingham wrote:\n> Hi Niklas,\n> \n> On 29/01/2019 02:00, Niklas Söderlund wrote:\n> > Add an initial Stream implementation. The idea is that once capability\n> > support is added to the library each stream will describe its\n> > capabilities using this class. An application will then select one or\n> > more streams based on these capabilities and use them to configure the\n> > camera and capture.\n> > \n> > At this stage the Stream class is empty as capabilities are yet to be\n> > added. The class is still useful as it will be used to communicate how\n> > many streams a Camera object provides.\n> > \n> > Signed-off-by: Niklas Söderlund \n> \n> Reviewed-by: Kieran Bingham \n> \n> Some queries about capitalisation in the Doxygen - but I'm you can\n> handle that however you see fit.\n\nI have tried to no capitalise them as I think the text flows nicer. I \nhave no strong feelings in this area and are open to change if that is \nthe consensus. I have left them as is for now.\n\n> \n> --\n> Kieran\n> \n> \n> > ---\n> > include/libcamera/libcamera.h | 1 +\n> > include/libcamera/meson.build | 1 +\n> > include/libcamera/stream.h | 18 +++++++++++++\n> > src/libcamera/meson.build | 1 +\n> > src/libcamera/stream.cpp | 51 +++++++++++++++++++++++++++++++++++\n> > 5 files changed, 72 insertions(+)\n> > create mode 100644 include/libcamera/stream.h\n> > create mode 100644 src/libcamera/stream.cpp\n> > \n> > diff --git a/include/libcamera/libcamera.h b/include/libcamera/libcamera.h\n> > index c0511cf6d662b63f..272dfd5e4a67d5de 100644\n> > --- a/include/libcamera/libcamera.h\n> > +++ b/include/libcamera/libcamera.h\n> > @@ -12,6 +12,7 @@\n> > #include \n> > #include \n> > #include \n> > +#include \n> > #include \n> > \n> > #endif /* __LIBCAMERA_LIBCAMERA_H__ */\n> > diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\n> > index d7cb55ba4a49e1e8..54a680787e5c17aa 100644\n> > --- a/include/libcamera/meson.build\n> > +++ b/include/libcamera/meson.build\n> > @@ -5,6 +5,7 @@ libcamera_api = files([\n> > 'event_notifier.h',\n> > 'libcamera.h',\n> > 'signal.h',\n> > + 'stream.h',\n> > 'timer.h',\n> > ])\n> > \n> > diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\n> > new file mode 100644\n> > index 0000000000000000..4f47d85ed6382b36\n> > --- /dev/null\n> > +++ b/include/libcamera/stream.h\n> > @@ -0,0 +1,18 @@\n> > +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> > +/*\n> > + * Copyright (C) 2019, Google Inc.\n> > + *\n> > + * stream.h - Video stream for a Camera\n> > + */\n> > +#ifndef __LIBCAMERA_STREAM_H__\n> > +#define __LIBCAMERA_STREAM_H__\n> > +\n> > +namespace libcamera {\n> > +\n> > +class Stream final\n> > +{\n> > +};\n> > +\n> > +} /* namespace libcamera */\n> > +\n> > +#endif /* __LIBCAMERA_STREAM_H__ */\n> > diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> > index f9f25c0ecf1564cc..9f6ff99eebe2f5bc 100644\n> > --- a/src/libcamera/meson.build\n> > +++ b/src/libcamera/meson.build\n> > @@ -10,6 +10,7 @@ libcamera_sources = files([\n> > 'media_object.cpp',\n> > 'pipeline_handler.cpp',\n> > 'signal.cpp',\n> > + 'stream.cpp',\n> > 'timer.cpp',\n> > 'v4l2_device.cpp',\n> > ])\n> > diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> > new file mode 100644\n> > index 0000000000000000..01f4e5008af8ac46\n> > --- /dev/null\n> > +++ b/src/libcamera/stream.cpp\n> > @@ -0,0 +1,51 @@\n> > +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> > +/*\n> > + * Copyright (C) 2019, Google Inc.\n> > + *\n> > + * stream.cpp - Video stream for a Camera\n> > + */\n> > +\n> > +#include \n> > +\n> > +/**\n> > + * \\file stream.h\n> > + * \\brief Video stream for a Camera\n> > + *\n> > + * A camera device can provide frames in different resolutions and formats\n> \n> Should we capitalise 'camera' as it's the name of one of our classes?\n> \n> \n> \n> > + * concurrently from a single image source. The Stream class represents\n> > + * one of the multiple concurrent streams.\n> > + *\n> > + * All streams exposed by a camera device share the same image source and are\n> \n> Same here ? 'Camera'?\n> \n> > + * thus not fully independent. Parameters related to the image source, such as\n> > + * the exposure time or flash control, are common to all streams. Other\n> > + * parameters, such as format or resolution, may be specified per-stream,\n> > + * depending on the capabilities of the camera device.\n> > + *\n> > + * Camera devices expose at least one stream, and may expose additional streams\n> \n> Stream? on the same basis?\n> \n> > + * based on the device capabilities. This can be used, for instance, to\n> > + * implement concurrent viewfinder and video capture, or concurrent viewfinder,\n> > + * video capture and still image capture.\n> > + */\n> > +\n> > +namespace libcamera {\n> > +\n> > +/**\n> > + * \\class Stream\n> > + * \\brief Video stream for a camera\n> > + *\n> > + * The Stream class models of all static information which are associated\n> > + * with a single video stream. Stream are exposed by the Camera object they\n> \n> s/video stream/video Stream/ ?\n> \n> s/Stream are exposed by/Streams are exposed by/\n\nThanks!\n\n> \n> > + * belong to.\n> > + *\n> > + * Some cameras are capable of supplying more then one stream from the same\n> \n> Some Cameras, ... one Stream ?\n\ns/Some//.\n\n> \n> > + * video source. In such cases an application can inspect all available streams\n> > + * and select the ones that best fit its use case.\n> > + *\n> > + * \\todo Add capabilities to the stream API. Without this the Stream class only\n> > + * serves to reveal how many streams of unknown capabilities a camera supports.\n> > + * This in itself is productive as it allows applications to configure and\n> > + * capture from one or more streams even if they won't be able to select the\n> > + * optimal stream for the task.\n> \n> I agree - even just for abstraction - it's better to get this in soon to\n> model the layouts.\n> \n> \n> > + */\n> > +\n> > +} /* namespace libcamera */\n> > \n> \n> -- \n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1033C60DB6\n\tfor ;\n\tTue, 29 Jan 2019 14:09:50 +0100 (CET)","by mail-lj1-x243.google.com with SMTP id c19-v6so17416200lja.5\n\tfor ;\n\tTue, 29 Jan 2019 05:09:50 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\th82sm3552954lfg.94.2019.01.29.05.09.47\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 29 Jan 2019 05:09:47 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=G6lL2Fs4PU2Hpda7EjCFn5pmoyTuEOlFt0lygXazJbo=;\n\tb=KPiFY1FsaezQK78J4HHlQE1ECNIamc+EGUgmTIzpesi4u6/CGbl/dP/YfMEuP24i2g\n\tzeD9vtUHnGMZjUobWoiUki2ectlFZ3+PEgrKo+Rnzs5vfhQhEzSpn1zGq0/wfL5wmstv\n\tE8xQBBixqRAks3y1oWWl2UNjy4Y1wpaXnkaryGfAuprFCZzO9xpNVMEAa6dYCVrZErq0\n\t5kopcGwjY0LIl/Z3kVdZ9mdY7zIIzhRNGxlNr7U9u9DCB4ityxD8p/frVbJ0esQvljKU\n\tdl/NZ4XWl9fAMIk0XBu54hbdihwzrrFS/jCl/rbp1muKHMLvYcLAchq0NBcF/sJ323ZD\n\tfMbg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=G6lL2Fs4PU2Hpda7EjCFn5pmoyTuEOlFt0lygXazJbo=;\n\tb=HivqWfg3q5F7Krusl7k7dcK+vrDiHoPjZ4K2JPsbNzkDwCU5pUdUu3SLzUx0SGDBRL\n\tvP4eW+8NKnApZHG15nAzzBxEs0Qi8niJE3VtdEnriroDDmTpndSto5nym7oiY8t+9QJ/\n\tOkdUdRdynHHshK5bbr69wBrL2mkB5dAB7pmP9UifN2pILpwLeIb1rpu1ncELcsZxYZ6J\n\tvgVMaw3zv3ypEv30U0bIhTVoeO0aVLeytgj6D8UOUVg1gQKfDpQ3YPPJP1O2sCb/cMOO\n\t6FfM3xmR5DlE0UoNCW+fkpfm7x+4Qr/d2gyc+PxLGuPJa1ry2kKsKOCgvFBtOQ97Glrg\n\tZyxA==","X-Gm-Message-State":"AJcUukfcNCY1trmr3iVrD7JhFtAcSHlyudeehHujnL/wmLUehRu8kgxq\n\tId6QHElQEqUokV6yUij5zHGp1w==","X-Google-Smtp-Source":"ALg8bN4mNZmBUnhQ3Xzb8ozVJ2i4dPHcsMKY7Stg/iZecrjHv9f9W9jgvixNlo4wB/P8cPy65TnPFQ==","X-Received":"by 2002:a2e:8256:: with SMTP id\n\tj22-v6mr20694375ljh.40.1548767389094; \n\tTue, 29 Jan 2019 05:09:49 -0800 (PST)","Date":"Tue, 29 Jan 2019 14:09:47 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190129130947.GA19527@bigcity.dyn.berto.se>","References":"<20190129020048.16774-1-niklas.soderlund@ragnatech.se>\n\t<20190129020048.16774-2-niklas.soderlund@ragnatech.se>\n\t<2bc0e6b4-82fe-fda3-1786-d98fbf4d6926@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<2bc0e6b4-82fe-fda3-1786-d98fbf4d6926@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v4 1/6] libcamera: stream: add initial\n\tStream class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 29 Jan 2019 13:09:50 -0000"}}]