[{"id":655,"web_url":"https://patchwork.libcamera.org/comment/655/","msgid":"<02e03c4b-3f05-669e-37b2-4d1f77f3de71@ideasonboard.com>","date":"2019-01-28T11:40:05","subject":"Re: [libcamera-devel] [PATCH] clang-format: Set ColumnLimit to 80","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 28/01/2019 11:26, Kieran Bingham wrote:\n> Our maximum column limit is 120 characters, but we will still aim for an 80\n> line boundary where it is possible. The 120 is a limit for exceptions.\n> \n\nIt seems that 80 is the clang-format default - so the fact that this\nColumnLimit is currently set to 0 puzzles me. (This means that\nclang-format will not adjust the line length, unless it breaks some\nother rule)\n\nPerhaps it should at least be set to 120 ?\n\nWas \"ColumnLimit 0\" a default in the file? or an intentional setting?\n\n\n\n> Signed-off-by: Kieran Bingham \n> ---\n> .clang-format | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/.clang-format b/.clang-format\n> index 17eb095bde71..59a61d050e3d 100644\n> --- a/.clang-format\n> +++ b/.clang-format\n> @@ -52,7 +52,7 @@ BreakConstructorInitializersBeforeComma: false\n> #BreakConstructorInitializers: BeforeComma # Unknown to clang-format-4.0\n> BreakAfterJavaFieldAnnotations: false\n> BreakStringLiterals: false\n> -ColumnLimit: 0\n> +ColumnLimit: 80\n> CommentPragmas: '^ IWYU pragma:'\n> #CompactNamespaces: false # Unknown to clang-format-4.0\n> ConstructorInitializerAllOnOneLineOrOnePerLine: false\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6DA6460C6A\n\tfor ;\n\tMon, 28 Jan 2019 12:40:08 +0100 (CET)","from [192.168.0.21]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C618F85;\n\tMon, 28 Jan 2019 12:40:07 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1548675608;\n\tbh=ioyMNfnQQgGlcVjgF7e8UtLMyOCCN+UHwfmddmb0HeA=;\n\th=Reply-To:Subject:To:References:Cc:From:Date:In-Reply-To:From;\n\tb=nJfV5yfyQpdbfF8VRyAaTtnCew5QKfGrL5eo6F3cME2LeTqvAuLmSRnGoHWq5DzcD\n\tY4IRwJQSw/UpasvZL/T9Ys67JMwHn8wgppG+5E1OHbsZy3BVHQT08ZRBoXL74qlhSJ\n\t3mzcaWT3Xn+IPwiIaSSzbAcVa3kuDIOeUTi/MD2w=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Kieran Bingham ,\n\tLaurent Pinchart ","References":"<20190128112633.1714-1-kieran.bingham@ideasonboard.com>","Cc":"LibCamera Devel ","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<02e03c4b-3f05-669e-37b2-4d1f77f3de71@ideasonboard.com>","Date":"Mon, 28 Jan 2019 11:40:05 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.2.1","MIME-Version":"1.0","In-Reply-To":"<20190128112633.1714-1-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] clang-format: Set ColumnLimit to 80","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 28 Jan 2019 11:40:08 -0000"}},{"id":661,"web_url":"https://patchwork.libcamera.org/comment/661/","msgid":"<20190128214249.GA4332@pendragon.ideasonboard.com>","date":"2019-01-28T21:42:49","subject":"Re: [libcamera-devel] [PATCH] clang-format: Set ColumnLimit to 80","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Mon, Jan 28, 2019 at 11:40:05AM +0000, Kieran Bingham wrote:\n> On 28/01/2019 11:26, Kieran Bingham wrote:\n> > Our maximum column limit is 120 characters, but we will still aim for an 80\n> > line boundary where it is possible. The 120 is a limit for exceptions.\n> \n> It seems that 80 is the clang-format default - so the fact that this\n> ColumnLimit is currently set to 0 puzzles me. (This means that\n> clang-format will not adjust the line length, unless it breaks some\n> other rule)\n> \n> Perhaps it should at least be set to 120 ?\n> \n> Was \"ColumnLimit 0\" a default in the file? or an intentional setting?\n\nI tried setting it to 120, but clang-format merged lines smaller than\n120 columns to get as close as possible to the limit, which was clearly\nnot a good idea. I wish there was an option to set 80 as the target and\n120 as an exception, but that doesn't seem to be the case. I went for 0\nto avoid both automatic reformatting to 120 and avoiding numerous\nwarnings (as we have quite a few lines that go over 80 columns). I'm\nfine experimenting with the limit set to 80, but I fear it may result in\ndevelopers breaking lines when they shouldn't.\n\nAcked-by: Laurent Pinchart \n\n> > Signed-off-by: Kieran Bingham \n> > ---\n> > .clang-format | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/.clang-format b/.clang-format\n> > index 17eb095bde71..59a61d050e3d 100644\n> > --- a/.clang-format\n> > +++ b/.clang-format\n> > @@ -52,7 +52,7 @@ BreakConstructorInitializersBeforeComma: false\n> > #BreakConstructorInitializers: BeforeComma # Unknown to clang-format-4.0\n> > BreakAfterJavaFieldAnnotations: false\n> > BreakStringLiterals: false\n> > -ColumnLimit: 0\n> > +ColumnLimit: 80\n> > CommentPragmas: '^ IWYU pragma:'\n> > #CompactNamespaces: false # Unknown to clang-format-4.0\n> > ConstructorInitializerAllOnOneLineOrOnePerLine: false","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED5F560DB7\n\tfor ;\n\tMon, 28 Jan 2019 22:42:53 +0100 (CET)","from pendragon.ideasonboard.com (85-76-73-159-nat.elisa-mobile.fi\n\t[85.76.73.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5ACA785;\n\tMon, 28 Jan 2019 22:42:51 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1548711773;\n\tbh=CK6C7b06vWb3BKbVeYAISuNi70R3t9C0iN3e1ESdMwI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=labfwugDRgI4jBmAIdFlbcVlMHVT8klHa4+DbsQpKY3AtZ900xott0jQ2GvxmKxEJ\n\ti3FnrHtqqQrqvrxaP3wL0+Oe2ygaAizJ0bxHZb+yTzoTAUJS+lgDDQ4H9j/nTDF3LU\n\tTGrgoZx0rau0sUIaknKgJNNHNF6GmpQOSO4emFoY=","Date":"Mon, 28 Jan 2019 23:42:49 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20190128214249.GA4332@pendragon.ideasonboard.com>","References":"<20190128112633.1714-1-kieran.bingham@ideasonboard.com>\n\t<02e03c4b-3f05-669e-37b2-4d1f77f3de71@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<02e03c4b-3f05-669e-37b2-4d1f77f3de71@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] clang-format: Set ColumnLimit to 80","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 28 Jan 2019 21:42:54 -0000"}}]