{"id":423,"url":"https://patchwork.libcamera.org/api/patches/423/?format=json","web_url":"https://patchwork.libcamera.org/patch/423/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190128004109.25860-3-niklas.soderlund@ragnatech.se>","date":"2019-01-28T00:41:05","name":"[libcamera-devel,2/6] cam: options: create a template class for options","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"094a941e9e2db8178e88dfcb451de4b15991a114","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/423/mbox/","series":[{"id":149,"url":"https://patchwork.libcamera.org/api/series/149/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=149","date":"2019-01-28T00:41:03","name":"cam: add --format option to configure a stream","version":1,"mbox":"https://patchwork.libcamera.org/series/149/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/423/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/423/checks/","tags":{},"headers":{"Return-Path":"","Received":["from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CF3F560B2D\n\tfor ;\n\tMon, 28 Jan 2019 01:41:32 +0100 (CET)","from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 67576cce-2295-11e9-911a-0050569116f7;\n\tMon, 28 Jan 2019 01:41:09 +0100 (CET)"],"X-Halon-ID":"67576cce-2295-11e9-911a-0050569116f7","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 28 Jan 2019 01:41:05 +0100","Message-Id":"<20190128004109.25860-3-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20190128004109.25860-1-niklas.soderlund@ragnatech.se>","References":"<20190128004109.25860-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/6] cam: options: create a template class\n\tfor options","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 28 Jan 2019 00:41:33 -0000"},"content":"In preparation to adding more parsers create a template class to hold\nthe parsed information. The rational for making it a template are that\ndifferent parsers can index the options using different data types.\n\nThe OptionsParser index its options using an int while the upcoming\nKeyValyeParser will index its options using strings for example.\n\nSigned-off-by: Niklas Söderlund \n---\n src/cam/options.cpp | 24 ------------------------\n src/cam/options.h | 28 ++++++++++++++++------------\n 2 files changed, 16 insertions(+), 36 deletions(-)","diff":"diff --git a/src/cam/options.cpp b/src/cam/options.cpp\nindex 83601270207b67b3..b24964a8ce413a85 100644\n--- a/src/cam/options.cpp\n+++ b/src/cam/options.cpp\n@@ -166,27 +166,3 @@ void OptionsParser::usage()\n \t\t}\n \t}\n }\n-\n-OptionsParser::Options::Options()\n-{\n-}\n-\n-bool OptionsParser::Options::valid() const\n-{\n-\treturn !values_.empty();\n-}\n-\n-bool OptionsParser::Options::isSet(int opt) const\n-{\n-\treturn values_.find(opt) != values_.end();\n-}\n-\n-const std::string &OptionsParser::Options::operator[](int opt) const\n-{\n-\treturn values_.find(opt)->second;\n-}\n-\n-void OptionsParser::Options::clear()\n-{\n-\tvalues_.clear();\n-}\ndiff --git a/src/cam/options.h b/src/cam/options.h\nindex 491f6a316fffbe5b..a08bfea1ba74c96b 100644\n--- a/src/cam/options.h\n+++ b/src/cam/options.h\n@@ -17,21 +17,25 @@ enum OptionArgument {\n \tArgumentOptional,\n };\n \n+template \n+class OptionsBase\n+{\n+public:\n+\tbool valid() const { return !values_.empty(); };\n+\tbool isSet(T opt) const { return values_.find(opt) != values_.end(); };\n+\tconst std::string &operator[](T opt) const { return values_.find(opt)->second; };\n+\n+private:\n+\tfriend class OptionsParser;\n+\tstd::map values_;\n+\tvoid clear() { values_.clear(); };\n+};\n+\n class OptionsParser\n {\n public:\n-\tclass Options {\n-\tpublic:\n-\t\tOptions();\n-\n-\t\tbool valid() const;\n-\t\tbool isSet(int opt) const;\n-\t\tconst std::string &operator[](int opt) const;\n-\n-\tprivate:\n-\t\tfriend class OptionsParser;\n-\t\tstd::map values_;\n-\t\tvoid clear();\n+\tclass Options : public OptionsBase\n+\t{\n \t};\n \n \tvoid addOption(int opt, const char *help, const char *name = nullptr,\n","prefixes":["libcamera-devel","2/6"]}