{"id":419,"url":"https://patchwork.libcamera.org/api/patches/419/?format=json","web_url":"https://patchwork.libcamera.org/patch/419/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190127144152.9154-1-jacopo@jmondi.org>","date":"2019-01-27T14:41:52","name":"[libcamera-devel] libcamera: v4l2_device: Fix operator= definition","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"2e5f5dca287800d4d04c615d762fcefd1aae09be","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/419/mbox/","series":[{"id":147,"url":"https://patchwork.libcamera.org/api/series/147/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=147","date":"2019-01-27T14:41:52","name":"[libcamera-devel] libcamera: v4l2_device: Fix operator= definition","version":1,"mbox":"https://patchwork.libcamera.org/series/147/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/419/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/419/checks/","tags":{},"headers":{"Return-Path":"<jacopo@jmondi.org>","Received":["from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2300B60C78\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 27 Jan 2019 15:41:44 +0100 (CET)","from uno.homenet.telecomitalia.it\n\t(host20-49-dynamic.18-79-r.retail.telecomitalia.it [79.18.49.20])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 7DF6340007;\n\tSun, 27 Jan 2019 14:41:43 +0000 (UTC)"],"X-Originating-IP":"79.18.49.20","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"libcamera-devel@lists.libcamera.org","Date":"Sun, 27 Jan 2019 15:41:52 +0100","Message-Id":"<20190127144152.9154-1-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.20.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: v4l2_device: Fix operator=\n\tdefinition","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Sun, 27 Jan 2019 14:41:44 -0000"},"content":"While the C++ allows the redefinition of operator= to return an\narbitrary type, it is customary to return a reference to the assigned\nvalue type.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/include/v4l2_device.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n--\n2.20.1","diff":"diff --git a/src/libcamera/include/v4l2_device.h b/src/libcamera/include/v4l2_device.h\nindex 413bb7f..c67ebbf 100644\n--- a/src/libcamera/include/v4l2_device.h\n+++ b/src/libcamera/include/v4l2_device.h\n@@ -62,7 +62,7 @@ public:\n \tV4L2Device(const V4L2Device &) = delete;\n \t~V4L2Device();\n\n-\tvoid operator=(const V4L2Device &) = delete;\n+\tV4L2Device &operator=(const V4L2Device &) = delete;\n\n \tint open();\n \tbool isOpen() const;\n","prefixes":["libcamera-devel"]}