{"id":4187,"url":"https://patchwork.libcamera.org/api/patches/4187/?format=json","web_url":"https://patchwork.libcamera.org/patch/4187/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200623190836.53446-14-paul.elder@ideasonboard.com>","date":"2020-06-23T19:08:27","name":"[libcamera-devel,v3,13/22] v4l2: v4l2_camera_proxy: Disallow dqbuf when not streaming","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e3caa028ed27e5e1584b2f5430b08283a561cbc9","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/4187/mbox/","series":[{"id":1034,"url":"https://patchwork.libcamera.org/api/series/1034/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1034","date":"2020-06-23T19:08:14","name":"Support v4l2-compliance","version":3,"mbox":"https://patchwork.libcamera.org/series/1034/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/4187/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/4187/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 24813609A5\n\tfor ;\n\tTue, 23 Jun 2020 21:09:34 +0200 (CEST)","from jade.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:8147:f2a2:a8c6:9087])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2A3402A9;\n\tTue, 23 Jun 2020 21:09:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"kUV9A4uk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1592939373;\n\tbh=7CsqpJNAdoSYAzELZPfC53gO1IqhowOnp0ri2Jjm20Q=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=kUV9A4ukag4uOirVAhWakMTeC49MzGz/n133YiUKc6m3PSTjnk5vofvIQi/qMREJP\n\tllm0w15ljoxd+jRE9uvbENd2/vh7sOGfhUHJA6EvTYlqgXMOEyUVBYsymS1Ah37jVe\n\tkmYdaIghy+hlGpk7pCra3zzcyYDuFxmGTEDuRZjY=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 24 Jun 2020 04:08:27 +0900","Message-Id":"<20200623190836.53446-14-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200623190836.53446-1-paul.elder@ideasonboard.com>","References":"<20200623190836.53446-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 13/22] v4l2: v4l2_camera_proxy:\n\tDisallow dqbuf when not streaming","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 23 Jun 2020 19:09:34 -0000"},"content":"Make VIDIOC_DQBUF return -EINVAL if the stream is not turned on.\n\nSigned-off-by: Paul Elder \nReviewed-by: Laurent Pinchart \n\n---\nChanges in v3:\n- move isRunning check to after taking lock\n\nNew in v2 (split from \"v4l2: v4l2_camera: Add isRunning()\")\n---\n src/v4l2/v4l2_camera_proxy.cpp | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex 72b21ff..0c7232d 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -585,6 +585,9 @@ int V4L2CameraProxy::vidioc_dqbuf(V4L2CameraFile *file, struct v4l2_buffer *arg)\n \tif (!hasOwnership(file))\n \t\treturn -EBUSY;\n \n+\tif (!vcam_->isRunning())\n+\t\treturn -EINVAL;\n+\n \tif (!validateBufferType(arg->type) ||\n \t !validateMemoryType(arg->memory))\n \t\treturn -EINVAL;\n","prefixes":["libcamera-devel","v3","13/22"]}