[{"id":5361,"web_url":"https://patchwork.libcamera.org/comment/5361/","msgid":"<20200623222812.GK5870@pendragon.ideasonboard.com>","date":"2020-06-23T22:28:12","subject":"Re: [libcamera-devel] [PATCH v3 06/22] v4l2: v4l2_camera_proxy: Set\n\ttimestamp monotonic buffer flag on reqbufs","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Jun 24, 2020 at 04:08:20AM +0900, Paul Elder wrote:\n> Set buffer flag V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC at VIDIOC_REQBUFS\n> after the buffers have been allocated.\n> \n> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com.\n\nWe don't know what time stamp source the camera uses, but for now I\nthink this is fine.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n> New in v3\n> - split from a conglomerate of v4l2-compliance fixes patch\n> ---\n>  src/v4l2/v4l2_camera_proxy.cpp | 1 +\n>  1 file changed, 1 insertion(+)\n> \n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index 5acb036..7d750c0 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -412,6 +412,7 @@ int V4L2CameraProxy::vidioc_reqbufs(V4L2CameraFile *file, struct v4l2_requestbuf\n>  \t\tbuf.memory = V4L2_MEMORY_MMAP;\n>  \t\tbuf.m.offset = i * curV4L2Format_.fmt.pix.sizeimage;\n>  \t\tbuf.index = i;\n> +\t\tbuf.flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;\n>  \n>  \t\tbuffers_[i] = buf;\n>  \t}","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EE656609A5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 24 Jun 2020 00:28:38 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 63C762A9;\n\tWed, 24 Jun 2020 00:28:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"PIwZ62A+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1592951318;\n\tbh=Jnil0NVtFdbQTCU8EUDcrTIp+DF+cd+r99SBOoECxdY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PIwZ62A+T1rylsEZxNDFTguG1GhRXekBVm7IxoMCvLNnde3jBnBREK9x1pOqIHNsm\n\t3a7t8slcf10k454H8McgrZe1WBuG+WG29FcUp666ZaQIWWtaDSR6djgH5BW6XLoa73\n\t3rEbt0LR9ezCDUbG+KSiTkUjyjT5nYg0UMBuwT6U=","Date":"Wed, 24 Jun 2020 01:28:12 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Paul Elder <paul.elder@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200623222812.GK5870@pendragon.ideasonboard.com>","References":"<20200623190836.53446-1-paul.elder@ideasonboard.com>\n\t<20200623190836.53446-7-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200623190836.53446-7-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 06/22] v4l2: v4l2_camera_proxy: Set\n\ttimestamp monotonic buffer flag on reqbufs","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 23 Jun 2020 22:28:39 -0000"}}]