[{"id":634,"web_url":"https://patchwork.libcamera.org/comment/634/","msgid":"<20190127102122.ly4a3l3ofquzt45l@uno.localdomain>","date":"2019-01-27T10:21:22","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: sort forward\n\tdeclarations of classes","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Sun, Jan 27, 2019 at 01:55:34AM +0100, Niklas Söderlund wrote:\n> Signed-off-by: Niklas Söderlund \n\nMy bad, thanks for fixing.\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/include/pipeline_handler.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\n> index ca77a40b96e69b66..080997e22e545e01 100644\n> --- a/src/libcamera/include/pipeline_handler.h\n> +++ b/src/libcamera/include/pipeline_handler.h\n> @@ -14,11 +14,11 @@\n>\n> namespace libcamera {\n>\n> +class Camera;\n> class CameraManager;\n> class DeviceEnumerator;\n> class MediaDevice;\n>\n> -class Camera;\n> class CameraData\n> {\n> public:\n> --\n> 2.20.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D42D260C6A\n\tfor ;\n\tSun, 27 Jan 2019 11:21:14 +0100 (CET)","from uno.localdomain\n\t(host20-49-dynamic.18-79-r.retail.telecomitalia.it [79.18.49.20])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id F360A60006;\n\tSun, 27 Jan 2019 10:21:13 +0000 (UTC)"],"X-Originating-IP":"79.18.49.20","Date":"Sun, 27 Jan 2019 11:21:22 +0100","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190127102122.ly4a3l3ofquzt45l@uno.localdomain>","References":"<20190127005534.21744-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"nqfwpqvvcf7p626r\"","Content-Disposition":"inline","In-Reply-To":"<20190127005534.21744-1-niklas.soderlund@ragnatech.se>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: sort forward\n\tdeclarations of classes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 27 Jan 2019 10:21:15 -0000"}},{"id":637,"web_url":"https://patchwork.libcamera.org/comment/637/","msgid":"<20190127130504.GA19689@bigcity.dyn.berto.se>","date":"2019-01-27T13:05:04","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: sort forward\n\tdeclarations of classes","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nOn 2019-01-27 11:21:22 +0100, Jacopo Mondi wrote:\n> Hi Niklas,\n> \n> On Sun, Jan 27, 2019 at 01:55:34AM +0100, Niklas Söderlund wrote:\n> > Signed-off-by: Niklas Söderlund \n> \n> My bad, thanks for fixing.\n> \n> Reviewed-by: Jacopo Mondi \n\nThanks, pushed.\n\n> \n> Thanks\n> j\n> \n> > ---\n> > src/libcamera/include/pipeline_handler.h | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\n> > index ca77a40b96e69b66..080997e22e545e01 100644\n> > --- a/src/libcamera/include/pipeline_handler.h\n> > +++ b/src/libcamera/include/pipeline_handler.h\n> > @@ -14,11 +14,11 @@\n> >\n> > namespace libcamera {\n> >\n> > +class Camera;\n> > class CameraManager;\n> > class DeviceEnumerator;\n> > class MediaDevice;\n> >\n> > -class Camera;\n> > class CameraData\n> > {\n> > public:\n> > --\n> > 2.20.1\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B65FF60C78\n\tfor ;\n\tSun, 27 Jan 2019 14:05:06 +0100 (CET)","by mail-lf1-x143.google.com with SMTP id n18so9933005lfh.6\n\tfor ;\n\tSun, 27 Jan 2019 05:05:06 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\ty24-v6sm2488962ljd.20.2019.01.27.05.05.04\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSun, 27 Jan 2019 05:05:04 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=boNKNzcescSWZnqeGC6bwvhaOTTAHnwhnwwzv7VWZT0=;\n\tb=dWIDkYl7fK448RvQQ0GFmgdJSPzjjL5a0KQYdW9mAYvdasiVAO3fGO8rTm8AVDXcPy\n\ttpmHR5LPhD2l8ibbhuNBkgC+t+tsj5bPvq8mFth/7N62AAEo3owp6eEEKbCaUgUt1/at\n\tMURZknhhmHrCE5O3GiZeKv4LPrXVM+udnQ/jZ9bWzLak8tpI5k9Lj1g4RCzLoa29M8XT\n\tquI2820hA90jPFe7TP+mmemiEImXWnhGDsgqhJk5s8dUFMiOMSoJO3B1i3JlMERj5SL3\n\tvxu/db/uZyMRoKhQr2fmtl5kHjUsFhL4Mh0j0s0bJzVN2X6N+n/FprkkNk4kLBOBgmko\n\tyR8A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=boNKNzcescSWZnqeGC6bwvhaOTTAHnwhnwwzv7VWZT0=;\n\tb=Fz6/jfAdFpperqvF/d05TtBcbZHfrCIvmlIXCIqOsEfMQQoezRz4xEv5jZMgLQINFh\n\tsKQw1I5zFHoIUSocswViqrr8L1dQvS2P4pKVvrQr4g1HhV9f8V1lvOJ1FTK8big7jKvQ\n\tBro7pYJYhKGUnjhiUwiso849G1PMrDNb/xsSFj4L+/yVGcn8r5u/+ppiNfjQnQQCT02d\n\tf5v6dv1CEvmdALfHFjgMEkwciF8dg1GET6B1zkEMEaRXFZBa3X4vKnv2Y8UlTk9KlYyc\n\tmwPb0qP3Q6XoXhszttrK2tSR1SnfT2xV9gy9v0hdztmLZvKTkf/lD7LS2BE5McC4JZ/z\n\tKp+Q==","X-Gm-Message-State":"AJcUukd3d9t7faNkVEmhZyrMUQImkkWiu8AAoA+GQElkE5WUj96023Pi\n\tFrklEVZfZEjFeXFQ68cKVjgfbw==","X-Google-Smtp-Source":"ALg8bN7GRidoCLrIhC4tgZ3DlKaWme2zhcX789YZIS7vJBQ/aGNQizYISudTsPN3FM/X2N4B4zniGg==","X-Received":"by 2002:a19:9dd1:: with SMTP id\n\tg200mr13620172lfe.127.1548594305741; \n\tSun, 27 Jan 2019 05:05:05 -0800 (PST)","Date":"Sun, 27 Jan 2019 14:05:04 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190127130504.GA19689@bigcity.dyn.berto.se>","References":"<20190127005534.21744-1-niklas.soderlund@ragnatech.se>\n\t<20190127102122.ly4a3l3ofquzt45l@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190127102122.ly4a3l3ofquzt45l@uno.localdomain>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: sort forward\n\tdeclarations of classes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 27 Jan 2019 13:05:07 -0000"}}]