[{"id":5360,"web_url":"https://patchwork.libcamera.org/comment/5360/","msgid":"<20200623222713.GJ5870@pendragon.ideasonboard.com>","date":"2020-06-23T22:27:13","subject":"Re: [libcamera-devel] [PATCH v3 05/22] v4l2: v4l2_camera_proxy:\n\tClear reserved field in reqbufs","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Jun 24, 2020 at 04:08:19AM +0900, Paul Elder wrote:\n> Clear the reserved field in arg struct v4l2_reqbuffers of\n> VIDIOC_REQBUFS.\n> \n> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n> New in v3\n> - split from a conglomerate of v4l2-compliance fixes patch\n> ---\n>  src/v4l2/v4l2_camera_proxy.cpp | 1 +\n>  1 file changed, 1 insertion(+)\n> \n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index 7262453..5acb036 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -355,6 +355,7 @@ int V4L2CameraProxy::vidioc_reqbufs(V4L2CameraFile *file, struct v4l2_requestbuf\n>  \t\treturn ret;\n>  \n>  \targ->capabilities = V4L2_BUF_CAP_SUPPORTS_MMAP;\n> +\tmemset(arg->reserved, 0, sizeof(arg->reserved));\n>  \n>  \tif (arg->count == 0) {\n>  \t\trelease(file);","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 081BA609A5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 24 Jun 2020 00:27:41 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2B2772A9;\n\tWed, 24 Jun 2020 00:27:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"URrxFOaw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1592951260;\n\tbh=bifXZUb/mdHZ5kbCwr/XnY1UKntv4JPNI28qIoarXQA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=URrxFOawGrSFEee8I3Dfgx+TDf+31Nk4s/+qAJ/UaMSSxKGkh910LHYtSkVVAFsiM\n\t/TSqWZNZN/xbYWDnUIzwdOkGa6GPgc7xPiIVrolQ3qphzt9Oc8Kqpn8720MoaeH4+5\n\t8HWVHc5q2q93ZbnBYJ+Y7XCxxD9ZHU7SP8ggweOw=","Date":"Wed, 24 Jun 2020 01:27:13 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Paul Elder <paul.elder@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200623222713.GJ5870@pendragon.ideasonboard.com>","References":"<20200623190836.53446-1-paul.elder@ideasonboard.com>\n\t<20200623190836.53446-6-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200623190836.53446-6-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 05/22] v4l2: v4l2_camera_proxy:\n\tClear reserved field in reqbufs","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 23 Jun 2020 22:27:41 -0000"}}]