{"id":4159,"url":"https://patchwork.libcamera.org/api/patches/4159/?format=json","web_url":"https://patchwork.libcamera.org/patch/4159/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200623164224.44476-2-jacopo@jmondi.org>","date":"2020-06-23T16:42:21","name":"[libcamera-devel,12/25] media: ov5647: Protect s_stream() with mutex","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"5b6dd23c9f5e58839d18c393f0c8d2dc74007171","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":{"id":15,"url":"https://patchwork.libcamera.org/api/users/15/?format=json","username":"jmondi","first_name":"Jacopo","last_name":"Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/patch/4159/mbox/","series":[{"id":1030,"url":"https://patchwork.libcamera.org/api/series/1030/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1030","date":"2020-06-23T10:07:50","name":"media: ov5647: Support RaspberryPi Camera Module v1","version":1,"mbox":"https://patchwork.libcamera.org/series/1030/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/4159/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/4159/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BDA3160103\n\tfor ;\n\tTue, 23 Jun 2020 18:39:14 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 7FB556000E;\n\tTue, 23 Jun 2020 16:39:11 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi ","To":"mchehab@kernel.org, sakari.ailus@linux.intel.com, hverkuil@xs4all.nl,\n\tlaurent.pinchart@ideasonboard.com, roman.kovalivskyi@globallogic.com, \n\tdave.stevenson@raspberrypi.org, naush@raspberrypi.com","Cc":"mrodin@de.adit-jv.com, hugues.fruchet@st.com, mripard@kernel.org,\n\taford173@gmail.com, sudipi@jp.adit-jv.com, andrew_gabbasov@mentor.com,\n\terosca@de.adit-jv.com, linux-media@vger.kernel.org,\n\tlibcamera-devel@lists.libcamera.org, Jacopo Mondi ","Date":"Tue, 23 Jun 2020 18:42:21 +0200","Message-Id":"<20200623164224.44476-2-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200623100815.10674-1-jacopo@jmondi.org>","References":"<20200623100815.10674-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 12/25] media: ov5647: Protect s_stream()\n\twith mutex","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 23 Jun 2020 16:39:14 -0000"},"content":"Use the driver mutex to protect s_stream() operations.\nThis will become more relevant once the sensor will support more formats\nand set_format() could be issue concurrently to s_stream().\n\nSigned-off-by: Jacopo Mondi \n---\n drivers/media/i2c/ov5647.c | 11 +++++++++--\n 1 file changed, 9 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/media/i2c/ov5647.c b/drivers/media/i2c/ov5647.c\nindex 859cc5b0d14a3..2d2829f934c3c 100644\n--- a/drivers/media/i2c/ov5647.c\n+++ b/drivers/media/i2c/ov5647.c\n@@ -460,10 +460,17 @@ static const struct v4l2_subdev_core_ops ov5647_subdev_core_ops = {\n \n static int ov5647_s_stream(struct v4l2_subdev *sd, int enable)\n {\n+\tstruct ov5647 *sensor = to_state(sd);\n+\tint ret;\n+\n+\tmutex_lock(&sensor->lock);\n \tif (enable)\n-\t\treturn ov5647_stream_on(sd);\n+\t\tret = ov5647_stream_on(sd);\n \telse\n-\t\treturn ov5647_stream_off(sd);\n+\t\tret = ov5647_stream_off(sd);\n+\tmutex_unlock(&sensor->lock);\n+\n+\treturn ret;\n }\n \n static const struct v4l2_subdev_video_ops ov5647_subdev_video_ops = {\n","prefixes":["libcamera-devel","12/25"]}