[{"id":5355,"web_url":"https://patchwork.libcamera.org/comment/5355/","msgid":"","date":"2020-06-23T17:38:07","subject":"Re: [libcamera-devel] [PATCH] Fix incorrect method in cameradata\n\tdocs","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/","name":"Umang Jain","email":"email@uajain.com"},"content":"Hi Chris,\n\nDid you re-send this patch by mistake? It's identical with the patch\nyou sent on 6/15/2020.\n\nWhen you re-send the patch, you need to also mention that the patch is\nthe second (or third, fourth ...) iteration of the initial patch.\nYou can do that by adding \"-v2\" to \"git format-patch ...\" commandline\nto denote that it's the second version of that patch.\n\nAlso, since you got Reviewed-by tags by me and Laurent, you need to collect\nthem too and add it to your commit message while re-sending them for the\nsecond round of review.\n\nOn 6/23/20 4:27 PM, chris@gregariousmammal.com wrote:\n> From: Chris Chinchilla \n>\n> Fix incorrect method in cameradata docs\n>\n> Fixes: b581b9576abd (\"libcamera: pipeline_handler: Make pipeline-specific data mandatory\")\n> Signed-off-by: Chris Chinchilla \n> ---\n> src/libcamera/pipeline_handler.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index 14dfba0..15cdc17 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -46,7 +46,7 @@ LOG_DEFINE_CATEGORY(Pipeline)\n> *\n> * Pipeline handlers are expected to extend this base class with platform\n> * specific implementation, associate instances of the derived classes\n> - * using the setCameraData() method, and access them at a later time\n> + * using the registerCamera() method, and access them at a later time\n> * with cameraData().\n> */\n>","headers":{"Return-Path":"","Received":["from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A1BB6603BB\n\tfor ;\n\tTue, 23 Jun 2020 19:38:09 +0200 (CEST)","by filterdrecv-p3iad2-7657dd94f-bnqcb with SMTP id\n\tfilterdrecv-p3iad2-7657dd94f-bnqcb-19-5EF23DFF-54\n\t2020-06-23 17:38:07.817628611 +0000 UTC m=+430543.146215994","from mail.uajain.com (unknown)\n\tby ismtpd0003p1maa1.sendgrid.net (SG) with ESMTP\n\tid PtfQ2VT8QJqLfuU3u0lfzA Tue, 23 Jun 2020 17:38:07.370 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=uajain.com\n\theader.i=@uajain.com header.b=\"qu/48dvY\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=subject:references:from:mime-version:in-reply-to:to:content-type:\n\tcontent-transfer-encoding;\n\ts=s1; bh=TZ7H0qe7nqXLw1+KqR0fN42DemRurnRwoeVSI2fShFI=;\n\tb=qu/48dvYJS/P2d/pM0PudqdHM8M8EamFCB9Ke6JgUQ4pj9Ppiue16AsBYBsaxuWNA8Iz\n\tIc2eaT0TsTaKEziDvxPyWYJ4N9yhm7swAIw4G9VBNahCWJ036pEf/aNXVwI5jQIn7Kmgwh\n\tGDN4Y+1cJfurGweuhkbWlFl2D0Ds3RML4=","References":"<20200623105730.26956-1-chris@gregariousmammal.com>","From":"Umang Jain ","Message-ID":"","Date":"Tue, 23 Jun 2020 17:38:07 +0000 (UTC)","Mime-Version":"1.0","In-Reply-To":"<20200623105730.26956-1-chris@gregariousmammal.com>","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcYDswUgqLHty1lirORaEntQI/zHdB6mD+DLr1TGyAuFPT+SfzUZcNGmSlfqqVlbPglKjpeoQet1pYNm0q9BYm1wwldYrQxl+SNQsD+7i+AFSlxrFpk4QiXtf3t6ZxUOWJ90NHG3Dj5Gp1/7KZ0jigJz7IentIZmcNPXQf0aJFW6gxdcFPjnde3Up22YAUBjpaYxdYSmeoBePES0NmaBoM1A==","To":"chris@gregariousmammal.com, libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=us-ascii; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] Fix incorrect method in cameradata\n\tdocs","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 23 Jun 2020 17:38:10 -0000"}},{"id":5412,"web_url":"https://patchwork.libcamera.org/comment/5412/","msgid":"<603ee9f2-eab8-49e2-8ba2-c353063678d8@Spark>","date":"2020-06-25T08:33:03","subject":"Re: [libcamera-devel] [PATCH] Fix incorrect method in cameradata\n\tdocs","submitter":{"id":55,"url":"https://patchwork.libcamera.org/api/people/55/","name":"Chris Chinchilla","email":"chris@gregariousmammal.com"},"content":"Yes, I resent it as people told me it was missing tags :)\n\nSo it’s missing more tags now? I admit, I didn’t see the reviewed by tags appear anywhere.\n\nSo to clarify, to get this right, I need to resend again with a v3 and add reviewed by tags?\n\nChris\nOn 23 Jun 2020, 19:38 +0200, Umang Jain , wrote:\n> Hi Chris,\n>\n> Did you re-send this patch by mistake? It's identical with the patch\n> you sent on 6/15/2020.\n>\n> When you re-send the patch, you need to also mention that the patch is\n> the second (or third, fourth ...) iteration of the initial patch.\n> You can do that by adding \"-v2\" to \"git format-patch ...\" commandline\n> to denote that it's the second version of that patch.\n>\n> Also, since you got Reviewed-by tags by me and Laurent, you need to collect\n> them too and add it to your commit message while re-sending them for the\n> second round of review.\n>\n> On 6/23/20 4:27 PM, chris@gregariousmammal.com wrote:\n> > From: Chris Chinchilla \n> >\n> > Fix incorrect method in cameradata docs\n> >\n> > Fixes: b581b9576abd (\"libcamera: pipeline_handler: Make pipeline-specific data mandatory\")\n> > Signed-off-by: Chris Chinchilla \n> > ---\n> > src/libcamera/pipeline_handler.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> > index 14dfba0..15cdc17 100644\n> > --- a/src/libcamera/pipeline_handler.cpp\n> > +++ b/src/libcamera/pipeline_handler.cpp\n> > @@ -46,7 +46,7 @@ LOG_DEFINE_CATEGORY(Pipeline)\n> > *\n> > * Pipeline handlers are expected to extend this base class with platform\n> > * specific implementation, associate instances of the derived classes\n> > - * using the setCameraData() method, and access them at a later time\n> > + * using the registerCamera() method, and access them at a later time\n> > * with cameraData().\n> > */\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C3E64C0100\n\tfor ;\n\tThu, 25 Jun 2020 08:33:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 30109609C3;\n\tThu, 25 Jun 2020 10:33:18 +0200 (CEST)","from mail-ed1-x534.google.com (mail-ed1-x534.google.com\n\t[IPv6:2a00:1450:4864:20::534])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E580A603BE\n\tfor ;\n\tThu, 25 Jun 2020 10:33:15 +0200 (CEST)","by mail-ed1-x534.google.com with SMTP id a8so2312595edy.1\n\tfor ;\n\tThu, 25 Jun 2020 01:33:15 -0700 (PDT)","from [192.168.1.75] (ip5b40d234.dynamic.kabel-deutschland.de.\n\t[91.64.210.52]) by smtp.gmail.com with ESMTPSA id\n\tx16sm9323019edl.82.2020.06.25.01.33.14\n\t(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 25 Jun 2020 01:33:14 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gregariousmammal.com\n\theader.i=@gregariousmammal.com header.b=\"huwsi7n2\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gregariousmammal.com; s=google;\n\th=date:from:to:message-id:in-reply-to:references:subject:mime-version;\n\tbh=oVuHR8JEsXwR+kMGH7ks9S17ceGUYjZ75Nt1B+6Oon4=;\n\tb=huwsi7n2OHs0bkUsY8EBG7eXeDbtlYi83e8+LOG036eTic81XiinCU6IcYT5AOQcQY\n\t60dthXQW207pc+6nEtE1QDuvzZr5wVt2ynNMXHmdDS5PAizgKX3qBAmAxofK+kJQRUUP\n\t+2JitKHekKKa96C2FRW0krTwD/Ss8jhHqUDD1aLox2ev3TEknC1KrSQrXzcFvJELlhLV\n\t5UnxQ9l6OL2EDzDYIVRgTxRWkGbPiBkXmqOe4xvirpxoquYnw5dnXOrs46FqiRdJNFQ+\n\t+MmkZNmU2P/jh2JosQ3rrEux+uczy/5JsWtOKpSMg1wmQ84mFwTd+tK67qPg1qMNOqzI\n\t73ng==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:message-id:in-reply-to:references\n\t:subject:mime-version;\n\tbh=oVuHR8JEsXwR+kMGH7ks9S17ceGUYjZ75Nt1B+6Oon4=;\n\tb=RpuTKa8qHj1LYBwapwzSjG6YsEEXDzCzlNiwKICkTayGW77TCQaHNjQJdIl3U4gIXw\n\t/lfKKhraeT4z97bIru1cbWI+3U/s/HrABuyhJOd/Nml5rzO2pHVczqdqGY3c6muA5bOI\n\tH1AgJDuEMN39E6RYPJt3+HhmUi9Hpe9Pr1N8EcN1h5EOOrFx7VjlNdR902YFSIrkz4WS\n\tFmvBJEgMFP6aVJ34SQunxr/D6K0ZykA6+h6Rf6AMUb92oKrh1wHhFir3dAxUY4TKUp1k\n\tdD8wU1kwMxMkrHkCdPlK9zp03iC2rUXGhHRQL8E54SA8a0+XiJojFc+/sWpi1esLLLaG\n\t8vuA==","X-Gm-Message-State":"AOAM530odFHZDuhGt4RorWlb8ErJ1VYFSsQ8jsk9xBxbtw3U5dFQ0Rox\n\tuXFL8ZPfqWVVL7O750S4/YBL3TmQMMQFzQ==","X-Google-Smtp-Source":"ABdhPJxBKQt/yiyqolI46QiyxqUSR8uM65d2xHfj5JnIOss0lL+SzCkAgDYuxkCFVmHtpunT3GAWwg==","X-Received":"by 2002:a50:d80f:: with SMTP id\n\to15mr13129107edj.156.1593073995142; \n\tThu, 25 Jun 2020 01:33:15 -0700 (PDT)","Date":"Thu, 25 Jun 2020 10:33:03 +0200","From":"Chris Chinchilla ","To":"libcamera-devel@lists.libcamera.org, Umang Jain ","Message-ID":"<603ee9f2-eab8-49e2-8ba2-c353063678d8@Spark>","In-Reply-To":"","References":"<20200623105730.26956-1-chris@gregariousmammal.com>\n\t","X-Readdle-Message-ID":"603ee9f2-eab8-49e2-8ba2-c353063678d8@Spark","MIME-Version":"1.0","Subject":"Re: [libcamera-devel] [PATCH] Fix incorrect method in cameradata\n\tdocs","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============3243287282091608431==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":5414,"web_url":"https://patchwork.libcamera.org/comment/5414/","msgid":"","date":"2020-06-25T08:51:37","subject":"Re: [libcamera-devel] [PATCH] Fix incorrect method in cameradata\n\tdocs","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Chris,\n\nOn 25/06/2020 09:33, Chris Chinchilla wrote:\n> Yes, I resent it as people told me it was missing tags :)\n> \n> So it’s missing more tags now? I admit, I didn’t see the reviewed by\n> tags appear anywhere.\n> \n> So to clarify, to get this right, I need to resend again with a v3 and\n> add reviewed by tags?\n\nNo need to resend, I can add the tags when applying.\n\nThe Reviewed-by: tags were given to you via e-mail in reply to your\nprevious post.\n\nWhen posting a revised version of a patch, usually the patch author\nwould collect previously given tags, because tags mean integration.\n\nAlso when posting a second version of a patch, you can mark it with an\nincreased version number, so this would be:\n\n [PATCH v2] Fix incorrect method in cameradata docs\n\nWhen you save the patch with git, you can specify the version to do that\nautomatically, just add a '-v2' (or '-'v3'...) to the command\n\n git format-patch -1 -v2\n\nThe file names of the patches generated will be prefixed with the\nversion number.\n\n\nBut, this patch has already got two Reviewed-by: tags, and the commit\nmessage has been fixed up according to the previous comments.\n\nSo I'll add the Reviewed-by: (RB) tags and integrate (unless someone\nalready has...)\n\n--\nThanks\n\nKieran\n\n\n\n\n> \n> Chris\n> On 23 Jun 2020, 19:38 +0200, Umang Jain , wrote:\n>> Hi Chris,\n>>\n>> Did you re-send this patch by mistake? It's identical with the patch\n>> you sent on 6/15/2020.\n>>\n>> When you re-send the patch, you need to also mention that the patch is\n>> the second (or third, fourth ...) iteration of the initial patch.\n>> You can do that by adding \"-v2\" to \"git format-patch ...\" commandline\n>> to denote that it's the second version of that patch.\n>>\n>> Also, since you got Reviewed-by tags by me and Laurent, you need to\n>> collect\n>> them too and add it to your commit message while re-sending them for the\n>> second round of review.\n>>\n>> On 6/23/20 4:27 PM, chris@gregariousmammal.com wrote:\n>>> From: Chris Chinchilla \n>>>\n>>> Fix incorrect method in cameradata docs\n>>>\n>>> Fixes: b581b9576abd (\"libcamera: pipeline_handler: Make\n>>> pipeline-specific data mandatory\")\n>>> Signed-off-by: Chris Chinchilla \n>>> ---\n>>> src/libcamera/pipeline_handler.cpp | 2 +-\n>>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>>\n>>> diff --git a/src/libcamera/pipeline_handler.cpp\n>>> b/src/libcamera/pipeline_handler.cpp\n>>> index 14dfba0..15cdc17 100644\n>>> --- a/src/libcamera/pipeline_handler.cpp\n>>> +++ b/src/libcamera/pipeline_handler.cpp\n>>> @@ -46,7 +46,7 @@ LOG_DEFINE_CATEGORY(Pipeline)\n>>> *\n>>> * Pipeline handlers are expected to extend this base class with platform\n>>> * specific implementation, associate instances of the derived classes\n>>> - * using the setCameraData() method, and access them at a later time\n>>> + * using the registerCamera() method, and access them at a later time\n>>> * with cameraData().\n>>> */\n>>>\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3836FC0100\n\tfor ;\n\tThu, 25 Jun 2020 08:51:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C15AC609B3;\n\tThu, 25 Jun 2020 10:51:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 03130609A3\n\tfor ;\n\tThu, 25 Jun 2020 10:51:41 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 43D93521;\n\tThu, 25 Jun 2020 10:51:40 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qZTNtnQv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593075100;\n\tbh=7R947t2r3mSp7FiGcivOQ5iPK7G+8z3oNczzxSJSKqw=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=qZTNtnQvNhNF4s2sDjmlZapB6Xcs9BdULmdgt50xTs+n1yB5gs6RzI6GTnoWDgq6w\n\tANfqyIcLhaAzoQHNBr8DT8J9b5KIZUxFQ84qXnKqrMcAtPwrbLwonvxn60/Z6ElBcc\n\t3U9UY065muB2CVn2IwC2kgQerqPkDyFH1oB4uABw=","To":"Chris Chinchilla ,\n\tlibcamera-devel@lists.libcamera.org, Umang Jain ","References":"<20200623105730.26956-1-chris@gregariousmammal.com>\n\t\n\t<603ee9f2-eab8-49e2-8ba2-c353063678d8@Spark>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Thu, 25 Jun 2020 09:51:37 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.8.0","MIME-Version":"1.0","In-Reply-To":"<603ee9f2-eab8-49e2-8ba2-c353063678d8@Spark>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] Fix incorrect method in cameradata\n\tdocs","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"windows-1252\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":5415,"web_url":"https://patchwork.libcamera.org/comment/5415/","msgid":"<35c961bc-3807-6cf0-bb79-1008b6b980ca@uajain.com>","date":"2020-06-25T08:53:49","subject":"Re: [libcamera-devel] [PATCH] Fix incorrect method in cameradata\n\tdocs","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/","name":"Umang Jain","email":"email@uajain.com"},"content":"Hi Chris,\n\nOn 6/25/20 2:03 PM, Chris Chinchilla wrote:\n> Yes, I resent it as people told me it was missing tags :)\n>\n> So it’s missing more tags now? I admit, I didn’t see the reviewed by \n> tags appear anywhere.\nDid you see commit history in libcamera git repo?\n\n$ cd /path/to/libcamera/repo\n$ git log\n\nSee couple of commits and their messages:\n\nThey will have:\n* Signed-off-by tag - This generally belongs to the author of the commit\n* Reviewed-by tag - This is to denote who reviewed your commit.\n\nObviously, v1 won't have any Reviewed-by tags. So, when from submit next \nversion (v2, v3...)\nYou need to append the commit message, if you have got \"Reviewed-by\" tag \nby the reviewer\nwhen they reviewed our patches on the mailing list.\n\nYou need 2-or-more \"Reviewed-by tags\" to get your patches merged.\nThis is not a hard rule but that's  what I have been told :)\n\n>\n> So to clarify, to get this right, I need to resend again with a v3 and \n> add reviewed by tags?\nYes, apart from the fixes pointed out in the last review (if any), you \nneed to send a next version (v3),\nmaking sure it has signoff and reviewed-by tags included from the \nreview. This is generic workflow.\n\nSince, I checked, this particular patch acutally fixes an old commit, \nyou need to specify: \"Fixes: \"\ntag as mentioned in the previous review. So in total, you will have 1 \n\"Fixes: \" tag, 1 Signoff tag\nand 2 Reviewed-by tags (mine and Laurent's).\n\nHope I have made this clear. Please feel free to reach out if you have \nany more questions.\n>\n> Chris\n> On 23 Jun 2020, 19:38 +0200, Umang Jain , wrote:\n>> Hi Chris,\n>>\n>> Did you re-send this patch by mistake? It's identical with the patch\n>> you sent on 6/15/2020.\n>>\n>> When you re-send the patch, you need to also mention that the patch is\n>> the second (or third, fourth ...) iteration of the initial patch.\n>> You can do that by adding \"-v2\" to \"git format-patch ...\" commandline\n>> to denote that it's the second version of that patch.\n>>\n>> Also, since you got Reviewed-by tags by me and Laurent, you need to \n>> collect\n>> them too and add it to your commit message while re-sending them for the\n>> second round of review.\n>>\n>> On 6/23/20 4:27 PM, chris@gregariousmammal.com wrote:\n>>> From: Chris Chinchilla \n>>>\n>>> Fix incorrect method in cameradata docs\n>>>\n>>> Fixes: b581b9576abd (\"libcamera: pipeline_handler: Make \n>>> pipeline-specific data mandatory\")\n>>> Signed-off-by: Chris Chinchilla \n>>> ---\n>>> src/libcamera/pipeline_handler.cpp | 2 +-\n>>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>>\n>>> diff --git a/src/libcamera/pipeline_handler.cpp \n>>> b/src/libcamera/pipeline_handler.cpp\n>>> index 14dfba0..15cdc17 100644\n>>> --- a/src/libcamera/pipeline_handler.cpp\n>>> +++ b/src/libcamera/pipeline_handler.cpp\n>>> @@ -46,7 +46,7 @@ LOG_DEFINE_CATEGORY(Pipeline)\n>>> *\n>>> * Pipeline handlers are expected to extend this base class with platform\n>>> * specific implementation, associate instances of the derived classes\n>>> - * using the setCameraData() method, and access them at a later time\n>>> + * using the registerCamera() method, and access them at a later time\n>>> * with cameraData().\n>>> */\n>>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DBCE1C0100\n\tfor ;\n\tThu, 25 Jun 2020 08:53:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 482C7609B3;\n\tThu, 25 Jun 2020 10:53:52 +0200 (CEST)","from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F953609A3\n\tfor ;\n\tThu, 25 Jun 2020 10:53:50 +0200 (CEST)","by filter0104p3las1.sendgrid.net with SMTP id\n\tfilter0104p3las1-24739-5EF4661C-AA\n\t2020-06-25 08:53:48.988227236 +0000 UTC m=+569882.032061484","from mail.uajain.com (unknown)\n\tby ismtpd0003p1hnd1.sendgrid.net (SG) with ESMTP\n\tid yixeG_0lR_GhKVEIfHPBkA Thu, 25 Jun 2020 08:53:48.538 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"dAJNUUaR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=subject:references:from:mime-version:in-reply-to:to:content-type;\n\ts=s1; bh=YA8HGYHSYLnzU9hUOTSK1ISnUC6yuhS5Z4R6x6FOAEE=;\n\tb=dAJNUUaR8PFr+egfUARXfc9ogenfQNxOyQUiuC4rS8Rlr8KqJN6ewCCmbvgyE8wnLNW/\n\t8C8ocKVJKZqNwI1wk/InDHHWx0PKxu75QVeXsQpZXmi90RQpcjuxobzakf0XYijIOPX6Yd\n\tcBXEOa7AHGoBPwBgls4OJwgPwHw59V1Yk=","References":"<20200623105730.26956-1-chris@gregariousmammal.com>\n\t\n\t<603ee9f2-eab8-49e2-8ba2-c353063678d8@Spark>","From":"Umang Jain ","Message-ID":"<35c961bc-3807-6cf0-bb79-1008b6b980ca@uajain.com>","Date":"Thu, 25 Jun 2020 08:53:49 +0000 (UTC)","Mime-Version":"1.0","In-Reply-To":"<603ee9f2-eab8-49e2-8ba2-c353063678d8@Spark>","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcOiinPhbAFGEz1ue/PLGCvL9+ZcnZK2JurtvZXu2benDExDYcnkhqi/1QrpjNjvSN64tnWv0l3vPzCtLG9BLxUttcZ7v32ZsMCIjyfjUJYfhR7V+Lf/gCGVggY3LPP+Drx44rNO1y2m3U6qr6o3Yu/uBGT6e+6PBF/n8eavq9y27F6hToW20VSeMyBlbBbnFc","To":"Chris Chinchilla ,\n\tlibcamera-devel@lists.libcamera.org","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] Fix incorrect method in cameradata\n\tdocs","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============3160946013052602097==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":10851,"web_url":"https://patchwork.libcamera.org/comment/10851/","msgid":"","date":"2020-06-25T09:13:42","subject":"Re: [libcamera-devel] [PATCH] Fix incorrect method in cameradata\n\tdocs","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Chris,\n\nOn 23/06/2020 11:57, chris@gregariousmammal.com wrote:\n> From: Chris Chinchilla \n> \n> Fix incorrect method in cameradata docs\n\nWe normally wouldn't just repeat the $SUBJECT.\n\nI'll replace this with:\n\n\"\"\"\nThe pipeline handler documentation incorrectly references an old API\nusage of setCameraData, which should have been updated to\nregisterCamera() while updating pipeline handlers to ensure they all\nhave a pipeline-specific \"CameraData\" allocation.\n\nUpdate the remaining documentation reference.\n\"\"\"\n\n> \n> Fixes: b581b9576abd (\"libcamera: pipeline_handler: Make pipeline-specific data mandatory\")\n> Signed-off-by: Chris Chinchilla \n\nAnd I'll add the following:\n\nReviewed-by: Umang Jain \nReviewed-by: Laurent Pinchart \n\n\nThanks.\n\n\n\n> ---\n> src/libcamera/pipeline_handler.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index 14dfba0..15cdc17 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -46,7 +46,7 @@ LOG_DEFINE_CATEGORY(Pipeline)\n> *\n> * Pipeline handlers are expected to extend this base class with platform\n> * specific implementation, associate instances of the derived classes\n> - * using the setCameraData() method, and access them at a later time\n> + * using the registerCamera() method, and access them at a later time\n> * with cameraData().\n> */\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 871DAC0100\n\tfor ;\n\tThu, 25 Jun 2020 09:13:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E4B88609C3;\n\tThu, 25 Jun 2020 11:13:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 35441609A5\n\tfor ;\n\tThu, 25 Jun 2020 11:13:46 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 899BA535;\n\tThu, 25 Jun 2020 11:13:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ca62JMUg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593076425;\n\tbh=QqCp2wY6IVlz9BFFgfXHGB8PKEqdq5lfF9ToLTluXMY=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=ca62JMUgJxMPK3yYbxvQrRm/6Fg791K9Gor8MBJ+B/IprtP2f8P1qLk2cKDz6HR6L\n\tK45lQ4lN3fvMt6KrRCC43J+r02HiZWLCFVSxJKIm63Ti6lZfGqmnqjRsCLIu9FdEQz\n\ttOWUimPfXAXijhI8QpuSmUonBuebVehraiqzkqeQ=","To":"chris@gregariousmammal.com, libcamera-devel@lists.libcamera.org","References":"<20200623105730.26956-1-chris@gregariousmammal.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Thu, 25 Jun 2020 10:13:42 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.8.0","MIME-Version":"1.0","In-Reply-To":"<20200623105730.26956-1-chris@gregariousmammal.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] Fix incorrect method in cameradata\n\tdocs","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]