{"id":4141,"url":"https://patchwork.libcamera.org/api/patches/4141/?format=json","web_url":"https://patchwork.libcamera.org/patch/4141/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200623091404.15155-3-david.plowman@raspberrypi.com>","date":"2020-06-23T09:14:02","name":"[libcamera-devel,v3,2/4] libcamera: ipa: raspberrypi: Make sharpening mode_factor an ordinary double","commit_ref":"58e63a6e7e09f271793663024b9777fb6378c33b","pull_url":null,"state":"accepted","archived":false,"hash":"69cc99340d6deab89b7a0a81830fa9ef42fe9061","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/4141/mbox/","series":[{"id":1029,"url":"https://patchwork.libcamera.org/api/series/1029/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1029","date":"2020-06-23T09:14:00","name":"libcamera sharpness strength control","version":3,"mbox":"https://patchwork.libcamera.org/series/1029/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/4141/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/4141/checks/","tags":{},"headers":{"Return-Path":"","Received":["from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n\t[IPv6:2a00:1450:4864:20::329])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BC9BC609C2\n\tfor ;\n\tTue, 23 Jun 2020 11:14:11 +0200 (CEST)","by mail-wm1-x329.google.com with SMTP id g21so2419828wmg.0\n\tfor ;\n\tTue, 23 Jun 2020 02:14:11 -0700 (PDT)","from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tt125sm2931616wmf.10.2020.06.23.02.14.10\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 23 Jun 2020 02:14:10 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"r2F+CVGE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=blzNJOKYHnrUW4DxPt8nCOhq186OUDTiJdxCE82eKU0=;\n\tb=r2F+CVGER/Q1cGEK1WHJ9F9Rt6lCFe55VJFaMe43Aq9kXVNXubgzKEI5f3wQjvwt40\n\t8WXheColgZPPIpvZ+x9TOKIka8cmU8Z1xXykTJmhuASVpR2ICeF/w+KT3XnPk2TFTSzM\n\t3ziF47812vQUxrnYIQ165tGpin13gh1+W1jQ+PbLjAGXN530ZAxwFygDza89mNKOwzPl\n\t7sklbm2VmzEJDW+4/vQ3poF/1368mxCOt4tamFX5R+tDrUO23ZTda0d4GCxF2GQbCT4D\n\t95TULs93ngre2i55rQYxhMI3mRbOs+2eSy71d08LJx/7jjwu7optv4+wprnvMFnZsRMn\n\t9WsQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=blzNJOKYHnrUW4DxPt8nCOhq186OUDTiJdxCE82eKU0=;\n\tb=I5eElgL4HW2FSFNgFyiEjPYLrbzGnZhS++uHeC1DFxZRFLrAJaR0b70hWXT/U/yMl5\n\tfXsUkxqIu4+KfPA2m16CDuQ05F0vAt77FoRAJNx0kiV+61JXFSKpuDCx5uKsZk5fT3qv\n\tEfCKoS4POVbW2gM35c+PF6ffU5ge0jZnPuR5LzBQ1jIa7s28RbfW1l4sTWbQ0gKEIQbT\n\t22dFK+UKFJpWAHWlKMKGLy9MRhm6ZT27/y0AGuuX/oqGyQNrxtVp1dbB29x13Iduh6EU\n\tCyJD3iPmcqwjZUPjcTv15oWo30j6nBpgAHYwE/3UYbOV277bPtG9Z3CMpj0bIT8Glt9m\n\tTD5A==","X-Gm-Message-State":"AOAM530c3BRy4omzsja7r4J7VDBZvFc5rNN0Ba9TN7NeVhPLvIYHhtZr\n\tl7pERcq0Qcb7DkY/LuGK5P9MWJhKKks=","X-Google-Smtp-Source":"ABdhPJz1bWZIBj+jvYKOtRSYQDfkZBlt43bCSgbr0cf8kyAJ5NA8cLpRM/FAi/UStBG+i+y7RtTy9w==","X-Received":"by 2002:a1c:3c1:: with SMTP id 184mr22244921wmd.40.1592903650869;\n\tTue, 23 Jun 2020 02:14:10 -0700 (PDT)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 23 Jun 2020 10:14:02 +0100","Message-Id":"<20200623091404.15155-3-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20200623091404.15155-1-david.plowman@raspberrypi.com>","References":"<20200623091404.15155-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 2/4] libcamera: ipa: raspberrypi: Make\n\tsharpening mode_factor an ordinary double","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 23 Jun 2020 09:14:13 -0000"},"content":"No need for it to be std::atomic as SwitchMode runs synchronously with\nPrepare.\n\nSigned-off-by: David Plowman \n---\n src/ipa/raspberrypi/controller/rpi/sharpen.cpp | 7 +++----\n src/ipa/raspberrypi/controller/rpi/sharpen.hpp | 2 +-\n 2 files changed, 4 insertions(+), 5 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/controller/rpi/sharpen.cpp b/src/ipa/raspberrypi/controller/rpi/sharpen.cpp\nindex 086952f..4c2fdb3 100644\n--- a/src/ipa/raspberrypi/controller/rpi/sharpen.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/sharpen.cpp\n@@ -44,13 +44,12 @@ void Sharpen::Read(boost::property_tree::ptree const ¶ms)\n \n void Sharpen::Prepare(Metadata *image_metadata)\n {\n-\tdouble mode_factor = mode_factor_;\n \tstruct SharpenStatus status;\n \t// Binned modes seem to need the sharpening toned down with this\n \t// pipeline.\n-\tstatus.threshold = threshold_ * mode_factor;\n-\tstatus.strength = strength_ / mode_factor;\n-\tstatus.limit = limit_ / mode_factor;\n+\tstatus.threshold = threshold_ * mode_factor_;\n+\tstatus.strength = strength_ / mode_factor_;\n+\tstatus.limit = limit_ / mode_factor_;\n \timage_metadata->Set(\"sharpen.status\", status);\n }\n \ndiff --git a/src/ipa/raspberrypi/controller/rpi/sharpen.hpp b/src/ipa/raspberrypi/controller/rpi/sharpen.hpp\nindex f871aa6..a3bf899 100644\n--- a/src/ipa/raspberrypi/controller/rpi/sharpen.hpp\n+++ b/src/ipa/raspberrypi/controller/rpi/sharpen.hpp\n@@ -26,7 +26,7 @@ private:\n \tdouble threshold_;\n \tdouble strength_;\n \tdouble limit_;\n-\tstd::atomic mode_factor_;\n+\tdouble mode_factor_;\n };\n \n } // namespace RPi\n","prefixes":["libcamera-devel","v3","2/4"]}