[{"id":10802,"web_url":"https://patchwork.libcamera.org/comment/10802/","msgid":"<20200624160928.GE5980@pendragon.ideasonboard.com>","date":"2020-06-24T16:09:28","subject":"Re: [libcamera-devel] [PATCH] libcamera: formats: Add formats for\n\tIPU3","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Tue, Jun 23, 2020 at 04:11:30AM +0200, Niklas Söderlund wrote:\n> When replacing DRM FourCCs with libcamera formats IPU3 format\n> descriptors where missing resulting in RAW capture not being possible.\n> Fix this by adding the missing descriptors.\n> \n> Fixes: 56c99424edd64c5a (\"libcamera: pipeline: Replace explicit DRM FourCCs with libcamera formats\")\n> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\nSorry for breaking it in the first place.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  src/libcamera/formats.cpp | 28 ++++++++++++++++++++++++++++\n>  1 file changed, 28 insertions(+)\n> \n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index 97e986786cc810b8..1272de29c802c539 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -421,6 +421,34 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n>  \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n>  \t\t.packed = true,\n>  \t} },\n> +\t{ formats::SBGGR10_IPU3, {\n> +\t\t.format = formats::SBGGR10_IPU3,\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_IPU3_SBGGR10),\n> +\t\t.bitsPerPixel = 10,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +\t\t.packed = true,\n> +\t} },\n> +\t{ formats::SGBRG10_IPU3, {\n> +\t\t.format = formats::SGBRG10_IPU3,\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_IPU3_SGBRG10),\n> +\t\t.bitsPerPixel = 10,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +\t\t.packed = true,\n> +\t} },\n> +\t{ formats::SGRBG10_IPU3, {\n> +\t\t.format = formats::SGRBG10_IPU3,\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_IPU3_SGRBG10),\n> +\t\t.bitsPerPixel = 10,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +\t\t.packed = true,\n> +\t} },\n> +\t{ formats::SRGGB10_IPU3, {\n> +\t\t.format = formats::SRGGB10_IPU3,\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_IPU3_SRGGB10),\n> +\t\t.bitsPerPixel = 10,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +\t\t.packed = true,\n> +\t} },\n>  \n>  \t/* Compressed formats. */\n>  \t{ formats::MJPEG, {","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 74F65603B8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 24 Jun 2020 18:09:54 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D94242A8;\n\tWed, 24 Jun 2020 18:09:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"kVTaAfWi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593014994;\n\tbh=GywG8hD7E+lZzcQHeihwRIr0iB4k/JrnysrJPfc/eio=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=kVTaAfWi8iOZqgbpc+Ih6Mm2giysvvT+Q8MwlYNnktw6rFbaHVYIhlj2dMvxdVsyk\n\t8gdVfYivV9/5xRgXNh+Bu5IA7E0WTrDoAJIpMd6BgipgfkiCvXIWwlfqyYqKxe8XfT\n\tVGCCeZ2YaFRzNYiSF8dof+bnbVLLHiEtHvcN1Zzw=","Date":"Wed, 24 Jun 2020 19:09:28 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Niklas =?utf-8?q?S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200624160928.GE5980@pendragon.ideasonboard.com>","References":"<20200623021130.1782426-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200623021130.1782426-1-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: formats: Add formats for\n\tIPU3","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Wed, 24 Jun 2020 16:09:54 -0000"}}]