[{"id":5379,"web_url":"https://patchwork.libcamera.org/comment/5379/","msgid":"<20200624234653.GM5980@pendragon.ideasonboard.com>","date":"2020-06-24T23:46:53","subject":"Re: [libcamera-devel] [PATCH v3 02/10] libcamera: ipu3: Fold\n\tmediaBusToFormat() into only caller","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Tue, Jun 23, 2020 at 04:09:22AM +0200, Niklas Söderlund wrote:\n> Make the code easier to read and refactor.\n\nI actually think it's more difficult to read like this :-)\n\n> Signed-off-by: Niklas Söderlund \n> Reviewed-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 38 ++++++++++++++--------------\n> 1 file changed, 19 insertions(+), 19 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 1a59de0c58975b3c..c525e30a5ad35011 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -134,8 +134,6 @@ public:\n> \tint start();\n> \tint stop();\n> \n> -\tstatic V4L2PixelFormat mediaBusToFormat(unsigned int code);\n> -\n> \tV4L2VideoDevice *output_;\n> \tV4L2Subdevice *csi2_;\n> \tCameraSensor *sensor_;\n> @@ -1503,7 +1501,25 @@ int CIO2Device::configure(const Size &size,\n> \tif (ret)\n> \t\treturn ret;\n> \n> -\toutputFormat->fourcc = mediaBusToFormat(sensorFormat.mbus_code);\n> +\tV4L2PixelFormat v4l2Format;\n> +\tswitch (sensorFormat.mbus_code) {\n> +\tcase MEDIA_BUS_FMT_SBGGR10_1X10:\n> +\t\tv4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_IPU3_SBGGR10);\n> +\t\tbreak;\n> +\tcase MEDIA_BUS_FMT_SGBRG10_1X10:\n> +\t\tv4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_IPU3_SGBRG10);\n> +\t\tbreak;\n> +\tcase MEDIA_BUS_FMT_SGRBG10_1X10:\n> +\t\tv4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_IPU3_SGRBG10);\n> +\t\tbreak;\n> +\tcase MEDIA_BUS_FMT_SRGGB10_1X10:\n> +\t\tv4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_IPU3_SRGGB10);\n> +\t\tbreak;\n> +\tdefault:\n> +\t\treturn -EINVAL;\n> +\t}\n> +\n> +\toutputFormat->fourcc = v4l2Format;\n> \toutputFormat->size = sensorFormat.size;\n> \toutputFormat->planesCount = 1;\n> \n> @@ -1577,22 +1593,6 @@ int CIO2Device::stop()\n> \treturn output_->streamOff();\n> }\n> \n> -V4L2PixelFormat CIO2Device::mediaBusToFormat(unsigned int code)\n> -{\n> -\tswitch (code) {\n> -\tcase MEDIA_BUS_FMT_SBGGR10_1X10:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_IPU3_SBGGR10);\n> -\tcase MEDIA_BUS_FMT_SGBRG10_1X10:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_IPU3_SGBRG10);\n> -\tcase MEDIA_BUS_FMT_SGRBG10_1X10:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_IPU3_SGRBG10);\n> -\tcase MEDIA_BUS_FMT_SRGGB10_1X10:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_IPU3_SRGGB10);\n> -\tdefault:\n> -\t\treturn {};\n> -\t}\n> -}\n> -\n> REGISTER_PIPELINE_HANDLER(PipelineHandlerIPU3);\n> \n> } /* namespace libcamera */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C8AA6C0100\n\tfor ;\n\tWed, 24 Jun 2020 23:46:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 552AB609A5;\n\tThu, 25 Jun 2020 01:46:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0BD21603BB\n\tfor ;\n\tThu, 25 Jun 2020 01:46:55 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6D6202A8;\n\tThu, 25 Jun 2020 01:46:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ecrcf27l\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593042414;\n\tbh=9Jg4I74bOUzIjWnz7w8d4vinLvx9yTgrww5705whhic=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Ecrcf27lzFfOLxlnVv5bQYhPPSjYIuGD4WR6SR+Yk5j0GWD44Z+nRc3mvo6Y/WsSa\n\tAHNbyXylFSbdtJHodIc1/NDAdut2lVMpf1kHJYN5sWEwQxuLqtj3rUT+xbrTSTuDRJ\n\tdGo3xKI4n6Ve64952w9AHB/HaZrGy/4rLctu4ff4=","Date":"Thu, 25 Jun 2020 02:46:53 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200624234653.GM5980@pendragon.ideasonboard.com>","References":"<20200623020930.1781469-1-niklas.soderlund@ragnatech.se>\n\t<20200623020930.1781469-3-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200623020930.1781469-3-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v3 02/10] libcamera: ipu3: Fold\n\tmediaBusToFormat() into only caller","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]